René's URL Explorer Experiment


Title: [3.10] gh-94207: Fix struct module leak (GH-94239) by miss-islington · Pull Request #94266 · python/cpython · GitHub

Open Graph Title: [3.10] gh-94207: Fix struct module leak (GH-94239) by miss-islington · Pull Request #94266 · python/cpython

X Title: [3.10] gh-94207: Fix struct module leak (GH-94239) by miss-islington · Pull Request #94266 · python/cpython

Description: Make _struct.Struct a GC type This fixes a memory leak in the _struct module, where as soon as a Struct object is stored in the cache, there's a cycle from the _struct module to the cache to Struct objects to the Struct type back to the module. If _struct.Struct is not gc-tracked, that cycle is never collected. This PR makes _struct.Struct GC-tracked, and adds a regression test. (cherry picked from commit 6b86534) Co-authored-by: Mark Dickinson mdickinson@enthought.com Issue: gh-94207

Open Graph Description: Make _struct.Struct a GC type This fixes a memory leak in the _struct module, where as soon as a Struct object is stored in the cache, there's a cycle from the _struct module to the cache to St...

X Description: Make _struct.Struct a GC type This fixes a memory leak in the _struct module, where as soon as a Struct object is stored in the cache, there's a cycle from the _struct module to the cache t...

Opengraph URL: https://github.com/python/cpython/pull/94266

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8deacda-e652-7130-965f-73b2c3eed5ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA190:2ACFDC:121A786:1859FB5:6969AD8E
html-safe-nonce7527a60bd5dbd01fd6941ec26f716cd635926b354f6038a6393d886b7c3ab74c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTkwOjJBQ0ZEQzoxMjFBNzg2OjE4NTlGQjU6Njk2OUFEOEUiLCJ2aXNpdG9yX2lkIjoiNzcwMjg0MDY1ODE5OTQyNDM5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c474ddf0a46b76e22d338bee105cf8dbf0e9bd72dc5c964541cfdce87ab27c4
hovercard-subject-tagpull_request:979059010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/94266/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altMake _struct.Struct a GC type This fixes a memory leak in the _struct module, where as soon as a Struct object is stored in the cache, there's a cycle from the _struct module to the cache to St...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/94266/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94266%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F94266%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/94266/files
Reloadhttps://github.com/python/cpython/pull/94266/files
Reloadhttps://github.com/python/cpython/pull/94266/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/94266/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/94266/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mdickinsonhttps://github.com/mdickinson
python:3.10https://github.com/python/cpython/tree/3.10
miss-islington:backport-6b86534-3.10https://github.com/miss-islington/cpython/tree/backport-6b86534-3.10
Conversation 1 https://github.com/python/cpython/pull/94266
Commits 2 https://github.com/python/cpython/pull/94266/commits
Checks 0 https://github.com/python/cpython/pull/94266/checks
Files changed https://github.com/python/cpython/pull/94266/files
Please reload this pagehttps://github.com/python/cpython/pull/94266/files
[3.10] gh-94207: Fix struct module leak (GH-94239) https://github.com/python/cpython/pull/94266/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/94266/files
69306b6 gh-94207: Fix struct module leak (GH-94239) mdickinson Jun 25, 2022 https://github.com/python/cpython/pull/94266/commits/69306b6d22f782c980c6dcc0460bdaf549e94cae
4b29b97 Fix missing import mdickinson Jun 25, 2022 https://github.com/python/cpython/pull/94266/commits/4b29b973cb9b9ec0297dab19e2539b4868204796
Clear filters https://github.com/python/cpython/pull/94266/files
Please reload this pagehttps://github.com/python/cpython/pull/94266/files
Please reload this pagehttps://github.com/python/cpython/pull/94266/files
test_struct.py https://github.com/python/cpython/pull/94266/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
2022-06-24-19-23-59.gh-issue-94207.VhS1eS.rst https://github.com/python/cpython/pull/94266/files#diff-7a78b4f1c9e0cb02f724138e825b6fa23a74bb06cc972674c96d8e43b7276c21
_struct.c https://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
Lib/test/test_struct.pyhttps://github.com/python/cpython/pull/94266/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
View file https://github.com/miss-islington/cpython/blob/4b29b973cb9b9ec0297dab19e2539b4868204796/Lib/test/test_struct.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94266/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94266/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/python/cpython/pull/94266/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/python/cpython/pull/94266/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
Misc/NEWS.d/next/Library/2022-06-24-19-23-59.gh-issue-94207.VhS1eS.rsthttps://github.com/python/cpython/pull/94266/files#diff-7a78b4f1c9e0cb02f724138e825b6fa23a74bb06cc972674c96d8e43b7276c21
View file https://github.com/miss-islington/cpython/blob/4b29b973cb9b9ec0297dab19e2539b4868204796/Misc/NEWS.d/next/Library/2022-06-24-19-23-59.gh-issue-94207.VhS1eS.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94266/{{ revealButtonHref }}
Modules/_struct.chttps://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
View file https://github.com/miss-islington/cpython/blob/4b29b973cb9b9ec0297dab19e2539b4868204796/Modules/_struct.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/94266/{{ revealButtonHref }}
https://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com/python/cpython/pull/94266/files#diff-13025e64470dd9f01cdfcf972b3aa2712511d83f8db49d587d85b43b2946e87b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.