René's URL Explorer Experiment


Title: GH-91389: Fix `dis` position information for `CACHE`s by brandtbucher · Pull Request #93663 · python/cpython · GitHub

Open Graph Title: GH-91389: Fix `dis` position information for `CACHE`s by brandtbucher · Pull Request #93663 · python/cpython

X Title: GH-91389: Fix `dis` position information for `CACHE`s by brandtbucher · Pull Request #93663 · python/cpython

Description: We currently don't advance the co_positions iterator for CACHE entries, which can lead to incorrect positions being reported for later instructions. Also, the positions for cache entries should be populated, not None. Also, don't show a "pretty" argrepr for cache entries unless they're actually being used by a quickened instruction. This cuts down on visual clutter when show_caches=True, adaptive=False, or for instructionss we've completely unquickened.

Open Graph Description: We currently don't advance the co_positions iterator for CACHE entries, which can lead to incorrect positions being reported for later instructions. Also, the positions for cache entries should...

X Description: We currently don't advance the co_positions iterator for CACHE entries, which can lead to incorrect positions being reported for later instructions. Also, the positions for cache entries sh...

Opengraph URL: https://github.com/python/cpython/pull/93663

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30847715-4e5e-ad98-35ac-a817c0f0999c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB30:1ED5B9:DD7BE8:12F64FF:6969EFA8
html-safe-nonce583fc09cb9190090a16f2e988ca05442872163242c4745c2883b6761f6864a05
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjMwOjFFRDVCOTpERDdCRTg6MTJGNjRGRjo2OTY5RUZBOCIsInZpc2l0b3JfaWQiOiI4MzAyNDU4MzE5Mzg0NzM1NjU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2affb6801d8df2b369eb4c78b3010987357d66a270ea2ee367f36e6e4b4d4a9b
hovercard-subject-tagpull_request:963471044
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93663/files
twitter:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40968415?s=400&v=4
og:image:altWe currently don't advance the co_positions iterator for CACHE entries, which can lead to incorrect positions being reported for later instructions. Also, the positions for cache entries should...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93663/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93663%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93663%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93663/files
Reloadhttps://github.com/python/cpython/pull/93663/files
Reloadhttps://github.com/python/cpython/pull/93663/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93663/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93663/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:dispositionhttps://github.com/brandtbucher/cpython/tree/disposition
Conversation 8 https://github.com/python/cpython/pull/93663
Commits 7 https://github.com/python/cpython/pull/93663/commits
Checks 0 https://github.com/python/cpython/pull/93663/checks
Files changed https://github.com/python/cpython/pull/93663/files
Please reload this pagehttps://github.com/python/cpython/pull/93663/files
GH-91389: Fix dis position information for CACHEs https://github.com/python/cpython/pull/93663/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/93663/files
41cfadc Update tests for intended behavior brandtbucher Jun 9, 2022 https://github.com/python/cpython/pull/93663/commits/41cfadcd6f59132e76e87793d516fbb8afa32160
0653bc5 Fix interactions between Positions and CACHEs brandtbucher Jun 9, 2022 https://github.com/python/cpython/pull/93663/commits/0653bc5684c62b7e9fe68d5209a93411d93705cd
44c742a blurb add brandtbucher Jun 10, 2022 https://github.com/python/cpython/pull/93663/commits/44c742aaad2fc0fd46ddf6cf189eb06d882b1802
986ce3a make patchcheck brandtbucher Jun 10, 2022 https://github.com/python/cpython/pull/93663/commits/986ce3a1ad0020a147145eb0241d5d078b3586df
994d711 Catch up with main brandtbucher Jun 16, 2022 https://github.com/python/cpython/pull/93663/commits/994d711038a7baf7269d19fbaf88a5e91b12e966
8266ba9 Feedback from code review brandtbucher Jun 16, 2022 https://github.com/python/cpython/pull/93663/commits/8266ba9c658609a25cbe15dd66bc63b4f58878f1
d500bf2 Naming is hard brandtbucher Jun 16, 2022 https://github.com/python/cpython/pull/93663/commits/d500bf2a0a7875618889919d3a979db0e0e8b33e
Clear filters https://github.com/python/cpython/pull/93663/files
Please reload this pagehttps://github.com/python/cpython/pull/93663/files
Please reload this pagehttps://github.com/python/cpython/pull/93663/files
dis.py https://github.com/python/cpython/pull/93663/files#diff-96747735ee3c8aed3dd0f4c1b1ab0310eeb344577b14887cc9f6605892df47a8
test_dis.py https://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
2022-06-09-17-15-26.gh-issue-91389.OE4vS5.rst https://github.com/python/cpython/pull/93663/files#diff-5b83c62abfe275f9115b0e2cf368fe6426e82cdbb3381e047fb422835cbaaf19
Lib/dis.pyhttps://github.com/python/cpython/pull/93663/files#diff-96747735ee3c8aed3dd0f4c1b1ab0310eeb344577b14887cc9f6605892df47a8
View file https://github.com/brandtbucher/cpython/blob/d500bf2a0a7875618889919d3a979db0e0e8b33e/Lib/dis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93663/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93663/files#diff-96747735ee3c8aed3dd0f4c1b1ab0310eeb344577b14887cc9f6605892df47a8
https://github.com/python/cpython/pull/93663/files#diff-96747735ee3c8aed3dd0f4c1b1ab0310eeb344577b14887cc9f6605892df47a8
Lib/test/test_dis.pyhttps://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
View file https://github.com/brandtbucher/cpython/blob/d500bf2a0a7875618889919d3a979db0e0e8b33e/Lib/test/test_dis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93663/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
https://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
https://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
https://github.com/python/cpython/pull/93663/files#diff-fd7b118a01a9695dfa16eea9381d3c7b0652e1b7b55f51ff052a1f620d175642
Misc/NEWS.d/next/Library/2022-06-09-17-15-26.gh-issue-91389.OE4vS5.rsthttps://github.com/python/cpython/pull/93663/files#diff-5b83c62abfe275f9115b0e2cf368fe6426e82cdbb3381e047fb422835cbaaf19
View file https://github.com/brandtbucher/cpython/blob/d500bf2a0a7875618889919d3a979db0e0e8b33e/Misc/NEWS.d/next/Library/2022-06-09-17-15-26.gh-issue-91389.OE4vS5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93663/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.