René's URL Explorer Experiment


Title: gh-79579: Improve DML query detection in sqlite3 by erlend-aasland · Pull Request #93623 · python/cpython · GitHub

Open Graph Title: gh-79579: Improve DML query detection in sqlite3 by erlend-aasland · Pull Request #93623 · python/cpython

X Title: gh-79579: Improve DML query detection in sqlite3 by erlend-aasland · Pull Request #93623 · python/cpython

Description: Strip whitespace and comments from queries in order to harden DML query detection. Resolves #79579

Open Graph Description: Strip whitespace and comments from queries in order to harden DML query detection. Resolves #79579

X Description: Strip whitespace and comments from queries in order to harden DML query detection. Resolves #79579

Opengraph URL: https://github.com/python/cpython/pull/93623

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b021b98a-df29-83f4-1623-c499e3e11041
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE962:B8D80:A22EEC8:DD2EF95:6996DC31
html-safe-nonce3f0ee6d4afee849b52d6cb7075df2383c3bc5f958a23bf2f77867a8425409d78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTYyOkI4RDgwOkEyMkVFQzg6REQyRUY5NTo2OTk2REMzMSIsInZpc2l0b3JfaWQiOiIyMzUyNzkzNDUwMjc2Mzc5Njk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3e13611f8189cb4d3aa374561030aea33eceff5d2bee3cbc0c3a52e8ff78e129
hovercard-subject-tagpull_request:962263186
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
twitter:imagehttps://avatars.githubusercontent.com/u/13780613?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13780613?s=400&v=4
og:image:altStrip whitespace and comments from queries in order to harden DML query detection. Resolves #79579
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec1c98ba212ddfc3e30024d245fa7d1030145c2e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93623%2Fcommits%2F8f29283ac59e07d9a82bfb66219647e4b92213f9
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93623%2Fcommits%2F8f29283ac59e07d9a82bfb66219647e4b92213f9
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Reloadhttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Reloadhttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-rowcount/gh-79579-althttps://github.com/erlend-aasland/cpython/tree/sqlite-rowcount/gh-79579-alt
Conversation 26 https://github.com/python/cpython/pull/93623
Commits 22 https://github.com/python/cpython/pull/93623/commits
Checks 0 https://github.com/python/cpython/pull/93623/checks
Files changed https://github.com/python/cpython/pull/93623/files
Please reload this pagehttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
gh-79579: Improve DML query detection in sqlite3 https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9#top
Show all changes 22 commits https://github.com/python/cpython/pull/93623/files
c8bcf3b Add tests erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/c8bcf3b2b8f0a469f659af56d53057bd9e1018f0
d38e632 Modify pysqlite_check_remaining_sql to return char * iso. int erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/d38e632068fc9377dee1b729d325a10f7ecdbbd3
7fcca68 Rename pysqlite_check_remaining_sql to lstrip_sql erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/7fcca68a093a53ef8cc10dc3cd318f30596ad334
3061dc5 Use lstrip_sql() to strip comments and whitespace erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/3061dc57c73bce958e3f58ec51d31bd7b5f3d68d
631f24d Adjust comment erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/631f24dd076319234720da4f2584996a0f1a316b
8f29283 Explicit comparison erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
a51cfe6 Add more tests erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/a51cfe6e4ac747bdf5419db6019b50adf37d7d6c
bf0e150 Fix bug in lstrip parser erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/bf0e150c483832b77e45d0794460aca3a1822274
5918fbe Adjust NEWS erlend-aasland Jun 8, 2022 https://github.com/python/cpython/pull/93623/commits/5918fbed3b50177058b128ee64662f7d6a965869
b45e5b5 Make test more messy erlend-aasland Jun 9, 2022 https://github.com/python/cpython/pull/93623/commits/b45e5b50fd71fce8e779550361662d91a03729cd
b0a7fbc Address Ma Lin's review erlend-aasland Jun 9, 2022 https://github.com/python/cpython/pull/93623/commits/b0a7fbc7cabe1e6e5f4c98129305c219a54b7da2
61a81eb Reword comment erlend-aasland Jun 9, 2022 https://github.com/python/cpython/pull/93623/commits/61a81eb23ca6212edcd7c05fd858898f2938a87b
e3fea31 Inline it erlend-aasland Jun 9, 2022 https://github.com/python/cpython/pull/93623/commits/e3fea31348d2cdab28710a0ebbb7e246d7b1212f
d6ce75c Further mess up messy test to increase code coverage erlend-aasland Jun 9, 2022 https://github.com/python/cpython/pull/93623/commits/d6ce75c04b73023dbd047de66d871ca9f8da5342
7f7943f Increase code coverage erlend-aasland Jun 10, 2022 https://github.com/python/cpython/pull/93623/commits/7f7943fdbca8f0b5af12d0e5b52b0803128499df
adcba2c Merge branch 'main' into sqlite-rowcount/gh-79579-alt erlend-aasland Jun 12, 2022 https://github.com/python/cpython/pull/93623/commits/adcba2c87385b270d7933f732c2cabf289482b9a
e5fafc7 Rewrite lstrip_sql by borrowing from SQLite's parser erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/e5fafc72b2cd1b8888f55b5ff59b94d4232dc4fa
7d7a654 Test code nit erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/7d7a654334995436c76f624fa123892615e91ca8
2e638a0 Harden test_rowcount_prefixed_with_comment test erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/2e638a0422200abcee1b49b147f98676ca2ce462
b932e4f Simplify one test erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/b932e4f3558d967da60d6f88d5b094d58b148e23
ca053d7 Fix ret value for invalid comments erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/ca053d7f7848548729985d0428d3a3f30fd4a29e
c6fa9b2 Simplify erlend-aasland Jun 13, 2022 https://github.com/python/cpython/pull/93623/commits/c6fa9b298372603f174785f014e291b62b04fb8d
Clear filters https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Please reload this pagehttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Please reload this pagehttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
Prev https://github.com/python/cpython/pull/93623/commits/631f24dd076319234720da4f2584996a0f1a316b
Next https://github.com/python/cpython/pull/93623/commits/a51cfe6e4ac747bdf5419db6019b50adf37d7d6c
Please reload this pagehttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/python/cpython/commits?author=erlend-aasland
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L589
Modules/_sqlite/statement.chttps://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
View file https://github.com/erlend-aasland/cpython/blob/8f29283ac59e07d9a82bfb66219647e4b92213f9/Modules/_sqlite/statement.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93623/commits/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com/python/cpython/pull/93623/commits/8f29283ac59e07d9a82bfb66219647e4b92213f9#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.