René's URL Explorer Experiment


Title: GH-93521: Filter out `__weakref__` slot if present in bases by Bluenix2 · Pull Request #93535 · python/cpython · GitHub

Open Graph Title: GH-93521: Filter out `__weakref__` slot if present in bases by Bluenix2 · Pull Request #93535 · python/cpython

X Title: GH-93521: Filter out `__weakref__` slot if present in bases by Bluenix2 · Pull Request #93535 · python/cpython

Description: This PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.

Open Graph Description: This PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.

X Description: This PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.

Opengraph URL: https://github.com/python/cpython/pull/93535

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d967772f-b647-8ff8-0905-c4ff20e9ec0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95BC:247F51:19C226F:22AD4BB:6969B313
html-safe-noncec3078ef4ad29a26109d12eaf5ff73f9574265cd7bffc1279f4cb7f691b47eb9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUJDOjI0N0Y1MToxOUMyMjZGOjIyQUQ0QkI6Njk2OUIzMTMiLCJ2aXNpdG9yX2lkIjoiMzA5ODY3MDkzNTYxOTI1MzAxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3cbab1616e310b3efde284fba3e37c797b2d68612f5defdbc0ce4a232354e446
hovercard-subject-tagpull_request:959093664
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93535/files
twitter:imagehttps://avatars.githubusercontent.com/u/38372706?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/38372706?s=400&v=4
og:image:altThis PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93535/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93535%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93535%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93535/files
Reloadhttps://github.com/python/cpython/pull/93535/files
Reloadhttps://github.com/python/cpython/pull/93535/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericvsmithhttps://github.com/ericvsmith
python:mainhttps://github.com/python/cpython/tree/main
Bluenix2:fix-93521https://github.com/Bluenix2/cpython/tree/fix-93521
Conversation 11 https://github.com/python/cpython/pull/93535
Commits 4 https://github.com/python/cpython/pull/93535/commits
Checks 0 https://github.com/python/cpython/pull/93535/checks
Files changed https://github.com/python/cpython/pull/93535/files
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
GH-93521: Filter out __weakref__ slot if present in bases https://github.com/python/cpython/pull/93535/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/93535/files
abdab30 GH-93521: Filter out `__weakref__` slot if present in bases Bluenix2 Jun 6, 2022 https://github.com/python/cpython/pull/93535/commits/abdab302dae0b37297af4dd316db207b977a2fc0
5ee1d76 📜🤖 Added by blurb_it. blurb-it[bot] Jun 6, 2022 https://github.com/python/cpython/pull/93535/commits/5ee1d76fb4f7eca79ba17fc5ae4ac8c990fff2a2
47a107f Expand test coverage of subclasses specifying `__weakref__` Bluenix2 Jun 6, 2022 https://github.com/python/cpython/pull/93535/commits/47a107ffc45842f72c6e387097374439e73a9e53
187a0fe Reword news blurb to explain change without context Bluenix2 Jun 6, 2022 https://github.com/python/cpython/pull/93535/commits/187a0fef6f661e8491b8e099ccd639ad5a48c79a
Clear filters https://github.com/python/cpython/pull/93535/files
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
dataclasses.py https://github.com/python/cpython/pull/93535/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
test_dataclasses.py https://github.com/python/cpython/pull/93535/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
2022-06-06-13-19-43.gh-issue-93521._vE8m9.rst https://github.com/python/cpython/pull/93535/files#diff-6832d994e3f61b916fb9cb5347d6f0f82625782f9c1e97b1ec7f920807f18d88
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L415
Lib/dataclasses.pyhttps://github.com/python/cpython/pull/93535/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
View file https://github.com/Bluenix2/cpython/blob/187a0fef6f661e8491b8e099ccd639ad5a48c79a/Lib/dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93535/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93535/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
https://github.com/python/cpython/pull/93535/files#diff-44ce2dc1c4922b2f5cf7631d8f86cc569a4c25eb003aaecdc2bc22eb9163d5f5
Lib/test/test_dataclasses.pyhttps://github.com/python/cpython/pull/93535/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
View file https://github.com/Bluenix2/cpython/blob/187a0fef6f661e8491b8e099ccd639ad5a48c79a/Lib/test/test_dataclasses.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93535/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93535/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
Please reload this pagehttps://github.com/python/cpython/pull/93535/files
https://github.com/python/cpython/pull/93535/files#diff-f0436842533448f8f02a19081d7c9cc8372b6685756caf32c83dfecebbee68e7
Misc/NEWS.d/next/Library/2022-06-06-13-19-43.gh-issue-93521._vE8m9.rsthttps://github.com/python/cpython/pull/93535/files#diff-6832d994e3f61b916fb9cb5347d6f0f82625782f9c1e97b1ec7f920807f18d88
View file https://github.com/Bluenix2/cpython/blob/187a0fef6f661e8491b8e099ccd639ad5a48c79a/Misc/NEWS.d/next/Library/2022-06-06-13-19-43.gh-issue-93521._vE8m9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93535/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.