René's URL Explorer Experiment


Title: gh-93421: Fix sqlite3 cursor `.rowcount` for UPDATE ... RETURNING queries by erlend-aasland · Pull Request #93520 · python/cpython · GitHub

Open Graph Title: gh-93421: Fix sqlite3 cursor `.rowcount` for UPDATE ... RETURNING queries by erlend-aasland · Pull Request #93520 · python/cpython

X Title: gh-93421: Fix sqlite3 cursor `.rowcount` for UPDATE ... RETURNING queries by erlend-aasland · Pull Request #93520 · python/cpython

Description: Resolves #93421

Open Graph Description: Resolves #93421

X Description: Resolves #93421

Opengraph URL: https://github.com/python/cpython/pull/93520

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:37fb84e7-f640-0382-4921-3b2ddb06614f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5F8:1860A8:162A021:1EA3A6C:696A98FA
html-safe-nonce0ae21a669338b57608319f96701f561fe5fcccab86dbd60a0382808824282561
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUY4OjE4NjBBODoxNjJBMDIxOjFFQTNBNkM6Njk2QTk4RkEiLCJ2aXNpdG9yX2lkIjoiNzYyNDk2MTYyNjgzMzg1MjY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceee43d6433f55418dfc43507faaf78ce26fae227f2004f600b1f965a98446b07
hovercard-subject-tagpull_request:958499100
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/93520/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/256ec60743072a1e130bc9d9d8c6059fb6f5006dfbdf74d4476bda9663d00637/python/cpython/pull/93520
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/256ec60743072a1e130bc9d9d8c6059fb6f5006dfbdf74d4476bda9663d00637/python/cpython/pull/93520
og:image:altResolves #93421
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93520#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93520
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93520
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93520
Reloadhttps://github.com/python/cpython/pull/93520
Reloadhttps://github.com/python/cpython/pull/93520
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93520
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93520
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/93520#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-changeshttps://github.com/erlend-aasland/cpython/tree/sqlite-changes
gh-93421: Fix sqlite3 cursor .rowcount for UPDATE ... RETURNING queries https://github.com/python/cpython/pull/93520#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-changeshttps://github.com/erlend-aasland/cpython/tree/sqlite-changes
Conversation 10 https://github.com/python/cpython/pull/93520
Commits 9 https://github.com/python/cpython/pull/93520/commits
Checks 0 https://github.com/python/cpython/pull/93520/checks
Files changed https://github.com/python/cpython/pull/93520/files
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 5, 2022https://github.com/python/cpython/pull/93520#issue-1261156082
Please reload this pagehttps://github.com/python/cpython/pull/93520
#93421https://github.com/python/cpython/issues/93421
Please reload this pagehttps://github.com/python/cpython/pull/93520
erlend-aaslandhttps://github.com/erlend-aasland
June 5, 2022 22:11https://github.com/python/cpython/pull/93520#commits-pushed-5436db7
https://github.com/erlend-aasland
Try lazy rowcount approachhttps://github.com/python/cpython/pull/93520/commits/5436db7e3d9f1de8cf1e1049a7ff7e7db2061080
5436db7https://github.com/python/cpython/pull/93520/commits/5436db7e3d9f1de8cf1e1049a7ff7e7db2061080
https://github.com/erlend-aasland
Calculate rowcount using sqlite3_total_changes() diffhttps://github.com/python/cpython/pull/93520/commits/84891c6fffc6f44d92bc1f9d3cbad00cf3593fe1
84891c6https://github.com/python/cpython/pull/93520/commits/84891c6fffc6f44d92bc1f9d3cbad00cf3593fe1
https://github.com/erlend-aasland
Add NEWShttps://github.com/python/cpython/pull/93520/commits/a5fca9d2a6114c279309f5b23e69aa354d8552cc
a5fca9dhttps://github.com/python/cpython/pull/93520/commits/a5fca9d2a6114c279309f5b23e69aa354d8552cc
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
berkerpeksaghttps://github.com/berkerpeksag
code ownerhttps://github.com/python/cpython/blob/4082c8e298a244edf6771839334372a47ece721d/.github/CODEOWNERS#L101
June 5, 2022 20:46https://github.com/python/cpython/pull/93520#event-6749229059
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749229108
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749229357
SQLite rowcount is corrupted when combining UPDATE RETURNING w/ table that is dropped and recreated #93421 https://github.com/python/cpython/issues/93421
https://github.com/erlend-aasland
Fix return valuehttps://github.com/python/cpython/pull/93520/commits/58199023d3d828b937294c0d75656cbf5da3c03a
5819902https://github.com/python/cpython/pull/93520/commits/58199023d3d828b937294c0d75656cbf5da3c03a
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749262023
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 5, 2022https://github.com/python/cpython/pull/93520#issuecomment-1146885848
@erlend-aaslandhttps://github.com/erlend-aasland
5819902https://github.com/python/cpython/commit/58199023d3d828b937294c0d75656cbf5da3c03a
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749262065
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
serhiy-storchakahttps://github.com/serhiy-storchaka
June 5, 2022 21:27https://github.com/python/cpython/pull/93520#event-6749267106
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749267246
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749268258
https://github.com/erlend-aasland
Add testshttps://github.com/python/cpython/pull/93520/commits/5165a3a46f828efb1bcfa36a48d73ab8d79fc0da
5165a3ahttps://github.com/python/cpython/pull/93520/commits/5165a3a46f828efb1bcfa36a48d73ab8d79fc0da
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749309825
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 5, 2022https://github.com/python/cpython/pull/93520#issuecomment-1146892813
@erlend-aaslandhttps://github.com/erlend-aasland
5165a3ahttps://github.com/python/cpython/commit/5165a3a46f828efb1bcfa36a48d73ab8d79fc0da
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749309850
https://github.com/erlend-aasland
Remove spurious changehttps://github.com/python/cpython/pull/93520/commits/1da6390fe513b69f0edb1fc92fe6a30e52cc589e
1da6390https://github.com/python/cpython/pull/93520/commits/1da6390fe513b69f0edb1fc92fe6a30e52cc589e
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749333044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 5, 2022https://github.com/python/cpython/pull/93520#issuecomment-1146896292
@erlend-aaslandhttps://github.com/erlend-aasland
1da6390https://github.com/python/cpython/commit/1da6390fe513b69f0edb1fc92fe6a30e52cc589e
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jun 5, 2022https://github.com/python/cpython/pull/93520#event-6749333072
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2022 https://github.com/python/cpython/pull/93520#ref-pullrequest-1261416878
gh-93421: Update sqlite3 cursor.rowcount after SQLITE_DONE #93526 https://github.com/python/cpython/pull/93526
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2022https://github.com/python/cpython/pull/93520#issuecomment-1147304217
Please reload this pagehttps://github.com/python/cpython/pull/93520
SQLite rowcount is corrupted when combining UPDATE RETURNING w/ table that is dropped and recreated #93421 https://github.com/python/cpython/issues/93421
gh-79579: Update sqlite3.Cursor.rowcount for all data-modifying queries #93532 https://github.com/python/cpython/pull/93532
https://github.com/ghost
ghosthttps://github.com/ghost
Jun 6, 2022https://github.com/python/cpython/pull/93520#issuecomment-1147471361
dochttps://www.sqlite.org/c3ref/total_changes.html
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2022https://github.com/python/cpython/pull/93520#issuecomment-1147602053
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2022https://github.com/python/cpython/pull/93520#issuecomment-1147617867
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
Merge branch 'main' into sqlite-changeshttps://github.com/python/cpython/pull/93520/commits/0df76525cedcbffd2861c4c6317fb498a8de3f6a
0df7652https://github.com/python/cpython/pull/93520/commits/0df76525cedcbffd2861c4c6317fb498a8de3f6a
erlend-aaslandhttps://github.com/erlend-aasland
June 6, 2022 22:08https://github.com/python/cpython/pull/93520#commits-pushed-c4f6926
https://github.com/erlend-aasland
Revert sqlite3_stmt_readonly changehttps://github.com/python/cpython/pull/93520/commits/c4f6926b9719f0eeba297390ae809d37f866d02e
c4f6926https://github.com/python/cpython/pull/93520/commits/c4f6926b9719f0eeba297390ae809d37f866d02e
https://github.com/erlend-aasland
Use sqlite3_total_changes64 if availablehttps://github.com/python/cpython/pull/93520/commits/20397c5c6c53e874f31f65b3435bd648256f9ebe
20397c5https://github.com/python/cpython/pull/93520/commits/20397c5c6c53e874f31f65b3435bd648256f9ebe
https://github.com/ghost
ghosthttps://github.com/ghost
Jun 7, 2022https://github.com/python/cpython/pull/93520#issuecomment-1148130785
Please reload this pagehttps://github.com/python/cpython/pull/93520
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 7, 2022https://github.com/python/cpython/pull/93520#issuecomment-1148588266
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Jun 7, 2022https://github.com/python/cpython/pull/93520#event-6764050074
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 7, 2022https://github.com/python/cpython/pull/93520#issuecomment-1149247624
gh-93526https://github.com/python/cpython/pull/93526
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 7, 2022https://github.com/python/cpython/pull/93520#event-6765245676
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 7, 2022 22:49https://github.com/python/cpython/pull/93520#event-6765245894
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93520
https://github.com/berkerpeksag
berkerpeksag https://github.com/berkerpeksag
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
needs backport to 3.10 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.10%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
SQLite rowcount is corrupted when combining UPDATE RETURNING w/ table that is dropped and recreated https://github.com/python/cpython/issues/93421
Please reload this pagehttps://github.com/python/cpython/pull/93520
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.