René's URL Explorer Experiment


Title: gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() by pSub · Pull Request #93463 · python/cpython · GitHub

Open Graph Title: gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() by pSub · Pull Request #93463 · python/cpython

X Title: gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() by pSub · Pull Request #93463 · python/cpython

Description: Cookies can store sensitive information and should therefore be protected against unauthorized third parties. This is also described in issue #79096. Note: This change is not effective on Microsoft Windows. The filesystem permissions are currently set to 644, everyone can read the file. This commit changes the permissions to 600, only the creater of the file can read and modify it. This improves security, because it reduces the attack surface. Now the attacker needs control of the user that created the cookie or a ways to circumvent the filesystems permissions. This change is backwards incompatible. Systems that rely on world-readable cookies will breake. However, one could argue that those are misconfigured in the first place.

Open Graph Description: Cookies can store sensitive information and should therefore be protected against unauthorized third parties. This is also described in issue #79096. Note: This change is not effective on Microsoft...

X Description: Cookies can store sensitive information and should therefore be protected against unauthorized third parties. This is also described in issue #79096. Note: This change is not effective on Microsoft...

Opengraph URL: https://github.com/python/cpython/pull/93463

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ac43a6d3-4c88-9f04-6987-7baad6643f0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9636:14EE64:5D9501:7DFCBA:6969B2DF
html-safe-nonce35ad4f9641faadb953b7253995eaafe669b3cd0509ac808f97fa979052a38e72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjM2OjE0RUU2NDo1RDk1MDE6N0RGQ0JBOjY5NjlCMkRGIiwidmlzaXRvcl9pZCI6IjgzNDQxODA2MTk1NDA1NDIxNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3011121289177e2636852837493a67911d93cd4f6d477408f152ebd0fdef6005
hovercard-subject-tagpull_request:957368425
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93463/files
twitter:imagehttps://avatars.githubusercontent.com/u/83842?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/83842?s=400&v=4
og:image:altCookies can store sensitive information and should therefore be protected against unauthorized third parties. This is also described in issue #79096. Note: This change is not effective on Microsoft...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93463/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93463%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93463%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93463/files
Reloadhttps://github.com/python/cpython/pull/93463/files
Reloadhttps://github.com/python/cpython/pull/93463/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93463/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93463/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
pSub:cookiejar-protect-cookie-filehttps://github.com/pSub/cpython/tree/cookiejar-protect-cookie-file
Conversation 5 https://github.com/python/cpython/pull/93463
Commits 2 https://github.com/python/cpython/pull/93463/commits
Checks 0 https://github.com/python/cpython/pull/93463/checks
Files changed https://github.com/python/cpython/pull/93463/files
Please reload this pagehttps://github.com/python/cpython/pull/93463/files
gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() https://github.com/python/cpython/pull/93463/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/93463/files
ce998c0 gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() pSub Jun 3, 2022 https://github.com/python/cpython/pull/93463/commits/ce998c010a1524030687e180377e36a997b33162
d590fad 📜🤖 Added by blurb_it. blurb-it[bot] Jun 3, 2022 https://github.com/python/cpython/pull/93463/commits/d590fadd384ee7116c9ed37497db385dbd084ed4
Clear filters https://github.com/python/cpython/pull/93463/files
Please reload this pagehttps://github.com/python/cpython/pull/93463/files
Please reload this pagehttps://github.com/python/cpython/pull/93463/files
cookiejar.py https://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
test_http_cookiejar.py https://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
2022-06-03-12-52-53.gh-issue-79096.YVoxgC.rst https://github.com/python/cpython/pull/93463/files#diff-debad358b8a9556d085944f6f1d1e86931127b1182e03af7bec1b34d9c010fc0
Lib/http/cookiejar.pyhttps://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
View file https://github.com/pSub/cpython/blob/d590fadd384ee7116c9ed37497db385dbd084ed4/Lib/http/cookiejar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93463/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
https://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
https://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
https://github.com/python/cpython/pull/93463/files#diff-1b1fdb83687ca45b995863d26cb590b5021e10db98c92b25d71ed67781c589ff
Lib/test/test_http_cookiejar.pyhttps://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
View file https://github.com/pSub/cpython/blob/d590fadd384ee7116c9ed37497db385dbd084ed4/Lib/test/test_http_cookiejar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93463/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
https://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
https://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
https://github.com/python/cpython/pull/93463/files#diff-35c529f88b8ac0c75eb7dd9d6488c3bb0793362344687ac6787d1cb3941763fd
Misc/NEWS.d/next/Security/2022-06-03-12-52-53.gh-issue-79096.YVoxgC.rsthttps://github.com/python/cpython/pull/93463/files#diff-debad358b8a9556d085944f6f1d1e86931127b1182e03af7bec1b34d9c010fc0
View file https://github.com/pSub/cpython/blob/d590fadd384ee7116c9ed37497db385dbd084ed4/Misc/NEWS.d/next/Security/2022-06-03-12-52-53.gh-issue-79096.YVoxgC.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93463/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.