| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:be45dc97-d0b2-c148-22a8-7e6349dbb6b3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A42:2B9199:16B82FE:1E94B50:6969A8FC |
| html-safe-nonce | ca292c484a552acf2167e747932cf16e12e7ad93f4a42bcdade72b76f096db1c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTQyOjJCOTE5OToxNkI4MkZFOjFFOTRCNTA6Njk2OUE4RkMiLCJ2aXNpdG9yX2lkIjoiMjY4ODc4ODUyMjc5NjE2NTM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 468de93eb560858a3d166ace28f91ada59898000b573c50fece3f7c90f9c0ace |
| hovercard-subject-tag | pull_request:957084891 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/93451/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6481aa7c9872069c62ff55389c2d56120354c583bc920882c79b6ee24cf9e77d/python/cpython/pull/93451 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6481aa7c9872069c62ff55389c2d56120354c583bc920882c79b6ee24cf9e77d/python/cpython/pull/93451 |
| og:image:alt | #60856
This moves the wording from #27971 to the front to reduce the duplicated wording
https://docs.python.org/3/library/socket.html#socket.getfqdn
https://github.com/python/cpython/blob/main/Lib/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | slateny |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/93451#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93451 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93451 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/93451 |
| Reload | https://github.com/python/cpython/pull/93451 |
| Reload | https://github.com/python/cpython/pull/93451 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/93451#issue-comment-box |
| slateny | https://github.com/slateny |
| python:main | https://github.com/python/cpython/tree/main |
| slateny:s/60856 | https://github.com/slateny/cpython/tree/s/60856 |
|
gh-60856: Be explicit about localhost for socket.getfqdn
| https://github.com/python/cpython/pull/93451#top |
| slateny | https://github.com/slateny |
| python:main | https://github.com/python/cpython/tree/main |
| slateny:s/60856 | https://github.com/slateny/cpython/tree/s/60856 |
|
Conversation
9
| https://github.com/python/cpython/pull/93451 |
|
Commits
5
| https://github.com/python/cpython/pull/93451/commits |
|
Checks
0
| https://github.com/python/cpython/pull/93451/checks |
|
Files changed
| https://github.com/python/cpython/pull/93451/files |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/slateny |
| slateny | https://github.com/slateny |
| Jun 3, 2022 | https://github.com/python/cpython/pull/93451#issue-1259481447 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| #60856 | https://github.com/python/cpython/issues/60856 |
| #27971 | https://github.com/python/cpython/pull/27971 |
| https://docs.python.org/3/library/socket.html#socket.getfqdn | https://docs.python.org/3/library/socket.html#socket.getfqdn |
| https://github.com/python/cpython/blob/main/Lib/socket.py#L792 | https://github.com/python/cpython/blob/main/Lib/socket.py#L792 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jun 3, 2022 | https://github.com/python/cpython/pull/93451#event-6733900916 |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Jun 3, 2022 | https://github.com/python/cpython/pull/93451#event-6733905296 |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
| June 3, 2022 06:25 | https://github.com/python/cpython/pull/93451#event-6733917548 |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
| Jun 3, 2022 | https://github.com/python/cpython/pull/93451#issuecomment-1145628900 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
| June 3, 2022 06:48 | https://github.com/python/cpython/pull/93451#event-6734033703 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| ambv | https://github.com/ambv |
| October 4, 2022 22:32 | https://github.com/python/cpython/pull/93451#event-7520477885 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
Feb 21, 2024
| https://github.com/python/cpython/pull/93451#pullrequestreview-1894083254 |
|
View reviewed changes
| https://github.com/python/cpython/pull/93451/files |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/93451/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 21, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1498044752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| slateny | https://github.com/slateny |
| Feb 27, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1503700219 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #100375 | https://github.com/python/cpython/pull/100375 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Feb 27, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1503957576 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| slateny | https://github.com/slateny |
| Mar 2, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1510014400 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 3, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1510208567 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| slateny | https://github.com/slateny |
| Mar 6, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1513702490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here's | https://cpython-previews--93451.org.readthedocs.build/en/93451/library/socket.html#socket.getfqdn |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| slateny | https://github.com/slateny |
| March 3, 2024 12:07 | https://github.com/python/cpython/pull/93451#commits-pushed-21a9280 |
|
| https://github.com/slateny |
| Be explicit about socket.getfqdn | https://github.com/python/cpython/pull/93451/commits/21a92803d1136623ee36cef36fa55d6decbae216 |
| 21a9280 | https://github.com/python/cpython/pull/93451/commits/21a92803d1136623ee36cef36fa55d6decbae216 |
|
| https://github.com/slateny |
| Move description from last sentence to top | https://github.com/python/cpython/pull/93451/commits/dd58cfecae8d09e9996720d8339d1263324359f4 |
| dd58cfe | https://github.com/python/cpython/pull/93451/commits/dd58cfecae8d09e9996720d8339d1263324359f4 |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
| force-pushed | https://github.com/python/cpython/compare/7c0cd32b41f1fcff871a774e856783ee04d53bc6..dd58cfecae8d09e9996720d8339d1263324359f4 |
| 7c0cd32 | https://github.com/python/cpython/commit/7c0cd32b41f1fcff871a774e856783ee04d53bc6 |
| dd58cfe | https://github.com/python/cpython/commit/dd58cfecae8d09e9996720d8339d1263324359f4 |
|
Compare
| https://github.com/python/cpython/compare/7c0cd32b41f1fcff871a774e856783ee04d53bc6..dd58cfecae8d09e9996720d8339d1263324359f4 |
| March 3, 2024 20:07 | https://github.com/python/cpython/pull/93451#event-11991022898 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Mar 3, 2024
| https://github.com/python/cpython/pull/93451#ref-issue-1198891658 |
|
[doc] socket.getfqdn docs are not explicit enough about the algorithm.
#60856
| https://github.com/python/cpython/issues/60856 |
|
| https://github.com/slateny |
| Corrected getfqdn ordering and phrasing; small grammar fix | https://github.com/python/cpython/pull/93451/commits/9dcdc90c1336e00cafc10065a50c305faf3f660c |
| 9dcdc90 | https://github.com/python/cpython/pull/93451/commits/9dcdc90c1336e00cafc10065a50c305faf3f660c |
| https://github.com/slateny |
| slateny | https://github.com/slateny |
|
Mar 3, 2024
| https://github.com/python/cpython/pull/93451#pullrequestreview-1913107943 |
|
View reviewed changes
| https://github.com/python/cpython/pull/93451/files/9dcdc90c1336e00cafc10065a50c305faf3f660c |
| Doc/library/socket.rst | https://github.com/python/cpython/pull/93451/files/9dcdc90c1336e00cafc10065a50c305faf3f660c#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943 |
| slateny | https://github.com/slateny |
| Mar 3, 2024 | https://github.com/python/cpython/pull/93451#discussion_r1510385744 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this | https://docs.python.org/dev/library/socket.html#socket.create_server |
| https://private-user-images.githubusercontent.com/46876382/309578404-5091d568-6ac1-47a5-ac5b-7c8befaeb67b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzI1MjEsIm5iZiI6MTc2ODUzMjIyMSwicGF0aCI6Ii80Njg3NjM4Mi8zMDk1Nzg0MDQtNTA5MWQ1NjgtNmFjMS00N2E1LWFjNWItN2M4YmVmYWViNjdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE2VDAyNTcwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0MjUzMGZmODRiZGQxYjk4ZTJiZDYyYWM2MDZiZTE2NmI2MjM3ODc3MmY3MDQ1YTI4ZmI2MWFlM2UyYzM4ODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KXeYEgpl_s-fOCOWg4EsA8bFJRX2FddMUupjvHfZ2mw |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| slateny | https://github.com/slateny |
| March 3, 2024 12:20 | https://github.com/python/cpython/pull/93451#commits-pushed-6bb37ce |
|
| https://github.com/slateny |
| Change to single quotes and add ` | https://github.com/python/cpython/pull/93451/commits/6bb37ce7f76f30172db672024a4ee8d319aa29ea |
| 6bb37ce | https://github.com/python/cpython/pull/93451/commits/6bb37ce7f76f30172db672024a4ee8d319aa29ea |
|
| https://github.com/slateny |
| empty -> omitted | https://github.com/python/cpython/pull/93451/commits/025536e1e387307d9bd7532993a12697a4058c20 |
| 025536e | https://github.com/python/cpython/pull/93451/commits/025536e1e387307d9bd7532993a12697a4058c20 |
| https://github.com/apps/python-cla-bot |
| python-cla-bot | https://github.com/apps/python-cla-bot |
| Apr 18, 2025 | https://github.com/python/cpython/pull/93451#issuecomment-2815095410 |
| https://cla.python.org/ |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93451 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/93451/files/7c0cd32b41f1fcff871a774e856783ee04d53bc6 |
|
| https://github.com/ambv |
|
ambv
| https://github.com/ambv |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
|
docs
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Adocs |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
Docs PRs
| https://github.com/orgs/python/projects/50 |
| Please reload this page | https://github.com/python/cpython/pull/93451 |
|
| https://github.com/slateny |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |