René's URL Explorer Experiment


Title: gh-93357: Lay the foundation for further work in `asyncio.test_streams`: port server cases to IsolatedAsyncioTestCase by arhadthedev · Pull Request #93369 · python/cpython · GitHub

Open Graph Title: gh-93357: Lay the foundation for further work in `asyncio.test_streams`: port server cases to IsolatedAsyncioTestCase by arhadthedev · Pull Request #93369 · python/cpython

X Title: gh-93357: Lay the foundation for further work in `asyncio.test_streams`: port server cases to IsolatedAsyncioTestCase by arhadthedev · Pull Request #93369 · python/cpython

Description: This PR removes ad-hoc implementation of async tests by using all relatively new features of standard IsolatedAsyncIoTestCase. Edit: this PR also removes messages variable used to pass exceptions between a main and a server threads. That's because the server is now async, lives in a main thread, and needs no intermediary to pass exceptions into a test harness. To make changes possible to review, this PR changes a limited set of tests only. Further commits will expand the change further up and down. For this, a single test class is temporarily split into three parts; two of them (StreamTests and StreamTests2) isolate old cases below and above the upgraded ones, and one (NewStreamTests) are the updated ones themselves. The reason is because subclassing from both old test_utils.TestCase and new unittest.IsolatedAsyncioTestCase leads to conflicts aborting each test with RuntimeError: cannot enter context: <...> is already entered. Issue: gh-93357

Open Graph Description: This PR removes ad-hoc implementation of async tests by using all relatively new features of standard IsolatedAsyncIoTestCase. Edit: this PR also removes messages variable used to pass exceptions b...

X Description: This PR removes ad-hoc implementation of async tests by using all relatively new features of standard IsolatedAsyncIoTestCase. Edit: this PR also removes messages variable used to pass exceptions b...

Opengraph URL: https://github.com/python/cpython/pull/93369

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cf669e30-8cc9-d060-9c31-d93099e3ec05
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB854:2FF27D:5AC7A9:79DE76:6969B3D9
html-safe-nonce58598c5e6a5c5d3e6b89a23e7f82ede1a2df722dc4d9164f2c10ca65d03f3dd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODU0OjJGRjI3RDo1QUM3QTk6NzlERTc2OjY5NjlCM0Q5IiwidmlzaXRvcl9pZCI6IjIxMjQwMDkwNzIyMjA1NTAxMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9a11262c963dd463cd0c0787264f55a44e24cbf6dadc4cf4ba0703490032e205
hovercard-subject-tagpull_request:951580565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93369/files
twitter:imagehttps://avatars.githubusercontent.com/u/4881073?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4881073?s=400&v=4
og:image:altThis PR removes ad-hoc implementation of async tests by using all relatively new features of standard IsolatedAsyncIoTestCase. Edit: this PR also removes messages variable used to pass exceptions b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93369/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93369%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93369%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93369/files
Reloadhttps://github.com/python/cpython/pull/93369/files
Reloadhttps://github.com/python/cpython/pull/93369/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
arhadthedev:teststreams-utilsTestCase-servershttps://github.com/arhadthedev/cpython/tree/teststreams-utilsTestCase-servers
Conversation 19 https://github.com/python/cpython/pull/93369
Commits 11 https://github.com/python/cpython/pull/93369/commits
Checks 0 https://github.com/python/cpython/pull/93369/checks
Files changed https://github.com/python/cpython/pull/93369/files
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
gh-93357: Lay the foundation for further work in asyncio.test_streams: port server cases to IsolatedAsyncioTestCase https://github.com/python/cpython/pull/93369/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/93369/files
a052bf7 Port server cases to IsolatedAsyncioTestCase arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/a052bf7f4dc2bce34753f3335fa154d9c109ac06
1f8977b Add forgotten setUp and tearDown into StreamTests2 arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/1f8977b0c223167031a845c3c225a53c64433183
3205970 Use subtests to localize errors arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/3205970760b83a4e7ea7eb1f7ca52d75fab6055f
9f32482 Fix a wrongly used address arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/9f32482796c85955c2e074e7ea205d22505b3b4d
e41c7ca Fix another typo arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/e41c7ca738e4428681fc4d08b9b11b6c28d5cdbc
35e4f26 Remove manual server starting arhadthedev May 31, 2022 https://github.com/python/cpython/pull/93369/commits/35e4f269177aea4ecd692ef79816a900baa3893f
92e30e5 Address a review of Serhiy Storchaka arhadthedev Jun 1, 2022 https://github.com/python/cpython/pull/93369/commits/92e30e52506567b141d5bbe1efc7355908a3579a
e706f2c Merge branch 'main' into teststreams-utilsTestCase-servers arhadthedev Jul 11, 2022 https://github.com/python/cpython/pull/93369/commits/e706f2c7bdec103b1c0882f44141dd8ac90919b5
690e451 Merge branch 'main' into teststreams-utilsTestCase-servers arhadthedev Aug 1, 2022 https://github.com/python/cpython/pull/93369/commits/690e451031dd56d6f7f4971891cb3c04c0824b25
cabc398 Merge branch 'main' into teststreams-utilsTestCase-servers gvanrossum Sep 27, 2022 https://github.com/python/cpython/pull/93369/commits/cabc3986eb1aac7e9e8ab74d65519874dd1db457
dcc10dd Remove a What's New entry as proposed by Nikita Sobolev arhadthedev Oct 2, 2022 https://github.com/python/cpython/pull/93369/commits/dcc10ddf47c13e8e2700e7ba776e5764f3b05c9f
Clear filters https://github.com/python/cpython/pull/93369/files
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L370
Lib/test/test_asyncio/test_streams.pyhttps://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
View file https://github.com/arhadthedev/cpython/blob/dcc10ddf47c13e8e2700e7ba776e5764f3b05c9f/Lib/test/test_asyncio/test_streams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93369/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
sobolevnhttps://github.com/sobolevn
Sep 25, 2022https://github.com/python/cpython/pull/93369/files#r979425322
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
arhadthedevhttps://github.com/arhadthedev
Oct 2, 2022https://github.com/python/cpython/pull/93369/files#r985274159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
arhadthedevhttps://github.com/arhadthedev
Oct 2, 2022https://github.com/python/cpython/pull/93369/files#r985274945
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/93369/files
https://github.com/python/cpython/pull/93369/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.