| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0752b4b0-666d-9f23-eeb7-9cbb4147d3c1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B3A:22A978:137A362:1B4DC40:696A3439 |
| html-safe-nonce | 09e954e2e1eb9db629ea930e4de5e0be482ff881efa941436c6da0107fcc0488 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjNBOjIyQTk3ODoxMzdBMzYyOjFCNERDNDA6Njk2QTM0MzkiLCJ2aXNpdG9yX2lkIjoiODcyODM3NDEwMjgyMTg0NDAyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d3c38e9022bebd2cb4dfa2e6b7c2197bc4a004fe7ecd152d4608a2b64c69039f |
| hovercard-subject-tag | pull_request:947930916 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/93246/files |
| twitter:image | https://avatars.githubusercontent.com/u/4881073?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4881073?s=400&v=4 |
| og:image:alt | gh-93243
This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smt... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/93246/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93246%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93246%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/93246/files |
| Reload | https://github.com/python/cpython/pull/93246/files |
| Reload | https://github.com/python/cpython/pull/93246/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| miss-islington | https://github.com/miss-islington |
| python:main | https://github.com/python/cpython/tree/main |
| arhadthedev:privatize-smtpd | https://github.com/arhadthedev/cpython/tree/privatize-smtpd |
|
Conversation
27
| https://github.com/python/cpython/pull/93246 |
|
Commits
19
| https://github.com/python/cpython/pull/93246/commits |
|
Checks
0
| https://github.com/python/cpython/pull/93246/checks |
|
Files changed
| https://github.com/python/cpython/pull/93246/files |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
gh-93243: Make smtpd private before porting its users
| https://github.com/python/cpython/pull/93246/files#top |
|
Show all changes
19 commits
| https://github.com/python/cpython/pull/93246/files |
|
021e85c
gh-93243: Make smtpd private to port its users
arhadthedev May 26, 2022
| https://github.com/python/cpython/pull/93246/commits/021e85ce0308f57c6a242bf3e036a877d4826c2f |
|
ed21b2b
Merge branch 'main' into privatize-smtpd
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/ed21b2b9a333e0f7061bdd9a39a6d8b38dcd7545 |
|
18a5615
Move smtpd to its only user for further porting to asyncio
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/18a5615de5b0dd3bc037336ed085c21df1ca3656 |
|
6f2c565
Point test_logging to the new smtpd location too
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/6f2c565ff30413b8f2995d3c629e308d57f99854 |
|
f5aee16
Remove smptd from standalone module lists
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/f5aee16d9eccdc07b6b65042b00af1353e66eacc |
|
c7cb1e3
Update Doc/whatsnew/3.12.rst
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/c7cb1e3a71e5beb076db66049e28b43435cee919 |
|
8180429
Update Doc/whatsnew/3.12.rst
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/8180429e78b9c86a43a664a7fc3c22e5369171a7 |
|
b70bf5a
Address the review of AA-Turner (using suggestion batching)
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/b70bf5af16f0a4158fdb003d2af8f6a2d8a7a4ea |
|
4054ac2
Remove non-working :mod:
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/4054ac280ea4ac9e262db435a01779664c5060d9 |
|
eb6ad56
Update Doc/whatsnew/3.12.rst
arhadthedev Jun 4, 2022
| https://github.com/python/cpython/pull/93246/commits/eb6ad56d2d2706b1ef9a4b172c784fc93c341efb |
|
133735a
Address @brettcannon's review
arhadthedev Jun 8, 2022
| https://github.com/python/cpython/pull/93246/commits/133735a71e26885c05c32a44c0fd94de1171684e |
|
38fd57b
Merge branch 'main' into privatize-smtpd
arhadthedev Jun 23, 2022
| https://github.com/python/cpython/pull/93246/commits/38fd57b73de2542589460fb55df970bfa306cdb3 |
|
1f839b9
Merge branch 'main' into privatize-smtpd
arhadthedev Jun 24, 2022
| https://github.com/python/cpython/pull/93246/commits/1f839b95d204c394da678f31cd5368cde0d4a8bf |
|
d8f4b0c
Merge remote-tracking branch 'gold/main' into privatize-smtpd
arhadthedev Jul 5, 2022
| https://github.com/python/cpython/pull/93246/commits/d8f4b0cb148b84344b0319c9f669e17597373a8b |
|
0bc83a6
Merge branch 'main' into privatize-smtpd
arhadthedev Jul 23, 2022
| https://github.com/python/cpython/pull/93246/commits/0bc83a691b46ec1b4032db7affbad99a9e93e735 |
|
7423617
Merge branch 'main' into privatize-smtpd
arhadthedev Aug 4, 2022
| https://github.com/python/cpython/pull/93246/commits/7423617444538c4fb2623c6529fa037fbfce828a |
|
815cb7c
Address the Barry's review
arhadthedev Aug 4, 2022
| https://github.com/python/cpython/pull/93246/commits/815cb7cf347da9a40d518dc7ec2c2e9b399f317e |
|
e351af3
Update 3.12.rst
warsaw Aug 4, 2022
| https://github.com/python/cpython/pull/93246/commits/e351af3d45022fa0706191bc89832daa035f089d |
|
1d157ec
Update 3.12.rst
warsaw Aug 6, 2022
| https://github.com/python/cpython/pull/93246/commits/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5 |
|
Clear filters
| https://github.com/python/cpython/pull/93246/files |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
email.rst
| https://github.com/python/cpython/pull/93246/files#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 |
|
smtpd.rst
| https://github.com/python/cpython/pull/93246/files#diff-cbe787c23a8dcfb1dd9ac834cb593d04e0ee6fc6cf24c4d2f11b621273d5a726 |
|
superseded.rst
| https://github.com/python/cpython/pull/93246/files#diff-507fd5e6fcbc78f19e7ca738c81e9a5efca6f244b999263f83e10524c45759e4 |
|
3.12.rst
| https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
mock_socket.py
| https://github.com/python/cpython/pull/93246/files#diff-d7622455cfe9dda81cc48eccc4461641ae6f4efcf427f0fec1ce40c042afaa7a |
|
smtpd.py
| https://github.com/python/cpython/pull/93246/files#diff-94d8958ba4945b8b7ac742cf9161b0636cbd490f70a12a4cb3787438d69b37ae |
|
test_logging.py
| https://github.com/python/cpython/pull/93246/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
|
test_smtpd.py
| https://github.com/python/cpython/pull/93246/files#diff-1468e30dd719d78a8600d12ef60119f4649a9de32bf7ff42841dcd55df3f5c71 |
|
test_smtplib.py
| https://github.com/python/cpython/pull/93246/files#diff-05df76ac06a6e6dc7fd865579a9d02fab97ee2fc6dbfc8cf58fdb94396b9de28 |
|
2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst
| https://github.com/python/cpython/pull/93246/files#diff-e99a5bc248a86f8c899886cd02afc03c0d1eaa710cd28d7b2b37d922012a43ed |
|
lib.pyproj
| https://github.com/python/cpython/pull/93246/files#diff-8b264d5a3d562fe10f3e28a59a223e1e74938149b065b666603bd05fddb1250b |
|
stdlib_module_names.h
| https://github.com/python/cpython/pull/93246/files#diff-152e0a1d932d06bae2302482de6c49082b62169699729700d445d4f588504af5 |
|
wasm_assets.py
| https://github.com/python/cpython/pull/93246/files#diff-ac800b9666dc88c804f6ab5bbe7224657b2a1048a3130629a0be3ce566b9514c |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L439 |
| Doc/library/email.rst | https://github.com/python/cpython/pull/93246/files#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Doc/library/email.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L440 |
| Doc/library/smtpd.rst | https://github.com/python/cpython/pull/93246/files#diff-cbe787c23a8dcfb1dd9ac834cb593d04e0ee6fc6cf24c4d2f11b621273d5a726 |
|
View file
| https://github.com/python/cpython/blob/7b370b73055d757ed09c7942f4631256b27fdcb6/Doc/library/smtpd.rst |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
| Doc/library/superseded.rst | https://github.com/python/cpython/pull/93246/files#diff-507fd5e6fcbc78f19e7ca738c81e9a5efca6f244b999263f83e10524c45759e4 |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Doc/library/superseded.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-507fd5e6fcbc78f19e7ca738c81e9a5efca6f244b999263f83e10524c45759e4 |
|
| https://github.com/python/cpython/pull/93246/files#diff-507fd5e6fcbc78f19e7ca738c81e9a5efca6f244b999263f83e10524c45759e4 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L114 |
| Doc/whatsnew/3.12.rst | https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Doc/whatsnew/3.12.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
| https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
| https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
|
| https://github.com/python/cpython/pull/93246/files#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b |
| Lib/test/mock_socket.py | https://github.com/python/cpython/pull/93246/files#diff-d7622455cfe9dda81cc48eccc4461641ae6f4efcf427f0fec1ce40c042afaa7a |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Lib/test/mock_socket.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-d7622455cfe9dda81cc48eccc4461641ae6f4efcf427f0fec1ce40c042afaa7a |
|
| https://github.com/python/cpython/pull/93246/files#diff-d7622455cfe9dda81cc48eccc4461641ae6f4efcf427f0fec1ce40c042afaa7a |
|
| https://github.com/python/cpython/pull/93246/files#diff-d7622455cfe9dda81cc48eccc4461641ae6f4efcf427f0fec1ce40c042afaa7a |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L440 |
| Lib/smtpd.py → Lib/test/smtpd.py | https://github.com/python/cpython/pull/93246/files#diff-94d8958ba4945b8b7ac742cf9161b0636cbd490f70a12a4cb3787438d69b37ae |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Lib/test/smtpd.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-94d8958ba4945b8b7ac742cf9161b0636cbd490f70a12a4cb3787438d69b37ae |
|
| https://github.com/python/cpython/pull/93246/files#diff-94d8958ba4945b8b7ac742cf9161b0636cbd490f70a12a4cb3787438d69b37ae |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L515 |
| Lib/test/test_logging.py | https://github.com/python/cpython/pull/93246/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
|
View file
| https://github.com/arhadthedev/cpython/blob/1d157ec3a5c8e3ecc685f254fcfffa4a36c479a5/Lib/test/test_logging.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93246/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93246/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
| https://github.com/python/cpython/pull/93246/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
| Please reload this page | https://github.com/python/cpython/pull/93246/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |