Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython · GitHub
Open Graph Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython
X Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython
Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ====================================================================== FAIL: testDefaultOptimizationLevel (test.test_zipimport.CompressedZipImportTestCase.testDefaultOptimizationLevel) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/.../dev/cpython/Lib/test/test_zipimport.py", line 657, in testDefaultOptimizationLevel self.assertRaises(AssertionError, mod.test, False) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: AssertionError not raised by test ====================================================================== FAIL: testDefaultOptimizationLevel (test.test_zipimport.UncompressedZipImportTestCase.testDefaultOptimizationLevel) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/.../dev/cpython/Lib/test/test_zipimport.py", line 657, in testDefaultOptimizationLevel self.assertRaises(AssertionError, mod.test, False) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: AssertionError not raised by test ---------------------------------------------------------------------- Ran 73 tests in 0.073s FAILED (failures=2, skipped=2) After: ./python.exe -Om unittest test.test_zipimport ....................................s................................s... ---------------------------------------------------------------------- Ran 73 tests in 0.065s OK (skipped=2)
Open Graph Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================...
X Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================...
Opengraph URL: https://github.com/python/cpython/pull/93236
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:639ce67a-83b8-f973-8d59-eca4e5ddd735 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE96:34CBCC:8D3493:BF9CCF:6969E60A |
| html-safe-nonce | 6bbd21797a58c15fa1bff5fd0f452ba0c575bbef988e427e6d72834455122215 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTk2OjM0Q0JDQzo4RDM0OTM6QkY5Q0NGOjY5NjlFNjBBIiwidmlzaXRvcl9pZCI6Ijg2MTQwNzYxMDY3MjMxNTc1MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f80fe4b318629119a3e7b76883226376a71631d3e2f1009b4aab4e0b6074b9f4 |
| hovercard-subject-tag | pull_request:947649812 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/93236/files |
| twitter:image | https://avatars.githubusercontent.com/u/1750152?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1750152?s=400&v=4 |
| og:image:alt | #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width