Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython · GitHub
Open Graph Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython
X Title: gh-92886: Fixing tests that fail when running with optimizations (`-O`) in `test_zipimport.py` by jackh-ncl · Pull Request #93236 · python/cpython
Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ====================================================================== FAIL: testDefaultOptimizationLevel (test.test_zipimport.CompressedZipImportTestCase.testDefaultOptimizationLevel) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/.../dev/cpython/Lib/test/test_zipimport.py", line 657, in testDefaultOptimizationLevel self.assertRaises(AssertionError, mod.test, False) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: AssertionError not raised by test ====================================================================== FAIL: testDefaultOptimizationLevel (test.test_zipimport.UncompressedZipImportTestCase.testDefaultOptimizationLevel) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/.../dev/cpython/Lib/test/test_zipimport.py", line 657, in testDefaultOptimizationLevel self.assertRaises(AssertionError, mod.test, False) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: AssertionError not raised by test ---------------------------------------------------------------------- Ran 73 tests in 0.073s FAILED (failures=2, skipped=2) After: ./python.exe -Om unittest test.test_zipimport ....................................s................................s... ---------------------------------------------------------------------- Ran 73 tests in 0.065s OK (skipped=2)
Open Graph Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================...
X Description: #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================...
Opengraph URL: https://github.com/python/cpython/pull/93236
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:31cea7e2-e5e1-2a39-234c-1b7b7c2c4e0d |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | E542:268A14:560FA:73BBF:6969CC6A |
| html-safe-nonce | f23e16acd6eda1d6c63f41a2f6f008e0ad7d482c62ce588120485a98df346724 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTQyOjI2OEExNDo1NjBGQTo3M0JCRjo2OTY5Q0M2QSIsInZpc2l0b3JfaWQiOiIxNjkyMDAwNzgzMTg0ODA5MDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8fa54d7407629439ef5e99061121943fa985e6aae71710420c0ad62d37f4c382 |
| hovercard-subject-tag | pull_request:947649812 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/93236/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1750152?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1750152?s=400&v=4 |
| og:image:alt | #92886 Before: $ ./python.exe -Om unittest test.test_zipimport ................F...................s............F...................s... ==========================================================... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83c08c21cdda978090dc44364b71aa5bc6dcea79 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width