René's URL Explorer Experiment


Title: gh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) by jackh-ncl · Pull Request #93231 · python/cpython · GitHub

Open Graph Title: gh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) by jackh-ncl · Pull Request #93231 · python/cpython

X Title: gh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) by jackh-ncl · Pull Request #93231 · python/cpython

Description: Replace assert statements with raise AssertionError() so that behaviour is maintained and test_wsgiref.py tests pass while running with optimizations (-O). #92886 Before: $ ./python.exe -Om unittes...

Open Graph Description: Replace assert statements with raise AssertionError() so that behaviour is maintained and test_wsgiref.py tests pass while running with optimizations (-O). #92886 Before: $ ./python.exe -Om unittes...

X Description: Replace assert statements with raise AssertionError() so that behaviour is maintained and test_wsgiref.py tests pass while running with optimizations (-O). #92886 Before: $ ./python.exe -Om unittes...

Opengraph URL: https://github.com/python/cpython/pull/93231

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7c6c293-af2a-6110-d998-450fb4675c85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD652:CADE5:22557E:2DED1F:6969781A
html-safe-noncea28640c4c861408da40a7ca0d8fc6927ae5c376fb71d9101799c688966b7a953
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjUyOkNBREU1OjIyNTU3RToyREVEMUY6Njk2OTc4MUEiLCJ2aXNpdG9yX2lkIjoiNzE0MjU1OTk3MTExNzk4Nzg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdb166dc4014d736e7f61216377378fe41f2efdda928aec3a1897981c3b1a592a
hovercard-subject-tagpull_request:947595153
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/93231/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/43e7fb015c6aa7e817f0c55e761e3de4fdc11c5613c0a01c92941796cf0e225c/python/cpython/pull/93231
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43e7fb015c6aa7e817f0c55e761e3de4fdc11c5613c0a01c92941796cf0e225c/python/cpython/pull/93231
og:image:altReplace assert statements with raise AssertionError() so that behaviour is maintained and test_wsgiref.py tests pass while running with optimizations (-O). #92886 Before: $ ./python.exe -Om unittes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejackh-ncl
hostnamegithub.com
expected-hostnamegithub.com
Nonec6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release212e3e3d3298bf5b313830edfd2399e869f7ea76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93231#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93231
Reloadhttps://github.com/python/cpython/pull/93231
Reloadhttps://github.com/python/cpython/pull/93231
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93231
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93231
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/93231#issue-comment-box
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
jackh-ncl:92886-wsgirefhttps://github.com/jackh-ncl/cpython/tree/92886-wsgiref
gh-92886: Replace assertion statements in handlers.BaseHandler to support running with optimizations (-O) https://github.com/python/cpython/pull/93231#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
jackh-ncl:92886-wsgirefhttps://github.com/jackh-ncl/cpython/tree/92886-wsgiref
Conversation 2 https://github.com/python/cpython/pull/93231
Commits 6 https://github.com/python/cpython/pull/93231/commits
Checks 0 https://github.com/python/cpython/pull/93231/checks
Files changed https://github.com/python/cpython/pull/93231/files
Please reload this pagehttps://github.com/python/cpython/pull/93231
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/jackh-ncl
jackh-nclhttps://github.com/jackh-ncl
May 25, 2022https://github.com/python/cpython/pull/93231#issue-1248788302
Please reload this pagehttps://github.com/python/cpython/pull/93231
#92886https://github.com/python/cpython/issues/92886
some tests fail with -O (assertions off) #92886https://github.com/python/cpython/issues/92886
Please reload this pagehttps://github.com/python/cpython/pull/93231
Replace status assertion statements in handlers.pyhttps://github.com/python/cpython/pull/93231/commits/1e8e482dfb690b20fbc57be28c2b7b6cd1e58f32
1e8e482https://github.com/python/cpython/pull/93231/commits/1e8e482dfb690b20fbc57be28c2b7b6cd1e58f32
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 25, 2022https://github.com/python/cpython/pull/93231#issuecomment-1137887921
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/93231
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 25, 2022https://github.com/python/cpython/pull/93231#event-6681407130
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/93231/commits/994ca363e05b10235266a30dd1ac0a333a2978c7
994ca36https://github.com/python/cpython/pull/93231/commits/994ca363e05b10235266a30dd1ac0a333a2978c7
https://github.com/jackh-ncl
jackh-nclhttps://github.com/jackh-ncl
May 25, 2022 22:10https://github.com/python/cpython/pull/93231#event-6681439187
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Oct 18, 2022 https://github.com/python/cpython/pull/93231#pullrequestreview-1146126581
View reviewed changes https://github.com/python/cpython/pull/93231/files/994ca363e05b10235266a30dd1ac0a333a2978c7
Misc/NEWS.d/next/Library/2022-05-25-22-09-38.gh-issue-92886.ylwDSc.rsthttps://github.com/python/cpython/pull/93231/files/994ca363e05b10235266a30dd1ac0a333a2978c7#diff-7b6a93d114a6cd22008e53fb2800c360d70d5d8742d4bbf68ecc86851c2321be
Please reload this pagehttps://github.com/python/cpython/pull/93231
jackh-nclhttps://github.com/jackh-ncl
October 18, 2022 17:08https://github.com/python/cpython/pull/93231#commits-pushed-539de23
https://github.com/jackh-ncl
https://github.com/iritkatriel
Update Misc/NEWS.d/next/Library/2022-05-25-22-09-38.gh-issue-92886.yl…https://github.com/python/cpython/pull/93231/commits/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8
539de23https://github.com/python/cpython/pull/93231/commits/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8
https://github.com/iritkatriel
Merge branch 'main' into 92886-wsgirefhttps://github.com/python/cpython/pull/93231/commits/e38fe392a829883e5b98c698fc5c263749812062
e38fe39https://github.com/python/cpython/pull/93231/commits/e38fe392a829883e5b98c698fc5c263749812062
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Oct 18, 2022 https://github.com/python/cpython/pull/93231#pullrequestreview-1146130017
View reviewed changes https://github.com/python/cpython/pull/93231/files/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 18, 2022https://github.com/python/cpython/pull/93231#event-7613311657
iritkatrielhttps://github.com/iritkatriel
October 19, 2022 11:06https://github.com/python/cpython/pull/93231#commits-pushed-6278625
https://github.com/iritkatriel
Merge branch 'main' into 92886-wsgirefhttps://github.com/python/cpython/pull/93231/commits/6278625a61e09d515be70a3c670be470425c3c47
6278625https://github.com/python/cpython/pull/93231/commits/6278625a61e09d515be70a3c670be470425c3c47
https://github.com/iritkatriel
Merge branch 'main' into 92886-wsgirefhttps://github.com/python/cpython/pull/93231/commits/c0ea1b44b817355fc4cbd8ff2758c43a254dbeb5
c0ea1b4https://github.com/python/cpython/pull/93231/commits/c0ea1b44b817355fc4cbd8ff2758c43a254dbeb5
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
b6e59d7https://github.com/python/cpython/commit/b6e59d76c0e1214ca2c927be35f165ecd1f763df
Oct 19, 2022https://github.com/python/cpython/pull/93231#event-7620204875
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 19, 2022https://github.com/python/cpython/pull/93231#event-7620205251
carljmhttps://github.com/carljm
Oct 20, 2022 https://github.com/python/cpython/pull/93231#ref-commit-8bba5da
https://github.com/carljm
Merge branch 'main' into typewatchhttps://github.com/carljm/cpython/commit/8bba5da3257ff3464b4d5e5913ebe3ac86644fd8
8bba5dahttps://github.com/carljm/cpython/commit/8bba5da3257ff3464b4d5e5913ebe3ac86644fd8
pythongh-98461https://github.com/python/cpython/issues/98461
pythonGH-98464https://github.com/python/cpython/pull/98464
pythongh-98421https://github.com/python/cpython/issues/98421
pythonGH-98422https://github.com/python/cpython/pull/98422
pythongh-98360https://github.com/python/cpython/issues/98360
pythonGH-98462https://github.com/python/cpython/pull/98462
python#98480https://github.com/python/cpython/pull/98480
pythonGH-98481https://github.com/python/cpython/pull/98481
pythonGH-98475https://github.com/python/cpython/pull/98475
pythongh-95023https://github.com/python/cpython/issues/95023
python#95046https://github.com/python/cpython/pull/95046
pythonGH-98363https://github.com/python/cpython/issues/98363
pythonGH-98419https://github.com/python/cpython/pull/98419
pythongh-98374https://github.com/python/cpython/issues/98374
pythongh-98450https://github.com/python/cpython/pull/98450
python#98351https://github.com/python/cpython/pull/98351
pythongh-98354https://github.com/python/cpython/issues/98354
pythonGH-98412https://github.com/python/cpython/pull/98412
pythongh-98257https://github.com/python/cpython/issues/98257
python#98258https://github.com/python/cpython/pull/98258
pythongh-98414https://github.com/python/cpython/issues/98414
pythonGH-98460https://github.com/python/cpython/pull/98460
pythongh-98417https://github.com/python/cpython/issues/98417
pythonGH-98418https://github.com/python/cpython/pull/98418
python#98409https://github.com/python/cpython/pull/98409
pythonGH-98350https://github.com/python/cpython/pull/98350
python#98441https://github.com/python/cpython/pull/98441
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-93231https://github.com/python/cpython/pull/93231
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-93233https://github.com/python/cpython/pull/93233
pythongh-92886https://github.com/python/cpython/issues/92886
pythonGH-93235https://github.com/python/cpython/pull/93235
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/93231/files/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8
Please reload this pagehttps://github.com/python/cpython/pull/93231
https://github.com/jackh-ncl
https://github.com/bedevere-bot
https://github.com/iritkatriel
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.