| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d7c6c293-af2a-6110-d998-450fb4675c85 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D652:CADE5:22557E:2DED1F:6969781A |
| html-safe-nonce | a28640c4c861408da40a7ca0d8fc6927ae5c376fb71d9101799c688966b7a953 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjUyOkNBREU1OjIyNTU3RToyREVEMUY6Njk2OTc4MUEiLCJ2aXNpdG9yX2lkIjoiNzE0MjU1OTk3MTExNzk4Nzg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | db166dc4014d736e7f61216377378fe41f2efdda928aec3a1897981c3b1a592a |
| hovercard-subject-tag | pull_request:947595153 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/93231/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43e7fb015c6aa7e817f0c55e761e3de4fdc11c5613c0a01c92941796cf0e225c/python/cpython/pull/93231 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43e7fb015c6aa7e817f0c55e761e3de4fdc11c5613c0a01c92941796cf0e225c/python/cpython/pull/93231 |
| og:image:alt | Replace assert statements with raise AssertionError() so that behaviour is maintained and test_wsgiref.py tests pass while running with optimizations (-O).
#92886
Before:
$ ./python.exe -Om unittes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jackh-ncl |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 212e3e3d3298bf5b313830edfd2399e869f7ea76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/93231#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/93231 |
| Reload | https://github.com/python/cpython/pull/93231 |
| Reload | https://github.com/python/cpython/pull/93231 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/93231#issue-comment-box |
| iritkatriel | https://github.com/iritkatriel |
| python:main | https://github.com/python/cpython/tree/main |
| jackh-ncl:92886-wsgiref | https://github.com/jackh-ncl/cpython/tree/92886-wsgiref |
|
gh-92886: Replace assertion statements in handlers.BaseHandler to support running with optimizations (-O)
| https://github.com/python/cpython/pull/93231#top |
| iritkatriel | https://github.com/iritkatriel |
| python:main | https://github.com/python/cpython/tree/main |
| jackh-ncl:92886-wsgiref | https://github.com/jackh-ncl/cpython/tree/92886-wsgiref |
|
Conversation
2
| https://github.com/python/cpython/pull/93231 |
|
Commits
6
| https://github.com/python/cpython/pull/93231/commits |
|
Checks
0
| https://github.com/python/cpython/pull/93231/checks |
|
Files changed
| https://github.com/python/cpython/pull/93231/files |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/jackh-ncl |
| jackh-ncl | https://github.com/jackh-ncl |
| May 25, 2022 | https://github.com/python/cpython/pull/93231#issue-1248788302 |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
| #92886 | https://github.com/python/cpython/issues/92886 |
| some tests fail with -O (assertions off) #92886 | https://github.com/python/cpython/issues/92886 |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
| Replace status assertion statements in handlers.py | https://github.com/python/cpython/pull/93231/commits/1e8e482dfb690b20fbc57be28c2b7b6cd1e58f32 |
| 1e8e482 | https://github.com/python/cpython/pull/93231/commits/1e8e482dfb690b20fbc57be28c2b7b6cd1e58f32 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| May 25, 2022 | https://github.com/python/cpython/pull/93231#issuecomment-1137887921 |
| require a NEWS entry | https://devguide.python.org/committing/#updating-news-and-what-s-new-in-python |
| blurb_it | https://blurb-it.herokuapp.com |
| blurb | https://pypi.org/project/blurb/ |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 25, 2022 | https://github.com/python/cpython/pull/93231#event-6681407130 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/93231/commits/994ca363e05b10235266a30dd1ac0a333a2978c7 |
| 994ca36 | https://github.com/python/cpython/pull/93231/commits/994ca363e05b10235266a30dd1ac0a333a2978c7 |
| https://github.com/jackh-ncl |
| jackh-ncl | https://github.com/jackh-ncl |
| May 25, 2022 22:10 | https://github.com/python/cpython/pull/93231#event-6681439187 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
|
Oct 18, 2022
| https://github.com/python/cpython/pull/93231#pullrequestreview-1146126581 |
|
View reviewed changes
| https://github.com/python/cpython/pull/93231/files/994ca363e05b10235266a30dd1ac0a333a2978c7 |
| Misc/NEWS.d/next/Library/2022-05-25-22-09-38.gh-issue-92886.ylwDSc.rst | https://github.com/python/cpython/pull/93231/files/994ca363e05b10235266a30dd1ac0a333a2978c7#diff-7b6a93d114a6cd22008e53fb2800c360d70d5d8742d4bbf68ecc86851c2321be |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
| jackh-ncl | https://github.com/jackh-ncl |
| October 18, 2022 17:08 | https://github.com/python/cpython/pull/93231#commits-pushed-539de23 |
|
| https://github.com/jackh-ncl |
|
| https://github.com/iritkatriel |
| Update Misc/NEWS.d/next/Library/2022-05-25-22-09-38.gh-issue-92886.yl… | https://github.com/python/cpython/pull/93231/commits/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8 |
| 539de23 | https://github.com/python/cpython/pull/93231/commits/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8 |
|
| https://github.com/iritkatriel |
| Merge branch 'main' into 92886-wsgiref | https://github.com/python/cpython/pull/93231/commits/e38fe392a829883e5b98c698fc5c263749812062 |
| e38fe39 | https://github.com/python/cpython/pull/93231/commits/e38fe392a829883e5b98c698fc5c263749812062 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
|
Oct 18, 2022
| https://github.com/python/cpython/pull/93231#pullrequestreview-1146130017 |
|
View reviewed changes
| https://github.com/python/cpython/pull/93231/files/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 18, 2022 | https://github.com/python/cpython/pull/93231#event-7613311657 |
| iritkatriel | https://github.com/iritkatriel |
| October 19, 2022 11:06 | https://github.com/python/cpython/pull/93231#commits-pushed-6278625 |
|
| https://github.com/iritkatriel |
| Merge branch 'main' into 92886-wsgiref | https://github.com/python/cpython/pull/93231/commits/6278625a61e09d515be70a3c670be470425c3c47 |
| 6278625 | https://github.com/python/cpython/pull/93231/commits/6278625a61e09d515be70a3c670be470425c3c47 |
|
| https://github.com/iritkatriel |
| Merge branch 'main' into 92886-wsgiref | https://github.com/python/cpython/pull/93231/commits/c0ea1b44b817355fc4cbd8ff2758c43a254dbeb5 |
| c0ea1b4 | https://github.com/python/cpython/pull/93231/commits/c0ea1b44b817355fc4cbd8ff2758c43a254dbeb5 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| b6e59d7 | https://github.com/python/cpython/commit/b6e59d76c0e1214ca2c927be35f165ecd1f763df |
| Oct 19, 2022 | https://github.com/python/cpython/pull/93231#event-7620204875 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Oct 19, 2022 | https://github.com/python/cpython/pull/93231#event-7620205251 |
| carljm | https://github.com/carljm |
|
Oct 20, 2022
| https://github.com/python/cpython/pull/93231#ref-commit-8bba5da |
|
| https://github.com/carljm |
| Merge branch 'main' into typewatch | https://github.com/carljm/cpython/commit/8bba5da3257ff3464b4d5e5913ebe3ac86644fd8 |
| 8bba5da | https://github.com/carljm/cpython/commit/8bba5da3257ff3464b4d5e5913ebe3ac86644fd8 |
| pythongh-98461 | https://github.com/python/cpython/issues/98461 |
| pythonGH-98464 | https://github.com/python/cpython/pull/98464 |
| pythongh-98421 | https://github.com/python/cpython/issues/98421 |
| pythonGH-98422 | https://github.com/python/cpython/pull/98422 |
| pythongh-98360 | https://github.com/python/cpython/issues/98360 |
| pythonGH-98462 | https://github.com/python/cpython/pull/98462 |
| python#98480 | https://github.com/python/cpython/pull/98480 |
| pythonGH-98481 | https://github.com/python/cpython/pull/98481 |
| pythonGH-98475 | https://github.com/python/cpython/pull/98475 |
| pythongh-95023 | https://github.com/python/cpython/issues/95023 |
| python#95046 | https://github.com/python/cpython/pull/95046 |
| pythonGH-98363 | https://github.com/python/cpython/issues/98363 |
| pythonGH-98419 | https://github.com/python/cpython/pull/98419 |
| pythongh-98374 | https://github.com/python/cpython/issues/98374 |
| pythongh-98450 | https://github.com/python/cpython/pull/98450 |
| python#98351 | https://github.com/python/cpython/pull/98351 |
| pythongh-98354 | https://github.com/python/cpython/issues/98354 |
| pythonGH-98412 | https://github.com/python/cpython/pull/98412 |
| pythongh-98257 | https://github.com/python/cpython/issues/98257 |
| python#98258 | https://github.com/python/cpython/pull/98258 |
| pythongh-98414 | https://github.com/python/cpython/issues/98414 |
| pythonGH-98460 | https://github.com/python/cpython/pull/98460 |
| pythongh-98417 | https://github.com/python/cpython/issues/98417 |
| pythonGH-98418 | https://github.com/python/cpython/pull/98418 |
| python#98409 | https://github.com/python/cpython/pull/98409 |
| pythonGH-98350 | https://github.com/python/cpython/pull/98350 |
| python#98441 | https://github.com/python/cpython/pull/98441 |
| pythongh-92886 | https://github.com/python/cpython/issues/92886 |
| pythonGH-93231 | https://github.com/python/cpython/pull/93231 |
| pythongh-92886 | https://github.com/python/cpython/issues/92886 |
| pythonGH-93233 | https://github.com/python/cpython/pull/93233 |
| pythongh-92886 | https://github.com/python/cpython/issues/92886 |
| pythonGH-93235 | https://github.com/python/cpython/pull/93235 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93231 |
|
| https://github.com/iritkatriel |
|
iritkatriel
| https://github.com/iritkatriel |
|
| https://github.com/python/cpython/pull/93231/files/539de23e3cf6b9a4d7d32e9ad063ac28eda8fcd8 |
| Please reload this page | https://github.com/python/cpython/pull/93231 |
|
| https://github.com/jackh-ncl |
|
| https://github.com/bedevere-bot |
|
| https://github.com/iritkatriel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |