René's URL Explorer Experiment


Title: gh-74696: Do not change the current working directory in shutil.make_archive() if possible by serhiy-storchaka · Pull Request #93160 · python/cpython · GitHub

Open Graph Title: gh-74696: Do not change the current working directory in shutil.make_archive() if possible by serhiy-storchaka · Pull Request #93160 · python/cpython

X Title: gh-74696: Do not change the current working directory in shutil.make_archive() if possible by serhiy-storchaka · Pull Request #93160 · python/cpython

Description: It is no longer changed when create a zip or tar archive. It is still changed for custom archivers registered with shutil.register_archive_format() if root_dir is not None. #74696

Open Graph Description: It is no longer changed when create a zip or tar archive. It is still changed for custom archivers registered with shutil.register_archive_format() if root_dir is not None. #74696

X Description: It is no longer changed when create a zip or tar archive. It is still changed for custom archivers registered with shutil.register_archive_format() if root_dir is not None. #74696

Opengraph URL: https://github.com/python/cpython/pull/93160

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1784241c-e074-e61f-52d2-70d4e2013c6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE49C:256A62:90FC3D:C61E13:6969E662
html-safe-nonced8ef31b15b847fd7646f01d9b1b95c8b9ed2cf8c5c2a15fbd8319d4fec804d34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDlDOjI1NkE2Mjo5MEZDM0Q6QzYxRTEzOjY5NjlFNjYyIiwidmlzaXRvcl9pZCI6IjI5NjQwNDEwNjI1NTc1NDE5ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace821647d9d2f23fe779a448d1c5bb8efe1875b1928c6bfa1c149eab9a6a2b836
hovercard-subject-tagpull_request:945318265
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/93160/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altIt is no longer changed when create a zip or tar archive. It is still changed for custom archivers registered with shutil.register_archive_format() if root_dir is not None. #74696
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/93160/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93160%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93160%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93160/files
Reloadhttps://github.com/python/cpython/pull/93160/files
Reloadhttps://github.com/python/cpython/pull/93160/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
serhiy-storchaka:shutil-make_archive-chdirhttps://github.com/serhiy-storchaka/cpython/tree/shutil-make_archive-chdir
Conversation 10 https://github.com/python/cpython/pull/93160
Commits 6 https://github.com/python/cpython/pull/93160/commits
Checks 0 https://github.com/python/cpython/pull/93160/checks
Files changed https://github.com/python/cpython/pull/93160/files
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
gh-74696: Do not change the current working directory in shutil.make_archive() if possible https://github.com/python/cpython/pull/93160/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/93160/files
d9f680d gh-74696: Do not change the current working directory in shutil.make_… serhiy-storchaka May 24, 2022 https://github.com/python/cpython/pull/93160/commits/d9f680d23282e1bce406315f2636710bf37a1ce7
21cd33d Add comments for _ARCHIVE_FORMATS and _UNPACK_FORMATS. serhiy-storchaka May 24, 2022 https://github.com/python/cpython/pull/93160/commits/21cd33d4917456cf53b315ba6651d8c6970bc6a6
fb50a41 Update Lib/shutil.py serhiy-storchaka May 24, 2022 https://github.com/python/cpython/pull/93160/commits/fb50a411da28daa3b7f46547c94b204d45478cce
2d497e3 Minor doc tweaks ambv Jun 21, 2022 https://github.com/python/cpython/pull/93160/commits/2d497e3c13283acd3a1e23233568f1cbc796abc7
1ccb177 Merge branch 'main' into shutil-make_archive-chdir serhiy-storchaka Jun 22, 2022 https://github.com/python/cpython/pull/93160/commits/1ccb1772574ead6f169bcf957dea492380ba1e5a
927d2d4 Add tests. serhiy-storchaka Jun 22, 2022 https://github.com/python/cpython/pull/93160/commits/927d2d41e345b1ab2f5dc4f4a1baffc8d88bb97f
Clear filters https://github.com/python/cpython/pull/93160/files
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
shutil.rst https://github.com/python/cpython/pull/93160/files#diff-f2e20586f33534d9cf4f058fffcedbe5cba1abf0f9e9813968846d7a8cccb719
shutil.py https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
test_shutil.py https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
2022-05-24-11-19-04.gh-issue-74696.-cnf-A.rst https://github.com/python/cpython/pull/93160/files#diff-4dde635c9e933a2ed79938444c1df57b17a4140b8970d50806e6e1864be1fb78
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L559
Doc/library/shutil.rsthttps://github.com/python/cpython/pull/93160/files#diff-f2e20586f33534d9cf4f058fffcedbe5cba1abf0f9e9813968846d7a8cccb719
View file https://github.com/serhiy-storchaka/cpython/blob/927d2d41e345b1ab2f5dc4f4a1baffc8d88bb97f/Doc/library/shutil.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93160/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93160/files#diff-f2e20586f33534d9cf4f058fffcedbe5cba1abf0f9e9813968846d7a8cccb719
https://github.com/python/cpython/pull/93160/files#diff-f2e20586f33534d9cf4f058fffcedbe5cba1abf0f9e9813968846d7a8cccb719
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L560
Lib/shutil.pyhttps://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
View file https://github.com/serhiy-storchaka/cpython/blob/927d2d41e345b1ab2f5dc4f4a1baffc8d88bb97f/Lib/shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93160/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
Please reload this pagehttps://github.com/python/cpython/pull/93160/files
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/pull/93160/files#diff-db8ac59326160713929e0e1973aef54f0280fe9f154ef24d14244909a0e0689b
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/test/test_shutil.pyhttps://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
View file https://github.com/serhiy-storchaka/cpython/blob/927d2d41e345b1ab2f5dc4f4a1baffc8d88bb97f/Lib/test/test_shutil.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93160/{{ revealButtonHref }}
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
https://github.com/python/cpython/pull/93160/files#diff-ed52359d591fff799c0b81414bdfd9a90541cbc3b97b50a7ebaca38ed98062e7
Misc/NEWS.d/next/Library/2022-05-24-11-19-04.gh-issue-74696.-cnf-A.rsthttps://github.com/python/cpython/pull/93160/files#diff-4dde635c9e933a2ed79938444c1df57b17a4140b8970d50806e6e1864be1fb78
View file https://github.com/serhiy-storchaka/cpython/blob/927d2d41e345b1ab2f5dc4f4a1baffc8d88bb97f/Misc/NEWS.d/next/Library/2022-05-24-11-19-04.gh-issue-74696.-cnf-A.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/93160/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.