| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d473a367-0592-8e65-d01e-bdbf5ea9d429 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8466:382318:99C6DF:C141B4:6B021B84 |
| html-safe-nonce | 95374fee5e53bb602bcb196d1cba5f93fa282079ed9fe73969e1720c52a0874f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDY2OjM4MjMxODo5OUM2REY6QzE0MUI0OjZCMDIxQjg0IiwidmlzaXRvcl9pZCI6IjQyNTkzOTk1Nzg0MDA0NjM3NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d8c2f578230ef2bd6aae692b31cf89671ef88e910994bf8f2d1b371b18ff4ae1 |
| hovercard-subject-tag | pull_request:943288429 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/93034/files |
| twitter:image | https://avatars.githubusercontent.com/u/35538541?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/35538541?s=400&v=4 |
| og:image:alt | This was brought up a bit in #69009 but the larger issue is mostly
different.
Generally comparable perf for the "good" case where memchr doesn't
return any collisions (false matches o... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/93034/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93034%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93034%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/93034/files |
| Reload | https://github.com/python/cpython/pull/93034/files |
| Reload | https://github.com/python/cpython/pull/93034/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| methane | https://github.com/methane |
| python:main | https://github.com/python/cpython/tree/main |
| goldsteinn:use-wmemchr-in-stringlib | https://github.com/goldsteinn/cpython/tree/use-wmemchr-in-stringlib |
|
Conversation
24
| https://github.com/python/cpython/pull/93034 |
|
Commits
6
| https://github.com/python/cpython/pull/93034/commits |
|
Checks
0
| https://github.com/python/cpython/pull/93034/checks |
|
Files changed
| https://github.com/python/cpython/pull/93034/files |
| Please reload this page | https://github.com/python/cpython/pull/93034/files |
|
gh-93033: Use wmemchr in find_char and replace_1char_inplace
| https://github.com/python/cpython/pull/93034/files#top |
|
Show all changes
6 commits
| https://github.com/python/cpython/pull/93034/files |
|
80bfc80
gh-93033: Use wmemchr in find_char and replace_1char_inplace
goldsteinn May 20, 2022
| https://github.com/python/cpython/pull/93034/commits/80bfc80054f94049b4d8954bb999d5554384f2d8 |
|
cd985e5
📜🤖 Added by blurb_it.
blurb-it[bot] May 21, 2022
| https://github.com/python/cpython/pull/93034/commits/cd985e57e85f294db139bd01e5197183d9f1ea66 |
|
56f6b42
Add missing STRINGLIB_FAST_MEMCHR in bytearrayobject.c and bytes_meth…
goldsteinn May 21, 2022
| https://github.com/python/cpython/pull/93034/commits/56f6b423fdc662b2efc21f66c8dcef9ec58d3929 |
|
928d5df
Merge remote-tracking branch 'refs/remotes/origin/use-wmemchr-in-stri…
goldsteinn May 21, 2022
| https://github.com/python/cpython/pull/93034/commits/928d5df63e5a63be4895e488715bee4cbc3d62ea |
|
8219d71
📜🤖 Added by blurb_it.
blurb-it[bot] May 22, 2022
| https://github.com/python/cpython/pull/93034/commits/8219d7149cb9985f3215c39329caeb22c4fe2d7f |
|
2bbb3ce
Delete 2022-05-21-20-25-04.gh-issue-93033.QuMGyh.rst
methane May 23, 2022
| https://github.com/python/cpython/pull/93034/commits/2bbb3ce6498398c4f6438d24d8a87f679f49adfc |
|
Clear filters
| https://github.com/python/cpython/pull/93034/files |
| Please reload this page | https://github.com/python/cpython/pull/93034/files |
| Please reload this page | https://github.com/python/cpython/pull/93034/files |
|
2022-05-22-23-46-18.gh-issue-93033.wZfiL-.rst
| https://github.com/python/cpython/pull/93034/files#diff-1a0698aa62321c04224fb4cafeae9c12f16af7ed3636565503ef743c078c8dfb |
|
bytearrayobject.c
| https://github.com/python/cpython/pull/93034/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c |
|
bytes_methods.c
| https://github.com/python/cpython/pull/93034/files#diff-1ff52799e69c723776ec4b4e3073b79455f51b75cbe7f6acf0f58ea70db35bd6 |
|
asciilib.h
| https://github.com/python/cpython/pull/93034/files#diff-58caa6a1367443c90746656e588ae8643af1d205c58fa359290cf77196816028 |
|
fastsearch.h
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
replace.h
| https://github.com/python/cpython/pull/93034/files#diff-8a645693054bd8d0438eb5cd5a52ca3f68671c5ab9754500d1da3fa7af73632c |
|
stringdefs.h
| https://github.com/python/cpython/pull/93034/files#diff-d143a2f435f065bcf0d618ec0bc2b27eefeac0a686bab6eca2be46f4c915f899 |
|
ucs1lib.h
| https://github.com/python/cpython/pull/93034/files#diff-d3e3df1b81192557cd5632a2a7d7c840b20cddcc82cb6d022730b9990f8568f0 |
|
ucs2lib.h
| https://github.com/python/cpython/pull/93034/files#diff-5d38fa09c2c8bd2b12200fdb8fb4063d86de2945ba5d65b9e2a0990eaf43ef7f |
|
ucs4lib.h
| https://github.com/python/cpython/pull/93034/files#diff-bde049932aed3f49a70a78f25de3241723a217db3fd254f221993feb89669383 |
|
undef.h
| https://github.com/python/cpython/pull/93034/files#diff-ed390391cdfe92d35f9098e9ac1d4077313b522b83fb80c640165e29075b53b6 |
| Misc/NEWS.d/next/Library/2022-05-22-23-46-18.gh-issue-93033.wZfiL-.rst | https://github.com/python/cpython/pull/93034/files#diff-1a0698aa62321c04224fb4cafeae9c12f16af7ed3636565503ef743c078c8dfb |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Misc/NEWS.d/next/Library/2022-05-22-23-46-18.gh-issue-93033.wZfiL-.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
| Objects/bytearrayobject.c | https://github.com/python/cpython/pull/93034/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/bytearrayobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c |
|
| https://github.com/python/cpython/pull/93034/files#diff-6878f29bbfb711dc7cd2a89b2b2941b1f900b6367d30181a2ff45460b591b04c |
| Objects/bytes_methods.c | https://github.com/python/cpython/pull/93034/files#diff-1ff52799e69c723776ec4b4e3073b79455f51b75cbe7f6acf0f58ea70db35bd6 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/bytes_methods.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-1ff52799e69c723776ec4b4e3073b79455f51b75cbe7f6acf0f58ea70db35bd6 |
|
| https://github.com/python/cpython/pull/93034/files#diff-1ff52799e69c723776ec4b4e3073b79455f51b75cbe7f6acf0f58ea70db35bd6 |
| Objects/stringlib/asciilib.h | https://github.com/python/cpython/pull/93034/files#diff-58caa6a1367443c90746656e588ae8643af1d205c58fa359290cf77196816028 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/asciilib.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-58caa6a1367443c90746656e588ae8643af1d205c58fa359290cf77196816028 |
| Please reload this page | https://github.com/python/cpython/pull/93034/files |
| Objects/stringlib/fastsearch.h | https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/fastsearch.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
|
| https://github.com/python/cpython/pull/93034/files#diff-67ae1b84396bc0119774489a3e62be151a8e1b1317a63c540f976d57d3e0489d |
| Objects/stringlib/replace.h | https://github.com/python/cpython/pull/93034/files#diff-8a645693054bd8d0438eb5cd5a52ca3f68671c5ab9754500d1da3fa7af73632c |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/replace.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-8a645693054bd8d0438eb5cd5a52ca3f68671c5ab9754500d1da3fa7af73632c |
|
| https://github.com/python/cpython/pull/93034/files#diff-8a645693054bd8d0438eb5cd5a52ca3f68671c5ab9754500d1da3fa7af73632c |
| Objects/stringlib/stringdefs.h | https://github.com/python/cpython/pull/93034/files#diff-d143a2f435f065bcf0d618ec0bc2b27eefeac0a686bab6eca2be46f4c915f899 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/stringdefs.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-d143a2f435f065bcf0d618ec0bc2b27eefeac0a686bab6eca2be46f4c915f899 |
| Objects/stringlib/ucs1lib.h | https://github.com/python/cpython/pull/93034/files#diff-d3e3df1b81192557cd5632a2a7d7c840b20cddcc82cb6d022730b9990f8568f0 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/ucs1lib.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-d3e3df1b81192557cd5632a2a7d7c840b20cddcc82cb6d022730b9990f8568f0 |
|
| https://github.com/python/cpython/pull/93034/files#diff-d3e3df1b81192557cd5632a2a7d7c840b20cddcc82cb6d022730b9990f8568f0 |
| Objects/stringlib/ucs2lib.h | https://github.com/python/cpython/pull/93034/files#diff-5d38fa09c2c8bd2b12200fdb8fb4063d86de2945ba5d65b9e2a0990eaf43ef7f |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/ucs2lib.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-5d38fa09c2c8bd2b12200fdb8fb4063d86de2945ba5d65b9e2a0990eaf43ef7f |
| Objects/stringlib/ucs4lib.h | https://github.com/python/cpython/pull/93034/files#diff-bde049932aed3f49a70a78f25de3241723a217db3fd254f221993feb89669383 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/ucs4lib.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-bde049932aed3f49a70a78f25de3241723a217db3fd254f221993feb89669383 |
|
| https://github.com/python/cpython/pull/93034/files#diff-bde049932aed3f49a70a78f25de3241723a217db3fd254f221993feb89669383 |
| Objects/stringlib/undef.h | https://github.com/python/cpython/pull/93034/files#diff-ed390391cdfe92d35f9098e9ac1d4077313b522b83fb80c640165e29075b53b6 |
|
View file
| https://github.com/goldsteinn/cpython/blob/2bbb3ce6498398c4f6438d24d8a87f679f49adfc/Objects/stringlib/undef.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/93034/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/93034/files#diff-ed390391cdfe92d35f9098e9ac1d4077313b522b83fb80c640165e29075b53b6 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |