René's URL Explorer Experiment


Title: gh-93033: Use wmemchr in find_char and replace_1char_inplace by goldsteinn · Pull Request #93034 · python/cpython · GitHub

Open Graph Title: gh-93033: Use wmemchr in find_char and replace_1char_inplace by goldsteinn · Pull Request #93034 · python/cpython

X Title: gh-93033: Use wmemchr in find_char and replace_1char_inplace by goldsteinn · Pull Request #93034 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This was brought up a bit in #69009 but the larger issue is mostly different. Generally comparable perf for the "good" case where memchr doesn't return any collisions (false matches o...

X Description: This was brought up a bit in #69009 but the larger issue is mostly different. Generally comparable perf for the "good" case where memchr doesn't return any collisions (fal...

Opengraph URL: https://github.com/python/cpython/pull/93034

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:bb8cfb14-a0ed-cd68-6934-3c299d235df1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEFE:36A3E:3680BFB:48AD408:6B0212CD
html-safe-nonce5904bff8d91dd5634fd912adbaab148f2e7448e38b454867ac390e1743f1fb6c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUZFOjM2QTNFOjM2ODBCRkI6NDhBRDQwODo2QjAyMTJDRCIsInZpc2l0b3JfaWQiOiIzMzcwMjM5MzI1NDc1MzEyMzMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7a799361dd69a6a2b157a3a01fd54c57526986fc1644d2e462cbcd4d9e378ffc
hovercard-subject-tagpull_request:943288429
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/93034/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6f8cd3dafe132c35d1856273f62937e337fe99ebf654136282e6a9a353414898/python/cpython/pull/93034
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6f8cd3dafe132c35d1856273f62937e337fe99ebf654136282e6a9a353414898/python/cpython/pull/93034
og:image:altThis was brought up a bit in #69009 but the larger issue is mostly different. Generally comparable perf for the "good" case where memchr doesn't return any collisions (false matches o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegoldsteinn
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/93034#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93034
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93034
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/93034
Reloadhttps://github.com/python/cpython/pull/93034
Reloadhttps://github.com/python/cpython/pull/93034
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
methanehttps://github.com/methane
python:mainhttps://github.com/python/cpython/tree/main
goldsteinn:use-wmemchr-in-stringlibhttps://github.com/goldsteinn/cpython/tree/use-wmemchr-in-stringlib
Conversationhttps://github.com/python/cpython/pull/93034
Commits6 (6)https://github.com/python/cpython/pull/93034/commits
Checkshttps://github.com/python/cpython/pull/93034/checks
Files changedhttps://github.com/python/cpython/pull/93034/files
gh-93033: Use wmemchr in find_char and replace_1char_inplacehttps://github.com/python/cpython/pull/93034#top
methanehttps://github.com/methane
python:mainhttps://github.com/python/cpython/tree/main
goldsteinn:use-wmemchr-in-stringlibhttps://github.com/goldsteinn/cpython/tree/use-wmemchr-in-stringlib
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 20, 2022https://github.com/python/cpython/pull/93034#issue-1243786142
Please reload this pagehttps://github.com/python/cpython/pull/93034
#69009https://github.com/python/cpython/issues/69009
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/ghost
ghosthttps://github.com/ghost
May 20, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133462245
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432b8b111ec9bf5bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 20, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133462252
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 20, 2022https://github.com/python/cpython/pull/93034#event-6654050976
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 21, 2022 https://github.com/python/cpython/pull/93034#ref-issue-1243783561
Use wmemchr in stringlib if sizeof(STRINGLIB_CHAR) == sizeof(wchar_t) #93033 https://github.com/python/cpython/issues/93033
https://github.com/corona10
corona10https://github.com/corona10
methanehttps://github.com/methane
May 21, 2022 15:34https://github.com/python/cpython/pull/93034#event-6655071354
https://github.com/sweeneyde
sweeneydehttps://github.com/sweeneyde
May 21, 2022 https://github.com/python/cpython/pull/93034#pullrequestreview-980872798
View reviewed changes https://github.com/python/cpython/pull/93034/files
Objects/stringlib/asciilib.hhttps://github.com/python/cpython/pull/93034/files#diff-58caa6a1367443c90746656e588ae8643af1d205c58fa359290cf77196816028
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/goldsteinn
pythongh-93033https://github.com/python/cpython/issues/93033
: Use wmemchr in find_char and replace_1char_inplacehttps://github.com/python/cpython/pull/93034/commits/80bfc80054f94049b4d8954bb999d5554384f2d8
80bfc80https://github.com/python/cpython/pull/93034/commits/80bfc80054f94049b4d8954bb999d5554384f2d8
python#69009https://github.com/python/cpython/issues/69009
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
force-pushedhttps://github.com/python/cpython/compare/2b7fc753c6d023c0e21a2a4f9e4c0ac4b6867fb8..80bfc80054f94049b4d8954bb999d5554384f2d8
2b7fc75https://github.com/python/cpython/commit/2b7fc753c6d023c0e21a2a4f9e4c0ac4b6867fb8
80bfc80https://github.com/python/cpython/commit/80bfc80054f94049b4d8954bb999d5554384f2d8
Compare https://github.com/python/cpython/compare/2b7fc753c6d023c0e21a2a4f9e4c0ac4b6867fb8..80bfc80054f94049b4d8954bb999d5554384f2d8
May 21, 2022 20:18https://github.com/python/cpython/pull/93034#event-6655344804
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 21, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133762948
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/93034
blurb-ithttps://github.com/apps/blurb-it
May 21, 2022 20:25https://github.com/python/cpython/pull/93034#commits-pushed-cd985e5
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/93034/commits/cd985e57e85f294db139bd01e5197183d9f1ea66
cd985e5https://github.com/python/cpython/pull/93034/commits/cd985e57e85f294db139bd01e5197183d9f1ea66
https://github.com/goldsteinn
Add missing STRINGLIB_FAST_MEMCHR in bytearrayobject.c and bytes_meth…https://github.com/python/cpython/pull/93034/commits/56f6b423fdc662b2efc21f66c8dcef9ec58d3929
56f6b42https://github.com/python/cpython/pull/93034/commits/56f6b423fdc662b2efc21f66c8dcef9ec58d3929
https://github.com/goldsteinn
Merge remote-tracking branch 'refs/remotes/origin/use-wmemchr-in-stri…https://github.com/python/cpython/pull/93034/commits/928d5df63e5a63be4895e488715bee4cbc3d62ea
928d5dfhttps://github.com/python/cpython/pull/93034/commits/928d5df63e5a63be4895e488715bee4cbc3d62ea
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 22, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133940835
#69009https://github.com/python/cpython/issues/69009
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 22, 2022 17:44https://github.com/python/cpython/pull/93034#event-6656444417
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 22, 2022https://github.com/python/cpython/pull/93034#event-6656458535
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 22, 2022https://github.com/python/cpython/pull/93034#event-6656458937
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 22, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133944583
#69009https://github.com/python/cpython/issues/69009
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 22, 2022 https://github.com/python/cpython/pull/93034#pullrequestreview-981000175
View reviewed changes https://github.com/python/cpython/pull/93034/files/928d5df63e5a63be4895e488715bee4cbc3d62ea
Misc/NEWS.d/next/Library/2022-05-21-20-25-04.gh-issue-93033.QuMGyh.rsthttps://github.com/python/cpython/pull/93034/files/928d5df63e5a63be4895e488715bee4cbc3d62ea#diff-be74f565ca95ddfffbde7cb4c376cefc8c77663834b6485a77db0ffe8b2c0b50
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
May 22, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133945774
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 22, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133946044
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 22, 2022https://github.com/python/cpython/pull/93034#issuecomment-1133946993
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/93034/commits/8219d7149cb9985f3215c39329caeb22c4fe2d7f
8219d71https://github.com/python/cpython/pull/93034/commits/8219d7149cb9985f3215c39329caeb22c4fe2d7f
https://github.com/methane
methanehttps://github.com/methane
May 23, 2022 https://github.com/python/cpython/pull/93034#pullrequestreview-981074797
View reviewed changes https://github.com/python/cpython/pull/93034/files/8219d7149cb9985f3215c39329caeb22c4fe2d7f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 23, 2022https://github.com/python/cpython/pull/93034#event-6657215819
https://github.com/methane
Delete 2022-05-21-20-25-04.gh-issue-93033.QuMGyh.rsthttps://github.com/python/cpython/pull/93034/commits/2bbb3ce6498398c4f6438d24d8a87f679f49adfc
2bbb3cehttps://github.com/python/cpython/pull/93034/commits/2bbb3ce6498398c4f6438d24d8a87f679f49adfc
https://github.com/sweeneyde
sweeneydehttps://github.com/sweeneyde
May 23, 2022https://github.com/python/cpython/pull/93034#issuecomment-1134138714
Please reload this pagehttps://github.com/python/cpython/pull/93034
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/sweeneyde
sweeneydehttps://github.com/sweeneyde
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
May 23, 2022https://github.com/python/cpython/pull/93034#event-6657476337
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 23, 2022https://github.com/python/cpython/pull/93034#issuecomment-1134139269
@sweeneydehttps://github.com/sweeneyde
2bbb3cehttps://github.com/python/cpython/commit/2bbb3ce6498398c4f6438d24d8a87f679f49adfc
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
May 23, 2022https://github.com/python/cpython/pull/93034#event-6657476429
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 23, 2022https://github.com/python/cpython/pull/93034#issuecomment-1134803981
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/sweeneyde
sweeneydehttps://github.com/sweeneyde
May 23, 2022https://github.com/python/cpython/pull/93034#issuecomment-1134822955
cpython/Objects/obmalloc.chttps://github.com/python/cpython/blob/b2694ab46997746eae7e913738623b39f6334473/Objects/obmalloc.c#L878-L884
b2694abhttps://github.com/python/cpython/commit/b2694ab46997746eae7e913738623b39f6334473
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/sweeneyde
sweeneydehttps://github.com/sweeneyde
May 23, 2022 https://github.com/python/cpython/pull/93034#pullrequestreview-981979883
View reviewed changes https://github.com/python/cpython/pull/93034/files/2bbb3ce6498398c4f6438d24d8a87f679f49adfc
https://github.com/methane
methanehttps://github.com/methane
May 24, 2022https://github.com/python/cpython/pull/93034#issuecomment-1135304017
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/methane
methanehttps://github.com/methane
7108bdfhttps://github.com/python/cpython/commit/7108bdf27c7a460cf83c4a01dea54ae4591d8aea
May 24, 2022https://github.com/python/cpython/pull/93034#event-6665135459
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 24, 2022https://github.com/python/cpython/pull/93034#event-6665135592
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 24, 2022https://github.com/python/cpython/pull/93034#issuecomment-1135376085
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/goldsteinn
goldsteinnhttps://github.com/goldsteinn
May 24, 2022 03:59https://github.com/python/cpython/pull/93034#event-6665556994
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F93034
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/93034/files/928d5df63e5a63be4895e488715bee4cbc3d62ea
https://github.com/AA-Turner
AA-Turner https://github.com/AA-Turner
https://github.com/python/cpython/pull/93034/files/2b7fc753c6d023c0e21a2a4f9e4c0ac4b6867fb8
https://github.com/methane
methane https://github.com/methane
https://github.com/python/cpython/pull/93034/files/8219d7149cb9985f3215c39329caeb22c4fe2d7f
https://github.com/sweeneyde
sweeneyde https://github.com/sweeneyde
https://github.com/python/cpython/pull/93034/files/2bbb3ce6498398c4f6438d24d8a87f679f49adfc
Please reload this pagehttps://github.com/python/cpython/pull/93034
Please reload this pagehttps://github.com/python/cpython/pull/93034
https://github.com/goldsteinn
https://github.com/bedevere-bot
https://github.com/serhiy-storchaka
https://github.com/sweeneyde
https://github.com/methane
https://github.com/AA-Turner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.