René's URL Explorer Experiment


Title: bpo-26467: Adds AsyncMock for asyncio Mock library support by lisroach · Pull Request #9296 · python/cpython · GitHub

Open Graph Title: bpo-26467: Adds AsyncMock for asyncio Mock library support by lisroach · Pull Request #9296 · python/cpython

X Title: bpo-26467: Adds AsyncMock for asyncio Mock library support by lisroach · Pull Request #9296 · python/cpython

Description: This is my initial pass at supporting coroutine mocking via a new Mock subclass, CoroutineMock. It can be used to mock out coroutines and have them validate as coroutines: >>> mock = CoroutineMock() >>> asyncio.iscoroutinefunction(mock) True Test that a coroutine was awaited: class TestTests(unittest.TestCase): def test_assert_awaited(self): async def main(): mock = CoroutineMock() with self.assertRaises(AssertionError): mock.assert_awaited() await mock() mock.assert_awaited() asyncio.run(main()) Also awaited_with, awaited_once_with, etc. Things that I could use advice on: Some of the code has been borrowed by asynctest (https://pypi.org/project/asynctest/) which is licensed under Apache 2. I have reached out to the author and am waiting to hear back, but am not sure how we feel about having Apache 2 licensed stuff in CPython. I could rewrite those spots if needed. inspect.iscoroutine will return False for CoroutineMock objects. This is because the check is isinstance(object, types.CoroutineType), and CoroutineTypes are concrete. I've looked into using something like, register, but it doesn't work here, so I need someway to make a Mock look like a types.CoroutineType but I am unsure how. In CoroutineMockAssert tests, I have asyncio.events._event_loop_policy unset because it causes the env to change when running tests if it is not unset. There is probably a better way to do this where the environment doesn't get polluted? I plan on working on getting more example test cases for the CoroutineArguments test section, would be happy for advice though. And I will be writing up the documentation once the code has settled. https://bugs.python.org/issue26467

Open Graph Description: This is my initial pass at supporting coroutine mocking via a new Mock subclass, CoroutineMock. It can be used to mock out coroutines and have them validate as coroutines: >>> mock = Corou...

X Description: This is my initial pass at supporting coroutine mocking via a new Mock subclass, CoroutineMock. It can be used to mock out coroutines and have them validate as coroutines: >>> ...

Opengraph URL: https://github.com/python/cpython/pull/9296

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b75bccc-e6ed-7256-98f2-3e094f3d5bc3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE666:29131D:2CBA94:3F3579:696A4C34
html-safe-nonce923709e27b39acf6581c56b4d161481458ec6530099f5f1e2fd9b56f4e80d79a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjY2OjI5MTMxRDoyQ0JBOTQ6M0YzNTc5OjY5NkE0QzM0IiwidmlzaXRvcl9pZCI6IjgzNTE0ODIxNzk5MDc4OTg0MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2832835d8dc954668091cde19e265ba4d8463c450a400efd70f0ac4ec345284b
hovercard-subject-tagpull_request:215502301
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9296/files
twitter:imagehttps://avatars.githubusercontent.com/u/11097768?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11097768?s=400&v=4
og:image:altThis is my initial pass at supporting coroutine mocking via a new Mock subclass, CoroutineMock. It can be used to mock out coroutines and have them validate as coroutines: >>> mock = Corou...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9296/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9296%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9296%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9296/files
Reloadhttps://github.com/python/cpython/pull/9296/files
Reloadhttps://github.com/python/cpython/pull/9296/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
lisroachhttps://github.com/lisroach
python:masterhttps://github.com/python/cpython/tree/master
lisroach:asyncio_mockhttps://github.com/lisroach/cpython/tree/asyncio_mock
Conversation 73 https://github.com/python/cpython/pull/9296
Commits 27 https://github.com/python/cpython/pull/9296/commits
Checks 0 https://github.com/python/cpython/pull/9296/checks
Files changed https://github.com/python/cpython/pull/9296/files
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
bpo-26467: Adds AsyncMock for asyncio Mock library support https://github.com/python/cpython/pull/9296/files#top
Show all changes 27 commits https://github.com/python/cpython/pull/9296/files
4353041 Initial commmit adding asyncio mock support. lisroach May 14, 2018 https://github.com/python/cpython/pull/9296/commits/4353041ac52e379cdaf4902896995cc83a37c980
b83e5a5 Adding async support to the mock library. lisroach Jul 22, 2018 https://github.com/python/cpython/pull/9296/commits/b83e5a5a7b3facbf5c9aa31d4dc94e6f1ad34a0c
a9ea983 Removes superfluous changes. lisroach Aug 16, 2018 https://github.com/python/cpython/pull/9296/commits/a9ea983a3997a465183008b01d3f7027db6dbc19
50581e3 Cleans up comments. lisroach Aug 16, 2018 https://github.com/python/cpython/pull/9296/commits/50581e3c92cf91a8406939ed79f0312937966c08
96ddb0e Fixes inspect and attribute error issues. lisroach Sep 10, 2018 https://github.com/python/cpython/pull/9296/commits/96ddb0e32945f835f01a16f6969d533ea9952b77
a4d4dbc Fixes test_unittest changing env because of version issue. lisroach Sep 11, 2018 https://github.com/python/cpython/pull/9296/commits/a4d4dbceefd66b3485679d5b2dc13ef19b56ce49
bfdd5a7 Removes newlines from inspect. lisroach Sep 12, 2018 https://github.com/python/cpython/pull/9296/commits/bfdd5a7428a1e7d5738ba9f98f7a5c78342f72d6
ed7f13c Removes unneeded comment and newlines. lisroach Sep 12, 2018 https://github.com/python/cpython/pull/9296/commits/ed7f13cd15410b8cb3b6942ecc1640a8a99e3f81
34fa74e Fixes async tests. Removes inspect fix. lisroach Sep 14, 2018 https://github.com/python/cpython/pull/9296/commits/34fa74ef7fb951f991692f412e9c599b112aa75b
302ef64 Fixes environment test issue. lisroach Sep 14, 2018 https://github.com/python/cpython/pull/9296/commits/302ef648b854475e9b68e76d869dde01a9b23cb3
bf749ac Adds argument tests. lisroach Sep 14, 2018 https://github.com/python/cpython/pull/9296/commits/bf749ac6b84d4e5d4aecb29f23797f19d927a125
30b64b5 Adding the side_effect exception test. lisroach Sep 14, 2018 https://github.com/python/cpython/pull/9296/commits/30b64b53956d7eff6a3e353eff5026d18bf28e9a
5edac2a Changes CoroutineMock to AsyncMock. Removes old-style coroutine refer… lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/5edac2a053256898c5ec392f2368268a57ddd863
fa978cc Merge branch 'master' into asyncio_mock lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/fa978ccda67b1b040b2b9b1d2919a20a9531fb1b
24920a6 Changes fnmatch to list comp. lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/24920a638058a0be6993900d750590692ab404eb
aec3153 Fixes import and a rebase. lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/aec31537ceba78f4f7effba1bcb51eeddefacd0e
45dddb7 Merge branch 'master' of https://github.com/python/cpython into async… lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/45dddb708b250295273a5fcce035c77f0b04dcef
c0a88a9 Updates news with AsyncMock name change. lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/c0a88a90416225294f3913e03a64acfdf00fadf7
f9bee6e Removes extraneous comments. lisroach May 7, 2019 https://github.com/python/cpython/pull/9296/commits/f9bee6ebd1d23bf0d47475af4141892bec53a5b9
81ad0d1 Fixes RunTime warnings and missing io import. lisroach May 8, 2019 https://github.com/python/cpython/pull/9296/commits/81ad0d1a7bf681b01db85899b2c807385db1099c
c260104 Changes check to use issubclass instead of !=. lisroach May 8, 2019 https://github.com/python/cpython/pull/9296/commits/c2601049bea2f8335fe074a7ee76690fa081f2b6
ae13db1 Adds AsyncMock docs and tests for iterators and context managers. lisroach May 13, 2019 https://github.com/python/cpython/pull/9296/commits/ae13db16c2469ef7471e0087911f6bd796d3d965
68dff1b Uncomments commented out test. lisroach May 13, 2019 https://github.com/python/cpython/pull/9296/commits/68dff1b3e66ecfe02fa4dc70cb8f6cb2180df7f2
64301e2 Fixes based on comments. lisroach May 17, 2019 https://github.com/python/cpython/pull/9296/commits/64301e2b0207542fae47e710fd32dd414b2d9db6
c7cd95e Fixes broken docs. lisroach May 17, 2019 https://github.com/python/cpython/pull/9296/commits/c7cd95e1881556453e9cd9a99946261ab38ac8ca
033f7d3 Fixes broken doc await_arg. lisroach May 18, 2019 https://github.com/python/cpython/pull/9296/commits/033f7d3c85df4f9074bfcddb4f888abd8175aa23
2fef02c Adds shoutout to Martin Richard for asynctest. lisroach May 18, 2019 https://github.com/python/cpython/pull/9296/commits/2fef02c20f294b23d836ed217217ed90312a2d58
Clear filters https://github.com/python/cpython/pull/9296/files
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
unittest.mock.rst https://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
3.8.rst https://github.com/python/cpython/pull/9296/files#diff-fc26ec44ce02bff5ba0fc0c1c750748ff5dea3bec156c6fdf3f666d943e81992
mock.py https://github.com/python/cpython/pull/9296/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
testasync.py https://github.com/python/cpython/pull/9296/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
testmock.py https://github.com/python/cpython/pull/9296/files#diff-8f62756a81a581bd6e786e17dc7067e56d2befefa048e94670ef45ca494ec0c9
2018-09-13-20-33-24.bpo-26467.cahAk3.rst https://github.com/python/cpython/pull/9296/files#diff-490a61e5c3d9d38739d3ecf31fb57af4b169e0655c3596d5e7bdef7efccda2db
Doc/library/unittest.mock.rsthttps://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
View file https://github.com/lisroach/cpython/blob/2fef02c20f294b23d836ed217217ed90312a2d58/Doc/library/unittest.mock.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9296/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
https://github.com/python/cpython/pull/9296/files#diff-e24490db2cf4ecf0da79ab5fe9aa0ab7de1b333424356e079a5d56a263d2082a
Doc/whatsnew/3.8.rsthttps://github.com/python/cpython/pull/9296/files#diff-fc26ec44ce02bff5ba0fc0c1c750748ff5dea3bec156c6fdf3f666d943e81992
View file https://github.com/lisroach/cpython/blob/2fef02c20f294b23d836ed217217ed90312a2d58/Doc/whatsnew/3.8.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9296/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9296/files#diff-fc26ec44ce02bff5ba0fc0c1c750748ff5dea3bec156c6fdf3f666d943e81992
https://github.com/python/cpython/pull/9296/files#diff-fc26ec44ce02bff5ba0fc0c1c750748ff5dea3bec156c6fdf3f666d943e81992
Please reload this pagehttps://github.com/python/cpython/pull/9296/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.