René's URL Explorer Experiment


Title: gh-92658: Add Hyper-V socket support by jborean93 · Pull Request #92755 · python/cpython · GitHub

Open Graph Title: gh-92658: Add Hyper-V socket support by jborean93 · Pull Request #92755 · python/cpython

X Title: gh-92658: Add Hyper-V socket support by jborean93 · Pull Request #92755 · python/cpython

Description: Partially fixes #92658. There are 2 outstanding questions I have for the PR: What should connect and bind accept as the addr Currently the code accepts a tuple of 2 16 byte strings only. This could potentially be changed to somehow accept a uuid.UUID or even potentially a string of a UUID. My C skills are rusty so I just went with the simpler solution but if it is desired to change this or add support for other types I'm happy to do so at someones direction. How should I define/guard AF_HYPERV and # include Currently AF_HYPERV is defined at https://github.com/tpn/winsdk-10/blob/9b69fd26ac0c7d0b83d378dba01080e93349c2ed/Include/10.0.16299.0/shared/ws2def.h#L145-L148 and is only included if _WIN32_WINNT > 0x0604. Currently Python sets that at 0x0602 for Windows 8 compatibility which is why the PR manually defines it. The header also imports hvsocket.h for some other definitions used in the code but I'm unsure if this should be done conditionally somehow. Any suggestions or improvements would be great.

Open Graph Description: Partially fixes #92658. There are 2 outstanding questions I have for the PR: What should connect and bind accept as the addr Currently the code accepts a tuple of 2 16 byte strings only. This cou...

X Description: Partially fixes #92658. There are 2 outstanding questions I have for the PR: What should connect and bind accept as the addr Currently the code accepts a tuple of 2 16 byte strings only. This cou...

Opengraph URL: https://github.com/python/cpython/pull/92755

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c26f239b-6c10-3b63-4c74-f351419f7119
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92F8:144E47:37B6869:4A08B48:6B004ACE
html-safe-noncebaf73110acd0d50bdcd458268c072571c9126eba07b34ee7c55afe3915dd369e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkY4OjE0NEU0NzozN0I2ODY5OjRBMDhCNDg6NkIwMDRBQ0UiLCJ2aXNpdG9yX2lkIjoiNDA1Mjc2MDAwODc3NTk3NzY3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd10a5795e3283008b6f09701e92a13a1ba1cb2b6ed6cb47e03465ef52eb389ec
hovercard-subject-tagpull_request:935389519
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/92755/files
twitter:imagehttps://avatars.githubusercontent.com/u/8462645?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8462645?s=400&v=4
og:image:altPartially fixes #92658. There are 2 outstanding questions I have for the PR: What should connect and bind accept as the addr Currently the code accepts a tuple of 2 16 byte strings only. This cou...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/92755/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92755%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92755%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/92755/files
Reloadhttps://github.com/python/cpython/pull/92755/files
Reloadhttps://github.com/python/cpython/pull/92755/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zoobahttps://github.com/zooba
python:mainhttps://github.com/python/cpython/tree/main
jborean93:hyperv-socketshttps://github.com/jborean93/cpython/tree/hyperv-sockets
Conversation 78 https://github.com/python/cpython/pull/92755
Commits 7 https://github.com/python/cpython/pull/92755/commits
Checks 0 https://github.com/python/cpython/pull/92755/checks
Files changed https://github.com/python/cpython/pull/92755/files
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
gh-92658: Add Hyper-V socket support https://github.com/python/cpython/pull/92755/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/92755/files
47699cd Add Hyper-V socket support jborean93 May 13, 2022 https://github.com/python/cpython/pull/92755/commits/47699cdf5138fa9dbaf8718e14b6397145c6a40c
6c0d158 Use strings for addr information jborean93 May 19, 2022 https://github.com/python/cpython/pull/92755/commits/6c0d1583efedc067fa10eff26bcf56daa35e1140
931031f Fix doc problem jborean93 May 19, 2022 https://github.com/python/cpython/pull/92755/commits/931031f6416352b1663d54e52272110a80ae6124
f39731c Fixes for review jborean93 May 19, 2022 https://github.com/python/cpython/pull/92755/commits/f39731c3acb10e2655f07dd7c0ac431cb07cee4a
a0b06f3 Update Doc/library/socket.rst jborean93 May 19, 2022 https://github.com/python/cpython/pull/92755/commits/a0b06f3c6b2b95bf73af2e6228be14c312d66e20
d7af175 Add comment for AF_HYPERV def jborean93 May 23, 2022 https://github.com/python/cpython/pull/92755/commits/d7af175a53373ddb65e3689ca724f7ac34aabc50
025efb0 Better error handling for UUID conversions jborean93 May 24, 2022 https://github.com/python/cpython/pull/92755/commits/025efb066c2a195dedd74b99fd6ffca48626a625
Clear filters https://github.com/python/cpython/pull/92755/files
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
socket.rst https://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
test_socket.py https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
2022-05-13-00-57-18.gh-issue-92658.YdhFE2.rst https://github.com/python/cpython/pull/92755/files#diff-5f42af2fcb84513da6300a1aebb04563b7b19824508e978de2079f5709c52fcc
socketmodule.c https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
socketmodule.h https://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
_socket.vcxproj https://github.com/python/cpython/pull/92755/files#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c
Doc/library/socket.rsthttps://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/Doc/library/socket.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
https://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
https://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
https://github.com/python/cpython/pull/92755/files#diff-e9e93d6b76a8a1cf0825d557b12e7ce3e67081cad650063eee520b81fd651943
Lib/test/test_socket.pyhttps://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/Lib/test/test_socket.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
https://github.com/python/cpython/pull/92755/files#diff-ce79808e12f7a252c1747c23ba11810d4dc22ce0af4b9419bac647ad3a2a8389
Misc/NEWS.d/next/Core and Builtins/2022-05-13-00-57-18.gh-issue-92658.YdhFE2.rsthttps://github.com/python/cpython/pull/92755/files#diff-5f42af2fcb84513da6300a1aebb04563b7b19824508e978de2079f5709c52fcc
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/Misc/NEWS.d/next/Core%20and%20Builtins/2022-05-13-00-57-18.gh-issue-92658.YdhFE2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
Modules/socketmodule.chttps://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/Modules/socketmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Please reload this pagehttps://github.com/python/cpython/pull/92755/files
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
https://github.com/python/cpython/pull/92755/files#diff-412f0023cab7bc5669c6c1e710a6f37e7c3c387d299794b5fe82268a10223b29
Modules/socketmodule.hhttps://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/Modules/socketmodule.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
https://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
https://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
https://github.com/python/cpython/pull/92755/files#diff-95a6e2503e5a5648674268d9f6cd9c45a84a55e118b794c03bbc613390b91ccc
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L190
PCbuild/_socket.vcxprojhttps://github.com/python/cpython/pull/92755/files#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c
View file https://github.com/jborean93/cpython/blob/025efb066c2a195dedd74b99fd6ffca48626a625/PCbuild/_socket.vcxproj
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92755/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92755/files#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c
https://github.com/python/cpython/pull/92755/files#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.