| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4a5a8258-b1aa-e4ef-8f5d-2353eae4e20b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8C14:2728FC:A480F0:DCEAB8:69697E7C |
| html-safe-nonce | 06dc682bdc920d54edc1c24ff6263321df4a9756e07be9521efc4bd7e53b9a71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzE0OjI3MjhGQzpBNDgwRjA6RENFQUI4OjY5Njk3RTdDIiwidmlzaXRvcl9pZCI6IjM3NTc0OTE2MjAwMTM1MDYxNzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5b9f7fc4110df13dcd10019c425b32b5114fb0c03e1036b3bd76355319aa061f |
| hovercard-subject-tag | pull_request:931883161 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/92591/files |
| twitter:image | https://avatars.githubusercontent.com/u/1755071?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1755071?s=400&v=4 |
| og:image:alt | Closes #92592
https://discuss.python.org/t/expand-logging-filter-api-to-allow-returning-a-logrecord |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 48f380098b30acbb700b04f1724481ca10d574fc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/92591/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92591%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92591%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/92591/files |
| Reload | https://github.com/python/cpython/pull/92591/files |
| Reload | https://github.com/python/cpython/pull/92591/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| vsajip | https://github.com/vsajip |
| python:main | https://github.com/python/cpython/tree/main |
| adriangb:logging-filters | https://github.com/adriangb/cpython/tree/logging-filters |
|
Conversation
30
| https://github.com/python/cpython/pull/92591 |
|
Commits
18
| https://github.com/python/cpython/pull/92591/commits |
|
Checks
0
| https://github.com/python/cpython/pull/92591/checks |
|
Files changed
| https://github.com/python/cpython/pull/92591/files |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
|
gh-92592: Allow logging filters to return a LogRecord. (GH-92591)
| https://github.com/python/cpython/pull/92591/files#top |
|
Show all changes
18 commits
| https://github.com/python/cpython/pull/92591/files |
|
3aeeba6
allow logging filters to return a LogRecord
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/3aeeba6ed13eda4b895d8a531cf320768f5dc030 |
|
1e4d27f
edit docstring
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/1e4d27f779a15a3a48f50c025ae88c6bbbcff94f |
|
b526a35
remove unecessary __bool__ impl
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/b526a35ffe06124bed4f48044e4176506c29bade |
|
f1ea183
edit docs
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/f1ea183f6f98871687084440ede535a628681be8 |
|
19561d3
Add docs and blurb
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/19561d39e8f6b28f17851a33d700887b6a1e35d2 |
|
14e704d
Merge branch 'main' into logging-filters
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/14e704d6c5942e080c0942dda62324e1a6324153 |
|
4d34540
fix rst
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/4d34540e6a6a309929a59aac8d885599b04ca84a |
|
a69e76a
touch up wording
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/a69e76a474c59adc7c7b0c02d615df762a304fab |
|
67453f6
add test for filters on loggers
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/67453f60c38b433f14c8e06b170b7fdc6b5b905b |
|
b1e1084
push straggler change
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/b1e10848c981048383fee953efe679fa36035e04 |
|
f72c594
Merge branch 'main' into logging-filters
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/f72c5942c51feafdb4d2ba4f4427ea76e4a4dfac |
|
225329f
pr feedback
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/225329fcb4d192a07490177a078e753e2f32ac14 |
|
735d78a
Merge branch 'logging-filters' of https://github.com/adriangb/cpython…
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/735d78ae818b59532761e62cd81be39b52b44c39 |
|
5e54c77
Merge branch 'main' into logging-filters
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/5e54c7736a5f5781611a3afd0d8c55b33edd1ea6 |
|
f52e404
fix whitespace
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/f52e4041e99d3603bdb7e6ff8dffe8b19841fd7e |
|
46e2f7f
fix docs as per pr feedback
adriangb May 10, 2022
| https://github.com/python/cpython/pull/92591/commits/46e2f7fbeeae2c124980c58efb453836eaa214d5 |
|
7a0f470
Update logging-cookbook.rst
vsajip Jun 7, 2022
| https://github.com/python/cpython/pull/92591/commits/7a0f4708e3a396b35d222314aa83286041cc0972 |
|
643551d
Update logging.rst
vsajip Jun 7, 2022
| https://github.com/python/cpython/pull/92591/commits/643551d9c502c458caf3c99a0fae0cfc79be65cf |
|
Clear filters
| https://github.com/python/cpython/pull/92591/files |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
|
logging-cookbook.rst
| https://github.com/python/cpython/pull/92591/files#diff-974e901041b3942a74846cc2224844a352bcc4add8f9581efe5707cba44ff168 |
|
logging.rst
| https://github.com/python/cpython/pull/92591/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb |
|
__init__.py
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
test_logging.py
| https://github.com/python/cpython/pull/92591/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
|
2022-05-09-22-27-11.gh-issue-92591.V7RCk2.rst
| https://github.com/python/cpython/pull/92591/files#diff-bd8f4a57af43ac78b3fdbf4213bfe7fba3340e8a050cc9e10c4b8b28a763be00 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L513 |
| Doc/howto/logging-cookbook.rst | https://github.com/python/cpython/pull/92591/files#diff-974e901041b3942a74846cc2224844a352bcc4add8f9581efe5707cba44ff168 |
|
View file
| https://github.com/adriangb/cpython/blob/643551d9c502c458caf3c99a0fae0cfc79be65cf/Doc/howto/logging-cookbook.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/92591/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/92591/files#diff-974e901041b3942a74846cc2224844a352bcc4add8f9581efe5707cba44ff168 |
| Please reload this page | https://github.com/python/cpython/pull/92591/files |
|
| https://github.com/python/cpython/pull/92591/files#diff-974e901041b3942a74846cc2224844a352bcc4add8f9581efe5707cba44ff168 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L513 |
| Doc/library/logging.rst | https://github.com/python/cpython/pull/92591/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb |
|
View file
| https://github.com/adriangb/cpython/blob/643551d9c502c458caf3c99a0fae0cfc79be65cf/Doc/library/logging.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/92591/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/92591/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb |
|
| https://github.com/python/cpython/pull/92591/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb |
|
| https://github.com/python/cpython/pull/92591/files#diff-5a71f910c8cd3cfddb8eb3d3e938b3ff7deaf2ba57f71d91e4b9dbdc58d890fb |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L514 |
| Lib/logging/__init__.py | https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
View file
| https://github.com/adriangb/cpython/blob/643551d9c502c458caf3c99a0fae0cfc79be65cf/Lib/logging/__init__.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/92591/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/pull/92591/files#diff-1bf0ad6d121df3948853dafdd8e5406709fe0c3911b30e3cf2def41717455c98 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L515 |
| Lib/test/test_logging.py | https://github.com/python/cpython/pull/92591/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
|
View file
| https://github.com/adriangb/cpython/blob/643551d9c502c458caf3c99a0fae0cfc79be65cf/Lib/test/test_logging.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/92591/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/92591/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
|
| https://github.com/python/cpython/pull/92591/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f |
| Misc/NEWS.d/next/Library/2022-05-09-22-27-11.gh-issue-92591.V7RCk2.rst | https://github.com/python/cpython/pull/92591/files#diff-bd8f4a57af43ac78b3fdbf4213bfe7fba3340e8a050cc9e10c4b8b28a763be00 |
|
View file
| https://github.com/adriangb/cpython/blob/643551d9c502c458caf3c99a0fae0cfc79be65cf/Misc/NEWS.d/next/Library/2022-05-09-22-27-11.gh-issue-92591.V7RCk2.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/92591/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |