René's URL Explorer Experiment


Title: Restore default role check in `make check`. by ezio-melotti · Pull Request #92290 · python/cpython · GitHub

Open Graph Title: Restore default role check in `make check`. by ezio-melotti · Pull Request #92290 · python/cpython

X Title: Restore default role check in `make check`. by ezio-melotti · Pull Request #92290 · python/cpython

Description: This PR restores the check for the default role (see GH-92289) by doing two things. First, it sets the severity to 0 adding --severity=0, so that failing the default role check results in an error. This however also enables the long lines check, so it explicitly disabled it with --disable='line too long'. There are currently no other checks with severity=0. This PR only fixes Makefile. If this approach is sound, make.bat should be fixed too. Using --enable instead might be a better approach, once sphinx-contrib/sphinx-lint#27 lands. As a side note, it took me a bit to figure out that --disable= expected a message rather than the name of a checker. cc @JulienPalard

Open Graph Description: This PR restores the check for the default role (see GH-92289) by doing two things. First, it sets the severity to 0 adding --severity=0, so that failing the default role check results in an error....

X Description: This PR restores the check for the default role (see GH-92289) by doing two things. First, it sets the severity to 0 adding --severity=0, so that failing the default role check results in an error....

Opengraph URL: https://github.com/python/cpython/pull/92290

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3834a310-2d45-87df-c389-b3be49118fa0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC58:2FB293:CFFBA9:11DE039:6969EFDB
html-safe-nonce4cbe4459cd2da1e68aa10c944f529cb349b23abe27f7232046848e62fcd852dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzU4OjJGQjI5MzpDRkZCQTk6MTFERTAzOTo2OTY5RUZEQiIsInZpc2l0b3JfaWQiOiI1NTAxOTEwODcwOTU5NzE0MjY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd5ad87d2e49559a6f15f09ed6fa68ed39f96bfc6d77e9a198027ff174428f779
hovercard-subject-tagpull_request:927235451
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/92290/files
twitter:imagehttps://avatars.githubusercontent.com/u/25624924?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/25624924?s=400&v=4
og:image:altThis PR restores the check for the default role (see GH-92289) by doing two things. First, it sets the severity to 0 adding --severity=0, so that failing the default role check results in an error....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/92290/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92290%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92290%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/92290/files
Reloadhttps://github.com/python/cpython/pull/92290/files
Reloadhttps://github.com/python/cpython/pull/92290/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ezio-melottihttps://github.com/ezio-melotti
python:mainhttps://github.com/python/cpython/tree/main
ezio-melotti:make-check-default-rolehttps://github.com/ezio-melotti/cpython/tree/make-check-default-role
Conversation 24 https://github.com/python/cpython/pull/92290
Commits 11 https://github.com/python/cpython/pull/92290/commits
Checks 0 https://github.com/python/cpython/pull/92290/checks
Files changed https://github.com/python/cpython/pull/92290/files
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
Restore default role check in make check. https://github.com/python/cpython/pull/92290/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/92290/files
878ca9e Restore default role check in `make check`. ezio-melotti May 4, 2022 https://github.com/python/cpython/pull/92290/commits/878ca9e633fa279a14d4c837f32134527fc243bc
c8f769e Options first, then files. ezio-melotti May 4, 2022 https://github.com/python/cpython/pull/92290/commits/c8f769ea5dab5dc0a8551af16ba4223622cae75a
4bff0b6 Update `make.bat` too. ezio-melotti May 4, 2022 https://github.com/python/cpython/pull/92290/commits/4bff0b6c1223f3da325315229fa8bd287e0d9abb
57fdf91 Add a comment explaining the extra options. ezio-melotti May 4, 2022 https://github.com/python/cpython/pull/92290/commits/57fdf911f06b7a9c92f14045538923238343fc73
07f76fc No reason to ignore the README.rst. ezio-melotti May 4, 2022 https://github.com/python/cpython/pull/92290/commits/07f76fc4a63d7f288ba0c4d6b2515df23f8c0075
62b74f1 Enable default-role check in sphinx-lint. ezio-melotti May 14, 2022 https://github.com/python/cpython/pull/92290/commits/62b74f1f9802fd38c94fd1ed0fb464dedd8a5f64
c91e5e5 Update sphinx-lint default-role check. ezio-melotti May 14, 2022 https://github.com/python/cpython/pull/92290/commits/c91e5e5b4231df29b87f4d600792677d7c213854
08d05a4 Merge branch 'main' into make-check-default-role ezio-melotti May 14, 2022 https://github.com/python/cpython/pull/92290/commits/08d05a4ca1a773052a20f2712be77bbb600099d1
9e7d291 Fix use of the default role in the docs. ezio-melotti May 14, 2022 https://github.com/python/cpython/pull/92290/commits/9e7d291d7a1b751ffec8e380c4b8467f3187555f
4f35bda Update make.bat to check for the default role too. ezio-melotti May 14, 2022 https://github.com/python/cpython/pull/92290/commits/4f35bda107d847e8b325379dbec33078f801a794
4ca9ce9 Fix comment in make.bat. ezio-melotti May 15, 2022 https://github.com/python/cpython/pull/92290/commits/4ca9ce9a660c19fae279b3c0bc744b3dcfa77e9e
Clear filters https://github.com/python/cpython/pull/92290/files
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
Makefile https://github.com/python/cpython/pull/92290/files#diff-a5a6b8d06efdd9fcda4979c51e0abc76642899e6c9b4ffe238f5cdb7c5fd2bac
datetime.rst https://github.com/python/cpython/pull/92290/files#diff-591e6aa401ebcd90f71f28b517b3d4437ba293920787df9ed06e037af0b07175
enum.rst https://github.com/python/cpython/pull/92290/files#diff-4cebe6df5185cf2ebe9799ee15c1d84d0152462b1f79969d36e0e72abdc3335d
make.bat https://github.com/python/cpython/pull/92290/files#diff-26edeadb15822d44b734d046b9091684a93ebd05db8ec99c7e6fa3388eade9ec
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L102
Doc/Makefilehttps://github.com/python/cpython/pull/92290/files#diff-a5a6b8d06efdd9fcda4979c51e0abc76642899e6c9b4ffe238f5cdb7c5fd2bac
View file https://github.com/ezio-melotti/cpython/blob/4ca9ce9a660c19fae279b3c0bc744b3dcfa77e9e/Doc/Makefile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92290/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92290/files#diff-a5a6b8d06efdd9fcda4979c51e0abc76642899e6c9b4ffe238f5cdb7c5fd2bac
Please reload this pagehttps://github.com/python/cpython/pull/92290/files
https://github.com/python/cpython/pull/92290/files#diff-a5a6b8d06efdd9fcda4979c51e0abc76642899e6c9b4ffe238f5cdb7c5fd2bac
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L419
Doc/library/datetime.rsthttps://github.com/python/cpython/pull/92290/files#diff-591e6aa401ebcd90f71f28b517b3d4437ba293920787df9ed06e037af0b07175
View file https://github.com/ezio-melotti/cpython/blob/4ca9ce9a660c19fae279b3c0bc744b3dcfa77e9e/Doc/library/datetime.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92290/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92290/files#diff-591e6aa401ebcd90f71f28b517b3d4437ba293920787df9ed06e037af0b07175
https://github.com/python/cpython/pull/92290/files#diff-591e6aa401ebcd90f71f28b517b3d4437ba293920787df9ed06e037af0b07175
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L452
Doc/library/enum.rsthttps://github.com/python/cpython/pull/92290/files#diff-4cebe6df5185cf2ebe9799ee15c1d84d0152462b1f79969d36e0e72abdc3335d
View file https://github.com/ezio-melotti/cpython/blob/4ca9ce9a660c19fae279b3c0bc744b3dcfa77e9e/Doc/library/enum.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92290/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92290/files#diff-4cebe6df5185cf2ebe9799ee15c1d84d0152462b1f79969d36e0e72abdc3335d
https://github.com/python/cpython/pull/92290/files#diff-4cebe6df5185cf2ebe9799ee15c1d84d0152462b1f79969d36e0e72abdc3335d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L105
Doc/make.bathttps://github.com/python/cpython/pull/92290/files#diff-26edeadb15822d44b734d046b9091684a93ebd05db8ec99c7e6fa3388eade9ec
View file https://github.com/ezio-melotti/cpython/blob/4ca9ce9a660c19fae279b3c0bc744b3dcfa77e9e/Doc/make.bat
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92290/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92290/files#diff-26edeadb15822d44b734d046b9091684a93ebd05db8ec99c7e6fa3388eade9ec
https://github.com/python/cpython/pull/92290/files#diff-26edeadb15822d44b734d046b9091684a93ebd05db8ec99c7e6fa3388eade9ec
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.