René's URL Explorer Experiment


Title: gh-87390: Fix starred tuple equality and pickling by mrahtz · Pull Request #92249 · python/cpython · GitHub

Open Graph Title: gh-87390: Fix starred tuple equality and pickling by mrahtz · Pull Request #92249 · python/cpython

X Title: gh-87390: Fix starred tuple equality and pickling by mrahtz · Pull Request #92249 · python/cpython

Description: Hilariously, before this PR, it turned out that *tuple[int] was equal to tuple[int]. Fixing it, I realised that pickling was also broken: it didn't preserve gaobject.starred. This PR fixes both. I've tested for refleaks with python3 -m test -v test_genericalias -R 3:3, and it came back clean, so I think we're good. @Fidget-Spinner I guess you're the one most familiar with this code? :)

Open Graph Description: Hilariously, before this PR, it turned out that *tuple[int] was equal to tuple[int]. Fixing it, I realised that pickling was also broken: it didn't preserve gaobject.starred. This PR fixes both...

X Description: Hilariously, before this PR, it turned out that *tuple[int] was equal to tuple[int]. Fixing it, I realised that pickling was also broken: it didn't preserve gaobject.starred. This PR fixes ...

Opengraph URL: https://github.com/python/cpython/pull/92249

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5fbdc04e-eb9a-563e-588d-b16c185ad6fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB58:22DEEF:2C1B302:3B68B4C:696AF04D
html-safe-nonce0e06183d2e4a756864e5a32fe31208fb9446718cb52c2a8962ce0e3b2b5e5c11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjU4OjIyREVFRjoyQzFCMzAyOjNCNjhCNEM6Njk2QUYwNEQiLCJ2aXNpdG9yX2lkIjoiMjE3NTY5Mjc2NzMzNTQ3NzMyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac84f921e24d14b4acef9360dbd7697db691ae55f21bbf8b65841d8b295e6f816b
hovercard-subject-tagpull_request:926877229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/92249/files
twitter:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4431336?s=400&v=4
og:image:altHilariously, before this PR, it turned out that *tuple[int] was equal to tuple[int]. Fixing it, I realised that pickling was also broken: it didn't preserve gaobject.starred. This PR fixes both...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/92249/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92249%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F92249%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/92249/files
Reloadhttps://github.com/python/cpython/pull/92249/files
Reloadhttps://github.com/python/cpython/pull/92249/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mrahtzhttps://github.com/mrahtz
python:mainhttps://github.com/python/cpython/tree/main
mrahtz:unpacked-tuple-equalityhttps://github.com/mrahtz/cpython/tree/unpacked-tuple-equality
Conversation 19 https://github.com/python/cpython/pull/92249
Commits 5 https://github.com/python/cpython/pull/92249/commits
Checks 0 https://github.com/python/cpython/pull/92249/checks
Files changed https://github.com/python/cpython/pull/92249/files
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
gh-87390: Fix starred tuple equality and pickling https://github.com/python/cpython/pull/92249/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/92249/files
335747d Fix starred tuple equality and pickling mrahtz May 3, 2022 https://github.com/python/cpython/pull/92249/commits/335747dfcab82a0c2f3a2f5137cb24804d823a00
5d384b9 Update test comment mrahtz May 3, 2022 https://github.com/python/cpython/pull/92249/commits/5d384b9b0a53fde7d75b52ebec6e0b1815fcf3a8
4143451 PyTuple_Size → PyTuple_GET_SIZE mrahtz May 3, 2022 https://github.com/python/cpython/pull/92249/commits/4143451887f63839989e42106c0421b0caa2ba82
f33b28c Check type of unpackedness argument to GenericAlias mrahtz May 3, 2022 https://github.com/python/cpython/pull/92249/commits/f33b28cbbaf43beb6d9eb0cf72b276eb4f6e1009
57e18e8 📜🤖 Added by blurb_it. blurb-it[bot] May 3, 2022 https://github.com/python/cpython/pull/92249/commits/57e18e88d0580532c5693951b7a2cff0d58346c5
Clear filters https://github.com/python/cpython/pull/92249/files
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
test_genericalias.py https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
2022-05-03-20-49-53.gh-issue-87390.QKwANx.rst https://github.com/python/cpython/pull/92249/files#diff-5548802d32825238c64fc7598887519580c6aa48fd255df3c545fe0127ec2f04
genericaliasobject.c https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
Lib/test/test_genericalias.pyhttps://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
View file https://github.com/mrahtz/cpython/blob/57e18e88d0580532c5693951b7a2cff0d58346c5/Lib/test/test_genericalias.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
https://github.com/python/cpython/pull/92249/files#diff-8e29b27c5ead543d31b10d6fa2991d5640e6d60c36ac7b7aa873712c4fe2f944
Misc/NEWS.d/next/Core and Builtins/2022-05-03-20-49-53.gh-issue-87390.QKwANx.rsthttps://github.com/python/cpython/pull/92249/files#diff-5548802d32825238c64fc7598887519580c6aa48fd255df3c545fe0127ec2f04
View file https://github.com/mrahtz/cpython/blob/57e18e88d0580532c5693951b7a2cff0d58346c5/Misc/NEWS.d/next/Core%20and%20Builtins/2022-05-03-20-49-53.gh-issue-87390.QKwANx.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92249/{{ revealButtonHref }}
Objects/genericaliasobject.chttps://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
View file https://github.com/mrahtz/cpython/blob/57e18e88d0580532c5693951b7a2cff0d58346c5/Objects/genericaliasobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/92249/{{ revealButtonHref }}
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 4, 2022https://github.com/python/cpython/pull/92249/files#r864480775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/c-api/arg.html#c.Py_BuildValuehttps://docs.python.org/3/c-api/arg.html#c.Py_BuildValue
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 4, 2022https://github.com/python/cpython/pull/92249/files#r864482122
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/types.html#types.GenericAliashttps://docs.python.org/3/library/types.html#types.GenericAlias
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 4, 2022https://github.com/python/cpython/pull/92249/files#r864486772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/c-api/arg.html#c.PyArg_ParseTuplehttps://docs.python.org/3/c-api/arg.html#c.PyArg_ParseTuple
https://docs.python.org/3/c-api/arg.html#c.PyArg_UnpackTuplehttps://docs.python.org/3/c-api/arg.html#c.PyArg_UnpackTuple
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
kumaraditya303https://github.com/kumaraditya303
May 4, 2022https://github.com/python/cpython/pull/92249/files#r864697698
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
JelleZijlstrahttps://github.com/JelleZijlstra
May 3, 2022https://github.com/python/cpython/pull/92249/files#r864333586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 4, 2022https://github.com/python/cpython/pull/92249/files#r864487360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/92249/files
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/pull/92249/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.