René's URL Explorer Experiment


Title: bpo-34638: Store a weak reference to stream reader to break strong references loop by asvetlov · Pull Request #9201 · python/cpython · GitHub

Open Graph Title: bpo-34638: Store a weak reference to stream reader to break strong references loop by asvetlov · Pull Request #9201 · python/cpython

X Title: bpo-34638: Store a weak reference to stream reader to break strong references loop by asvetlov · Pull Request #9201 · python/cpython

Description: Breaking the strong reference loop between reader and protocol allows to detect and close the socket if the stream is deleted (garbage collected) without close() call. https://bugs.python.org/issue34638

Open Graph Description: Breaking the strong reference loop between reader and protocol allows to detect and close the socket if the stream is deleted (garbage collected) without close() call. https://bugs.python.org/issu...

X Description: Breaking the strong reference loop between reader and protocol allows to detect and close the socket if the stream is deleted (garbage collected) without close() call. https://bugs.python.org/issu...

Opengraph URL: https://github.com/python/cpython/pull/9201

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:55ba941e-3a83-86f6-49e0-b7f421c2e1d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA75A:680AB:96C42E:CADE54:6969BFFB
html-safe-nonce1be1647b7e7458f45d4d0bd0f00baa8d4e0ff8f20e891153d5a9f5699f7c1a02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzVBOjY4MEFCOjk2QzQyRTpDQURFNTQ6Njk2OUJGRkIiLCJ2aXNpdG9yX2lkIjoiOTA4MDg5NDA4Nzc4NTcyNTk0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ff79266969589f08287c85152feb542166e3908b27d9e81c3ee3cefb4914da6
hovercard-subject-tagpull_request:214798077
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9201/files
twitter:imagehttps://avatars.githubusercontent.com/u/356399?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/356399?s=400&v=4
og:image:altBreaking the strong reference loop between reader and protocol allows to detect and close the socket if the stream is deleted (garbage collected) without close() call. https://bugs.python.org/issu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9201/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9201%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9201%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9201/files
Reloadhttps://github.com/python/cpython/pull/9201/files
Reloadhttps://github.com/python/cpython/pull/9201/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9201/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/9201/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
asvetlov:weakrefhttps://github.com/asvetlov/cpython/tree/weakref
Conversation 6 https://github.com/python/cpython/pull/9201
Commits 10 https://github.com/python/cpython/pull/9201/commits
Checks 0 https://github.com/python/cpython/pull/9201/checks
Files changed https://github.com/python/cpython/pull/9201/files
Please reload this pagehttps://github.com/python/cpython/pull/9201/files
bpo-34638: Store a weak reference to stream reader to break strong references loop https://github.com/python/cpython/pull/9201/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/9201/files
5c87303 Store a weak reference to stream readerfor breaking strong references asvetlov Sep 11, 2018 https://github.com/python/cpython/pull/9201/commits/5c87303ae04a7f23ecad08e91491a638aa34c5c3
3ac4338 Work on asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/3ac43382276eeb768500a50147545a2a75449d28
465d9b3 Make tests passing asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/465d9b3e217ae2bcfb65f3baf9a34b9b8204ac8b
5447b8a Drop debug prints asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/5447b8a1d9e4d680c3eac93f9e9aa433330852dd
521ec5d Add NEWS entry asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/521ec5d7040edb4be5b05684a21bb737c2c24f51
a7b4ad1 Drop redundant assertion asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/a7b4ad14924e7515813db2097bf676026388d52a
806b5c2 _reject_transport -> _reject_connection asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/806b5c21aaa5f5a2546d1edc7beda785ab984293
119bfab Add a test for destroying a reader befor connection_made() call asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/119bfab7ddcde21b8c239ee355451a25ec4853aa
ced1bd2 Fix notes asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/ced1bd2720c30f44c08678f52db11096ff324d92
1670250 Fix a comment asvetlov Sep 12, 2018 https://github.com/python/cpython/pull/9201/commits/1670250aa1e04b046be8d63a84af92cdb2c713b6
Clear filters https://github.com/python/cpython/pull/9201/files
Please reload this pagehttps://github.com/python/cpython/pull/9201/files
Please reload this pagehttps://github.com/python/cpython/pull/9201/files
streams.py https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
subprocess.py https://github.com/python/cpython/pull/9201/files#diff-84f561d3c1c4ea1724bb6fb3b3ba10b2a3c81c011014432e50ba34fa81845915
test_streams.py https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
2018-09-12-10-33-44.bpo-34638.xaeZX5.rst https://github.com/python/cpython/pull/9201/files#diff-9f069508a9c5e671a7a5c28fce4adff42effc902568f6425cbcb045b61933bbb
Lib/asyncio/streams.pyhttps://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
View file https://github.com/asvetlov/cpython/blob/1670250aa1e04b046be8d63a84af92cdb2c713b6/Lib/asyncio/streams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9201/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
https://github.com/python/cpython/pull/9201/files#diff-986bdbc8d67d23185aefa287c95943fc9502363bcb89be876ab4626c5e94e3dc
Lib/asyncio/subprocess.pyhttps://github.com/python/cpython/pull/9201/files#diff-84f561d3c1c4ea1724bb6fb3b3ba10b2a3c81c011014432e50ba34fa81845915
View file https://github.com/asvetlov/cpython/blob/1670250aa1e04b046be8d63a84af92cdb2c713b6/Lib/asyncio/subprocess.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9201/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9201/files#diff-84f561d3c1c4ea1724bb6fb3b3ba10b2a3c81c011014432e50ba34fa81845915
https://github.com/python/cpython/pull/9201/files#diff-84f561d3c1c4ea1724bb6fb3b3ba10b2a3c81c011014432e50ba34fa81845915
Lib/test/test_asyncio/test_streams.pyhttps://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
View file https://github.com/asvetlov/cpython/blob/1670250aa1e04b046be8d63a84af92cdb2c713b6/Lib/test/test_asyncio/test_streams.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9201/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
https://github.com/python/cpython/pull/9201/files#diff-98d13306cbff0bcbdcefd8354d3447df35649194d92b5e8ad20f14f0cf880863
Misc/NEWS.d/next/Library/2018-09-12-10-33-44.bpo-34638.xaeZX5.rsthttps://github.com/python/cpython/pull/9201/files#diff-9f069508a9c5e671a7a5c28fce4adff42effc902568f6425cbcb045b61933bbb
View file https://github.com/asvetlov/cpython/blob/1670250aa1e04b046be8d63a84af92cdb2c713b6/Misc/NEWS.d/next/Library/2018-09-12-10-33-44.bpo-34638.xaeZX5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9201/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.