René's URL Explorer Experiment


Title: [3.6] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9149 · python/cpython · GitHub

Open Graph Title: [3.6] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9149 · python/cpython

X Title: [3.6] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9149 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest primarily ...

X Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest pr...

Mail addresses
greg@krypto.org

Opengraph URL: https://github.com/python/cpython/pull/9149

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:caa49e20-7f18-4639-d668-be88d2682bed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97D4:27E47B:1A8308:22D42D:6A4D86E2
html-safe-nonce8672fa8b95f06e8e0913dcd48eca8263befdf6b1232ab983740388920323a5ab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0Q0OjI3RTQ3QjoxQTgzMDg6MjJENDJEOjZBNEQ4NkUyIiwidmlzaXRvcl9pZCI6IjEzNTYzMzc1MDk3ODU1MDM0NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7037513697e17bdee4e041e6908f35e0efb40c11818b48d9543a36d8d7a13471
hovercard-subject-tagpull_request:214482870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9149/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bab772017970842d9f57bf2ae6d99514a4595ea0e7759149ac799f0495af0715/python/cpython/pull/9149
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bab772017970842d9f57bf2ae6d99514a4595ea0e7759149ac799f0495af0715/python/cpython/pull/9149
og:image:altWhen subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest primarily ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9149#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9149
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9149
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9149
Reloadhttps://github.com/python/cpython/pull/9149
Reloadhttps://github.com/python/cpython/pull/9149
Please reload this pagehttps://github.com/python/cpython/pull/9149
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9149
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:3.6https://github.com/python/cpython/tree/3.6
miss-islington:backport-ce34410-3.6https://github.com/miss-islington/cpython/tree/backport-ce34410-3.6
Conversationhttps://github.com/python/cpython/pull/9149
Commits1 (1)https://github.com/python/cpython/pull/9149/commits
Checkshttps://github.com/python/cpython/pull/9149/checks
Files changedhttps://github.com/python/cpython/pull/9149/files
[3.6] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242)https://github.com/python/cpython/pull/9149#top
gpsheadhttps://github.com/gpshead
python:3.6https://github.com/python/cpython/tree/3.6
miss-islington:backport-ce34410-3.6https://github.com/miss-islington/cpython/tree/backport-ce34410-3.6
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/9149#issue-358845424
Please reload this pagehttps://github.com/python/cpython/pull/9149
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://bugs.python.org/issue32270https://bugs.python.org/issue32270
Please reload this pagehttps://github.com/python/cpython/pull/9149
https://github.com/gpshead
https://github.com/miss-islington
bpo-32270: Don't close stdin/out/err in pass_fds (https://github.com/python/cpython/pull/9149/commits/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
pythonGH-6242https://github.com/python/cpython/pull/6242
)https://github.com/python/cpython/pull/9149/commits/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
3774cd5https://github.com/python/cpython/pull/9149/commits/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/miss-islington/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837361386
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837361388
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 11, 2018 https://github.com/python/cpython/pull/9149#ref-pullrequest-308378310
bpo-32270: Don't close stdin/out/err in pass_fds #6242 https://github.com/python/cpython/pull/6242
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837361428
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 11, 2018 https://github.com/python/cpython/pull/9149#pullrequestreview-154016543
View reviewed changes https://github.com/python/cpython/pull/9149/files/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837363091
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/9149#issuecomment-420118767
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/9149
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/9149#issuecomment-420118881
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/9149
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 11, 2018https://github.com/python/cpython/pull/9149#issuecomment-420156443
Please reload this pagehttps://github.com/python/cpython/pull/9149
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
2173bb8https://github.com/python/cpython/commit/2173bb818c6c726d831b106ed0d3fad7825905dc
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837662598
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 11, 2018https://github.com/python/cpython/pull/9149#event-1837662636
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
September 11, 2018 06:00https://github.com/python/cpython/pull/9149#event-1837662683
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9149
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/9149/files/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/9149
https://github.com/miss-islington
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.