René's URL Explorer Experiment


Title: [3.7] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9148 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9148 · python/cpython

X Title: [3.7] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242) by miss-islington · Pull Request #9148 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest primarily ...

X Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest pr...

Mail addresses
greg@krypto.org

Opengraph URL: https://github.com/python/cpython/pull/9148

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:66ca5ceb-6c14-5049-f556-07d824fd24f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CBE:7AB5B:1CA726:267C88:6A4D86D2
html-safe-nonce3730994b0877f2a1e0dbed7bcc4331a60a5ece7865d1257ff6634d09a363cd47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0JFOjdBQjVCOjFDQTcyNjoyNjdDODg6NkE0RDg2RDIiLCJ2aXNpdG9yX2lkIjoiMzM2OTgxMTY1NDA5NDk4MDgxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4893d8e2a04c190fdfed77862ce2b5085f3c5f165869c7f0112938b9ef5de51e
hovercard-subject-tagpull_request:214482845
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9148/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3df14b237b650c3ebbb2cf6af78fb0506ffbc306e76ecd910141d194432b79da/python/cpython/pull/9148
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3df14b237b650c3ebbb2cf6af78fb0506ffbc306e76ecd910141d194432b79da/python/cpython/pull/9148
og:image:altWhen subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close the original fds after dup'ing them. This implementation and unittest primarily ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebffd5484f01713a661b03469b77678f72b6574ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9148#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9148
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9148
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9148
Reloadhttps://github.com/python/cpython/pull/9148
Reloadhttps://github.com/python/cpython/pull/9148
Please reload this pagehttps://github.com/python/cpython/pull/9148
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9148
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-ce34410-3.7https://github.com/miss-islington/cpython/tree/backport-ce34410-3.7
Conversationhttps://github.com/python/cpython/pull/9148
Commits1 (1)https://github.com/python/cpython/pull/9148/commits
Checkshttps://github.com/python/cpython/pull/9148/checks
Files changedhttps://github.com/python/cpython/pull/9148/files
[3.7] bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242)https://github.com/python/cpython/pull/9148#top
gpsheadhttps://github.com/gpshead
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-ce34410-3.7https://github.com/miss-islington/cpython/tree/backport-ce34410-3.7
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/9148#issue-358845394
Please reload this pagehttps://github.com/python/cpython/pull/9148
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://bugs.python.org/issue32270https://bugs.python.org/issue32270
Please reload this pagehttps://github.com/python/cpython/pull/9148
https://github.com/gpshead
https://github.com/miss-islington
bpo-32270: Don't close stdin/out/err in pass_fds (https://github.com/python/cpython/pull/9148/commits/0be3bb22234ede46f374e312581b83a425c35fa9
pythonGH-6242https://github.com/python/cpython/pull/6242
)https://github.com/python/cpython/pull/9148/commits/0be3bb22234ede46f374e312581b83a425c35fa9
0be3bb2https://github.com/python/cpython/pull/9148/commits/0be3bb22234ede46f374e312581b83a425c35fa9
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/miss-islington/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/f3d00ae3be27ede2fc834d9d2b0028c9ad39f492/.github/CODEOWNERS#L41
September 11, 2018 00:46https://github.com/python/cpython/pull/9148#event-1837361204
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837361237
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837361242
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 11, 2018 https://github.com/python/cpython/pull/9148#ref-pullrequest-308378310
bpo-32270: Don't close stdin/out/err in pass_fds #6242 https://github.com/python/cpython/pull/6242
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837361268
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 11, 2018 https://github.com/python/cpython/pull/9148#pullrequestreview-154016497
View reviewed changes https://github.com/python/cpython/pull/9148/files/0be3bb22234ede46f374e312581b83a425c35fa9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837362814
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/9148#issuecomment-420118770
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/9148
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
9c4a63fhttps://github.com/python/cpython/commit/9c4a63fc17efea31ad41f90d28825be37469e0e2
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837579646
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 11, 2018https://github.com/python/cpython/pull/9148#event-1837579670
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
September 11, 2018 04:36https://github.com/python/cpython/pull/9148#event-1837579693
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9148
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/9148/files/0be3bb22234ede46f374e312581b83a425c35fa9
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/9148
https://github.com/miss-islington
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.