| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2e23233-2203-10e0-1a1a-76e57d71373d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAAE:1198D4:411BC:552D7:696B57C6 |
| html-safe-nonce | 90d8d52870323a6b0af44e590e336672be4950e0c2d9bf3454a907d7489e243c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUFFOjExOThENDo0MTFCQzo1NTJENzo2OTZCNTdDNiIsInZpc2l0b3JfaWQiOiIzOTQxNDk4MzgyNzMwMzUyNTgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4862e3b17352adf6113863654c183525dc37fc4fec2c39bc13b354dcfb166445 |
| hovercard-subject-tag | pull_request:213862554 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9093/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/04fd91f3d49f5d35eb9c69293f6be9dcad2687fd76874c58ca2449f03e3bd3bf/python/cpython/pull/9093 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/04fd91f3d49f5d35eb9c69293f6be9dcad2687fd76874c58ca2449f03e3bd3bf/python/cpython/pull/9093 |
| og:image:alt | Many type object initializations labeled a field tp_size in the comment, but the name of that field is tp_basicsize. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petere |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/9093#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9093 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9093 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/9093 |
| Reload | https://github.com/python/cpython/pull/9093 |
| Reload | https://github.com/python/cpython/pull/9093 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/9093#issue-comment-box |
| benjaminp | https://github.com/benjaminp |
| python:master | https://github.com/python/cpython/tree/master |
| petere:fix-tp_size | https://github.com/petere/cpython/tree/fix-tp_size |
|
Fix misleading mentions of tp_size in comments
| https://github.com/python/cpython/pull/9093#top |
| benjaminp | https://github.com/benjaminp |
| python:master | https://github.com/python/cpython/tree/master |
| petere:fix-tp_size | https://github.com/petere/cpython/tree/fix-tp_size |
|
Conversation
7
| https://github.com/python/cpython/pull/9093 |
|
Commits
1
| https://github.com/python/cpython/pull/9093/commits |
|
Checks
0
| https://github.com/python/cpython/pull/9093/checks |
|
Files changed
| https://github.com/python/cpython/pull/9093/files |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/petere |
| petere | https://github.com/petere |
| Sep 7, 2018 | https://github.com/python/cpython/pull/9093#issue-357982137 |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
|
| https://github.com/petere |
| Fix misleading mentions of tp_size in comments | https://github.com/python/cpython/pull/9093/commits/c9044330088e41fb2e3481cb845286b083e39b3b |
| c904433 | https://github.com/python/cpython/pull/9093/commits/c9044330088e41fb2e3481cb845286b083e39b3b |
| https://github.com/petere |
| petere | https://github.com/petere |
| rhettinger | https://github.com/rhettinger |
| code owner | https://github.com/python/cpython/blob/f9925d86c9d7a44b612576131cd5b84cfee36c4e/.github/CODEOWNERS#L54 |
| September 7, 2018 09:05 | https://github.com/python/cpython/pull/9093#event-1832359971 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Sep 7, 2018 | https://github.com/python/cpython/pull/9093#event-1832360105 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 7, 2018 | https://github.com/python/cpython/pull/9093#event-1832360111 |
| https://github.com/auvipy |
| auvipy | https://github.com/auvipy |
|
Sep 10, 2018
| https://github.com/python/cpython/pull/9093#pullrequestreview-153634705 |
|
View reviewed changes
| https://github.com/python/cpython/pull/9093/files/c9044330088e41fb2e3481cb845286b083e39b3b |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1835120837 |
| https://github.com/benjaminp |
| benjaminp | https://github.com/benjaminp |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836502182 |
| https://github.com/benjaminp |
| benjaminp | https://github.com/benjaminp |
| 0e0bc4e | https://github.com/python/cpython/commit/0e0bc4e221f592f305d335faf5f8046484eb9238 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836505445 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981080 |
| @petere | https://github.com/petere |
| @benjaminp | https://github.com/benjaminp |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836505518 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981115 |
| @petere | https://github.com/petere |
| @benjaminp | https://github.com/benjaminp |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| benjaminp | https://github.com/benjaminp |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836505712 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981149 |
| @petere | https://github.com/petere |
| @benjaminp | https://github.com/benjaminp |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981178 |
| @petere | https://github.com/petere |
| @benjaminp | https://github.com/benjaminp |
| cherry_picker | https://pypi.org/project/cherry-picker/ |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| benjaminp | https://github.com/benjaminp |
|
Sep 10, 2018
| https://github.com/python/cpython/pull/9093#ref-commit-b6a6008 |
|
| https://github.com/petere |
|
| https://github.com/benjaminp |
| [3.7] Fix misleading mentions of tp_size in comments ( | https://github.com/python/cpython/commit/b6a600854cc3f29cbd5459562d8f8a053ce3248c |
| GH-9093 | https://github.com/python/cpython/pull/9093 |
| ) | https://github.com/python/cpython/commit/b6a600854cc3f29cbd5459562d8f8a053ce3248c |
| b6a6008 | https://github.com/python/cpython/commit/b6a600854cc3f29cbd5459562d8f8a053ce3248c |
| 0e0bc4e | https://github.com/python/cpython/commit/0e0bc4e221f592f305d335faf5f8046484eb9238 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981506 |
| GH-9136 | https://github.com/python/cpython/pull/9136 |
| 3.7 branch | https://github.com/python/cpython/tree/3.7 |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836508717 |
| benjaminp | https://github.com/benjaminp |
|
Sep 10, 2018
| https://github.com/python/cpython/pull/9093#ref-commit-444b1cd |
|
| https://github.com/petere |
|
| https://github.com/benjaminp |
| [3.6] Fix misleading mentions of tp_size in comments ( | https://github.com/python/cpython/commit/444b1cd4bcd23631c9bfda18fb519792289f1666 |
| GH-9093 | https://github.com/python/cpython/pull/9093 |
| ) | https://github.com/python/cpython/commit/444b1cd4bcd23631c9bfda18fb519792289f1666 |
| 444b1cd | https://github.com/python/cpython/commit/444b1cd4bcd23631c9bfda18fb519792289f1666 |
| 0e0bc4e | https://github.com/python/cpython/commit/0e0bc4e221f592f305d335faf5f8046484eb9238 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419981802 |
| GH-9137 | https://github.com/python/cpython/pull/9137 |
| 3.6 branch | https://github.com/python/cpython/tree/3.6 |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.6
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836511028 |
| benjaminp | https://github.com/benjaminp |
|
Sep 10, 2018
| https://github.com/python/cpython/pull/9093#ref-commit-70013bd |
|
| https://github.com/petere |
|
| https://github.com/benjaminp |
| [2.7] Fix misleading mentions of tp_size in comments ( | https://github.com/python/cpython/commit/70013bd58ca471bcb67fca60c61fdce9cab8a837 |
| GH-9093 | https://github.com/python/cpython/pull/9093 |
| ) | https://github.com/python/cpython/commit/70013bd58ca471bcb67fca60c61fdce9cab8a837 |
| 70013bd | https://github.com/python/cpython/commit/70013bd58ca471bcb67fca60c61fdce9cab8a837 |
| 0e0bc4e | https://github.com/python/cpython/commit/0e0bc4e221f592f305d335faf5f8046484eb9238 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#issuecomment-419984088 |
| GH-9138 | https://github.com/python/cpython/pull/9138 |
| 2.7 branch | https://github.com/python/cpython/tree/2.7 |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 2.7
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%202.7%22 |
| Sep 10, 2018 | https://github.com/python/cpython/pull/9093#event-1836527767 |
| https://github.com/jdemeyer |
| jdemeyer | https://github.com/jdemeyer |
|
May 28, 2019
| https://github.com/python/cpython/pull/9093#ref-pullrequest-446679100 |
|
bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_async
#13464
| https://github.com/python/cpython/pull/13464 |
| https://github.com/petere |
| petere | https://github.com/petere |
| February 12, 2020 10:28 | https://github.com/python/cpython/pull/9093#event-3030215949 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9093 |
|
| https://github.com/rhettinger |
|
rhettinger
| https://github.com/rhettinger |
|
| https://github.com/auvipy |
|
auvipy
| https://github.com/auvipy |
|
| https://github.com/python/cpython/pull/9093/files/c9044330088e41fb2e3481cb845286b083e39b3b |
|
| https://github.com/benjaminp |
|
benjaminp
| https://github.com/benjaminp |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/9093 |
|
| https://github.com/petere |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/auvipy |
|
| https://github.com/benjaminp |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |