René's URL Explorer Experiment


Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython · GitHub

Open Graph Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython

X Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython

Description: import.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protections, but PyImport_GetModule does not. https://bugs.python.org/issue34572

Open Graph Description: import.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...

X Description: import.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...

Opengraph URL: https://github.com/python/cpython/pull/9047

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cc6509f9-ce74-3f2c-66e2-cd59397963da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC096:6435C:830C0BD:B6A3E65:6A5046D2
html-safe-noncef704ba40886902d75cfa9ea5e82988075923f2322325c9c8e82fe2158a255a42
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDk2OjY0MzVDOjgzMEMwQkQ6QjZBM0U2NTo2QTUwNDZEMiIsInZpc2l0b3JfaWQiOiI1MjQzODQ0MTc4OTkxOTI0OTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace954980d2faf50989373ea990184f315c5851e1a44f1a02c23f27a3073df9d67
hovercard-subject-tagpull_request:212787169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/9047/files
twitter:imagehttps://avatars.githubusercontent.com/u/1707852?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1707852?s=400&v=4
og:image:altimport.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9047/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9047%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9047%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9047/files
Reloadhttps://github.com/python/cpython/pull/9047/files
Reloadhttps://github.com/python/cpython/pull/9047/files
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
tjb900:pickle_import_race_fixhttps://github.com/tjb900/cpython/tree/pickle_import_race_fix
Conversation 43 https://github.com/python/cpython/pull/9047
Commits 7 https://github.com/python/cpython/pull/9047/commits
Checks 0 https://github.com/python/cpython/pull/9047/checks
Files changed 3 https://github.com/python/cpython/pull/9047/files
bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules https://github.com/python/cpython/pull/9047/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/9047/files
e47c5e1 change unpickling to use import rather than retrieving from sys.modules tjb900 Sep 5, 2018 https://github.com/python/cpython/pull/9047/commits/e47c5e1924f9af79af7804083d9167f4109803c7
595bdbb pep7 fixup tjb900 Feb 7, 2019 https://github.com/python/cpython/pull/9047/commits/595bdbb673e9c80fa844754b4b868816ef534b61
f72802a add unit test for bpo-34572 tjb900 Feb 7, 2019 https://github.com/python/cpython/pull/9047/commits/f72802acfd2049285a7d2c1ce446f4991cdb8395
fa5dbeb add comment to explain why GetModule wasn't used tjb900 Feb 8, 2019 https://github.com/python/cpython/pull/9047/commits/fa5dbebf4d7c0654a1503a8eb9d4fd2e6b69c111
64a7f95 rewrite test case to avoid sleeps tjb900 Feb 8, 2019 https://github.com/python/cpython/pull/9047/commits/64a7f954c56d5afc00ea1d8008fb78ff65ddafa1
202d4e2 move test to AbstractUnpickleTester tjb900 Feb 8, 2019 https://github.com/python/cpython/pull/9047/commits/202d4e2a11f857801356ba181b6e6179a6068016
a0425ef better assertion tjb900 Feb 13, 2019 https://github.com/python/cpython/pull/9047/commits/a0425ef01015ebf7208f9e062330825ba3587f30
Clear filters https://github.com/python/cpython/pull/9047/files
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
pickletester.py https://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
2018-09-05-03-02-32.bpo-34572.ayisd2.rst https://github.com/python/cpython/pull/9047/files#diff-0d25be4ce3194e70e6a96de402d00b568eb7ccdc3aa3f0dc0720044bbab7fd74
_pickle.c https://github.com/python/cpython/pull/9047/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Lib/test/pickletester.pyhttps://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
View file https://github.com/tjb900/cpython/blob/a0425ef01015ebf7208f9e062330825ba3587f30/Lib/test/pickletester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9047/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
https://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
https://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
pitrouhttps://github.com/pitrou
Feb 8, 2019https://github.com/python/cpython/pull/9047/files#r255157935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
https://github.com/python/cpython/pull/9047/files#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
Misc/NEWS.d/next/Library/2018-09-05-03-02-32.bpo-34572.ayisd2.rsthttps://github.com/python/cpython/pull/9047/files#diff-0d25be4ce3194e70e6a96de402d00b568eb7ccdc3aa3f0dc0720044bbab7fd74
View file https://github.com/tjb900/cpython/blob/a0425ef01015ebf7208f9e062330825ba3587f30/Misc/NEWS.d/next/Library/2018-09-05-03-02-32.bpo-34572.ayisd2.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9047/{{ revealButtonHref }}
Modules/_pickle.chttps://github.com/python/cpython/pull/9047/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
View file https://github.com/tjb900/cpython/blob/a0425ef01015ebf7208f9e062330825ba3587f30/Modules/_pickle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/9047/{{ revealButtonHref }}
https://github.com/python/cpython/pull/9047/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047/files#r254686262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047/files#r254736153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pierreglaserhttps://github.com/pierreglaser
@ogriselhttps://github.com/ogrisel
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
pierreglaserhttps://github.com/pierreglaser
Feb 7, 2019https://github.com/python/cpython/pull/9047/files#r254757305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
Please reload this pagehttps://github.com/python/cpython/pull/9047/files
https://github.com/python/cpython/pull/9047/files#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.