René's URL Explorer Experiment


Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython · GitHub

Open Graph Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython

X Title: bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules by tjb900 · Pull Request #9047 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: import.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...

X Description: import.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...

Opengraph URL: https://github.com/python/cpython/pull/9047

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2f20edf7-7844-3486-8d88-22896f07838f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC58:7E3D2:538844B:762B252:6A4FE7BD
html-safe-nonce5fd25b68ac5422f1e4532717e98997005c27349ffc7e969f21d4e66393508d1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzU4OjdFM0QyOjUzODg0NEI6NzYyQjI1Mjo2QTRGRTdCRCIsInZpc2l0b3JfaWQiOiIxNzA1NjAyNDU1MDAwMDQ5NTk3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca7663c20cd3256c0126d50e8a2d3420c0cca4a54d902de1955cf55dde8973205
hovercard-subject-tagpull_request:212787169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/9047/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a43ff7e77aad2445be2b33184a7e44eb5bd9027a39368a2d0213554b0225ded/python/cpython/pull/9047
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a43ff7e77aad2445be2b33184a7e44eb5bd9027a39368a2d0213554b0225ded/python/cpython/pull/9047
og:image:altimport.c seems to contain a lot of protection to ensure that a partially-initialised module is not returned from import when in a multi-threaded environment. PyImport_Import enjoys these protectio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametjb900
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/9047#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9047
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9047
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/9047
Reloadhttps://github.com/python/cpython/pull/9047
Reloadhttps://github.com/python/cpython/pull/9047
Please reload this pagehttps://github.com/python/cpython/pull/9047
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/9047
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
tjb900:pickle_import_race_fixhttps://github.com/tjb900/cpython/tree/pickle_import_race_fix
Conversationhttps://github.com/python/cpython/pull/9047
Commits7 (7)https://github.com/python/cpython/pull/9047/commits
Checkshttps://github.com/python/cpython/pull/9047/checks
Files changedhttps://github.com/python/cpython/pull/9047/files
bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.moduleshttps://github.com/python/cpython/pull/9047#top
pitrouhttps://github.com/pitrou
python:masterhttps://github.com/python/cpython/tree/master
tjb900:pickle_import_race_fixhttps://github.com/tjb900/cpython/tree/pickle_import_race_fix
https://github.com/tjb900
tjb900https://github.com/tjb900
Sep 3, 2018https://github.com/python/cpython/pull/9047#issue-356555255
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://bugs.python.org/issue34572https://bugs.python.org/issue34572
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Sep 3, 2018https://github.com/python/cpython/pull/9047#issuecomment-418153109
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
check yourselfhttps://check-python-cla.herokuapp.com/
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Sep 3, 2018https://github.com/python/cpython/pull/9047#event-1823805509
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 3, 2018https://github.com/python/cpython/pull/9047#event-1823805523
https://github.com/tjb900
change unpickling to use import rather than retrieving from sys.moduleshttps://github.com/python/cpython/pull/9047/commits/e47c5e1924f9af79af7804083d9167f4109803c7
e47c5e1https://github.com/python/cpython/pull/9047/commits/e47c5e1924f9af79af7804083d9167f4109803c7
https://github.com/tjb900
tjb900https://github.com/tjb900
force-pushedhttps://github.com/python/cpython/compare/c71f99fc6d0b888e4297dccddb866cd03a88e8a9..e47c5e1924f9af79af7804083d9167f4109803c7
c71f99fhttps://github.com/python/cpython/commit/c71f99fc6d0b888e4297dccddb866cd03a88e8a9
e47c5e1https://github.com/python/cpython/commit/e47c5e1924f9af79af7804083d9167f4109803c7
Compare https://github.com/python/cpython/compare/c71f99fc6d0b888e4297dccddb866cd03a88e8a9..e47c5e1924f9af79af7804083d9167f4109803c7
September 5, 2018 03:06https://github.com/python/cpython/pull/9047#event-1826769981
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Sep 5, 2018https://github.com/python/cpython/pull/9047#event-1826770010
https://github.com/tjb900
tjb900https://github.com/tjb900
Jan 7, 2019https://github.com/python/cpython/pull/9047#issuecomment-451801210
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 5, 2019https://github.com/python/cpython/pull/9047#issuecomment-460663372
@tjb900https://github.com/tjb900
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 5, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-200112671
View reviewed changes https://github.com/python/cpython/pull/9047/files/e47c5e1924f9af79af7804083d9167f4109803c7
Modules/_pickle.chttps://github.com/python/cpython/pull/9047/files/e47c5e1924f9af79af7804083d9167f4109803c7#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
pgansslehttps://github.com/pganssle
Feb 5, 2019https://github.com/python/cpython/pull/9047#discussion_r253894231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
tjb900https://github.com/tjb900
Feb 5, 2019https://github.com/python/cpython/pull/9047#discussion_r253896672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 5, 2019https://github.com/python/cpython/pull/9047#discussion_r253898461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
tjb900https://github.com/tjb900
Feb 5, 2019https://github.com/python/cpython/pull/9047#discussion_r253903627
Please reload this pagehttps://github.com/python/cpython/pull/9047
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cpython/Python/import.chttps://github.com/python/cpython/blob/cd90f6a3692e0f7ef0a13aae651e19a08d1f9b31/Python/import.c#L145
cd90f6ahttps://github.com/python/cpython/commit/cd90f6a3692e0f7ef0a13aae651e19a08d1f9b31
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 5, 2019https://github.com/python/cpython/pull/9047#discussion_r253980899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 6, 2019https://github.com/python/cpython/pull/9047#discussion_r254266136
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
PEP 7https://www.python.org/dev/peps/pep-0007/
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/tjb900
tjb900https://github.com/tjb900
Feb 5, 2019https://github.com/python/cpython/pull/9047#issuecomment-460666081
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 5, 2019https://github.com/python/cpython/pull/9047#issuecomment-460743051
Please reload this pagehttps://github.com/python/cpython/pull/9047
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
#3593https://github.com/python/cpython/pull/3593
bpo-28411https://bugs.python.org/issue28411
https://bugs.python.org/issue2841https://bugs.python.org/issue28411https://bugs.python.org/issue2841https://bugs.python.org/issue28411
@ncoghlanhttps://github.com/ncoghlan
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/tjb900
tjb900https://github.com/tjb900
Feb 6, 2019https://github.com/python/cpython/pull/9047#issuecomment-460881513
#3593https://github.com/python/cpython/pull/3593
cpython/Modules/_pickle.chttps://github.com/python/cpython/blob/ca2d610dba5711823999c4751897160f138a7811/Modules/_pickle.c#L4160
ca2d610https://github.com/python/cpython/commit/ca2d610dba5711823999c4751897160f138a7811
#2646https://github.com/python/cpython/pull/2646
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Feb 6, 2019https://github.com/python/cpython/pull/9047#issuecomment-460985748
https://bugs.python.org/issue9260https://bugs.python.org/issue9260
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 6, 2019https://github.com/python/cpython/pull/9047#issuecomment-461021076
Please reload this pagehttps://github.com/python/cpython/pull/9047
tjb900https://github.com/tjb900
February 7, 2019 09:08https://github.com/python/cpython/pull/9047#commits-pushed-595bdbb
https://github.com/tjb900
pep7 fixuphttps://github.com/python/cpython/pull/9047/commits/595bdbb673e9c80fa844754b4b868816ef534b61
595bdbbhttps://github.com/python/cpython/pull/9047/commits/595bdbb673e9c80fa844754b4b868816ef534b61
https://github.com/tjb900
add unit test for bpo-34572https://github.com/python/cpython/pull/9047/commits/f72802acfd2049285a7d2c1ce446f4991cdb8395
f72802ahttps://github.com/python/cpython/pull/9047/commits/f72802acfd2049285a7d2c1ce446f4991cdb8395
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 7, 2019https://github.com/python/cpython/pull/9047#issuecomment-461418706
Please reload this pagehttps://github.com/python/cpython/pull/9047
@tjb900https://github.com/tjb900
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
pablogsalhttps://github.com/pablogsal
pitrouhttps://github.com/pitrou
February 7, 2019 13:33https://github.com/python/cpython/pull/9047#event-2124062967
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 7, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-201090619
View reviewed changes https://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395
Lib/test/test_threaded_pickle.pyhttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-bcba378280121abf6f6e411887f5ded80a2036c524a65715d0221770797e9924
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254685545
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#10413https://github.com/python/cpython/pull/10413
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254696651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254734008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254747374
Please reload this pagehttps://github.com/python/cpython/pull/9047
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/9047
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254749151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pgansslehttps://github.com/pganssle
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254753330
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
Lib/test/test_threaded_pickle.pyhttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-bcba378280121abf6f6e411887f5ded80a2036c524a65715d0221770797e9924
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254686004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
tjb900https://github.com/tjb900
Feb 8, 2019https://github.com/python/cpython/pull/9047#discussion_r254922511
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pitrouhttps://github.com/pitrou
Feb 8, 2019https://github.com/python/cpython/pull/9047#discussion_r255156467
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
Modules/_pickle.chttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254686262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254736153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pierreglaserhttps://github.com/pierreglaser
@ogriselhttps://github.com/ogrisel
Please reload this pagehttps://github.com/python/cpython/pull/9047
pierreglaserhttps://github.com/pierreglaser
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254757305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 7, 2019https://github.com/python/cpython/pull/9047#issuecomment-461424035
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 7, 2019https://github.com/python/cpython/pull/9047#event-2124091343
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047#issuecomment-461424967
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 7, 2019https://github.com/python/cpython/pull/9047#event-2124099020
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 7, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-201153225
View reviewed changes https://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395
Lib/test/test_threaded_pickle.pyhttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-bcba378280121abf6f6e411887f5ded80a2036c524a65715d0221770797e9924
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254734008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
Modules/_pickle.chttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
pitrouhttps://github.com/pitrou
Feb 7, 2019https://github.com/python/cpython/pull/9047#discussion_r254736153
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pierreglaserhttps://github.com/pierreglaser
@ogriselhttps://github.com/ogrisel
Please reload this pagehttps://github.com/python/cpython/pull/9047
Modules/_pickle.chttps://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395#diff-6a8bf1993db0eae81c2ee98e38eeb1ac4d9342b8b5c090f33417a064e6678562
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 7, 2019https://github.com/python/cpython/pull/9047#issuecomment-461539575
this configurationhttps://gist.github.com/pganssle/d6587d68306ce19df65dfa2eace40f89
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/tjb900
tjb900https://github.com/tjb900
Feb 8, 2019https://github.com/python/cpython/pull/9047#issuecomment-461676184
Please reload this pagehttps://github.com/python/cpython/pull/9047
tjb900https://github.com/tjb900
February 8, 2019 12:48https://github.com/python/cpython/pull/9047#commits-pushed-fa5dbeb
https://github.com/tjb900
add comment to explain why GetModule wasn't usedhttps://github.com/python/cpython/pull/9047/commits/fa5dbebf4d7c0654a1503a8eb9d4fd2e6b69c111
fa5dbebhttps://github.com/python/cpython/pull/9047/commits/fa5dbebf4d7c0654a1503a8eb9d4fd2e6b69c111
https://github.com/tjb900
rewrite test case to avoid sleepshttps://github.com/python/cpython/pull/9047/commits/64a7f954c56d5afc00ea1d8008fb78ff65ddafa1
64a7f95https://github.com/python/cpython/pull/9047/commits/64a7f954c56d5afc00ea1d8008fb78ff65ddafa1
https://github.com/tjb900
move test to AbstractUnpickleTesterhttps://github.com/python/cpython/pull/9047/commits/202d4e2a11f857801356ba181b6e6179a6068016
202d4e2https://github.com/python/cpython/pull/9047/commits/202d4e2a11f857801356ba181b6e6179a6068016
https://github.com/tjb900
tjb900https://github.com/tjb900
Feb 8, 2019https://github.com/python/cpython/pull/9047#issuecomment-461726471
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Feb 8, 2019https://github.com/python/cpython/pull/9047#event-2126460153
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 8, 2019https://github.com/python/cpython/pull/9047#issuecomment-461726479
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 8, 2019https://github.com/python/cpython/pull/9047#issuecomment-461872545
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 8, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-201686679
View reviewed changes https://github.com/python/cpython/pull/9047/files/202d4e2a11f857801356ba181b6e6179a6068016
Lib/test/pickletester.pyhttps://github.com/python/cpython/pull/9047/files/202d4e2a11f857801356ba181b6e6179a6068016#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
pitrouhttps://github.com/pitrou
Feb 8, 2019https://github.com/python/cpython/pull/9047#discussion_r255157822
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 8, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-201686800
View reviewed changes https://github.com/python/cpython/pull/9047/files/202d4e2a11f857801356ba181b6e6179a6068016
Lib/test/pickletester.pyhttps://github.com/python/cpython/pull/9047/files/202d4e2a11f857801356ba181b6e6179a6068016#diff-7d6d2ff428aa3485c637b99154c65cca68ef71ac4e7d4cfe373ac8b1e4e17ff2
pitrouhttps://github.com/pitrou
Feb 8, 2019https://github.com/python/cpython/pull/9047#discussion_r255157935
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/tjb900
better assertionhttps://github.com/python/cpython/pull/9047/commits/a0425ef01015ebf7208f9e062330825ba3587f30
a0425efhttps://github.com/python/cpython/pull/9047/commits/a0425ef01015ebf7208f9e062330825ba3587f30
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Feb 18, 2019https://github.com/python/cpython/pull/9047#issuecomment-464729044
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pitrou
pitrouhttps://github.com/pitrou
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Feb 18, 2019https://github.com/python/cpython/pull/9047#event-2146548556
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 18, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-204834604
View reviewed changes https://github.com/python/cpython/pull/9047/files/a0425ef01015ebf7208f9e062330825ba3587f30
pitrouhttps://github.com/pitrou
https://github.com/python/cpython/pull/9047#pullrequestreview-204834604
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting change review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20change%20review%22
Feb 18, 2019https://github.com/python/cpython/pull/9047#event-2146550138
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Feb 18, 2019https://github.com/python/cpython/pull/9047#issuecomment-464767840
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 18, 2019 https://github.com/python/cpython/pull/9047#pullrequestreview-204843062
View reviewed changes https://github.com/python/cpython/pull/9047/files/a0425ef01015ebf7208f9e062330825ba3587f30
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Feb 18, 2019https://github.com/python/cpython/pull/9047#issuecomment-464775357
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/pitrou
pitrouhttps://github.com/pitrou
4371c0ahttps://github.com/python/cpython/commit/4371c0a9c0848f7a0947d43f26f234842b41efdf
Feb 18, 2019https://github.com/python/cpython/pull/9047#event-2146604234
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Feb 18, 2019https://github.com/python/cpython/pull/9047#issuecomment-464775954
@tjb900https://github.com/tjb900
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Feb 18, 2019https://github.com/python/cpython/pull/9047#event-2146604349
miss-islingtonhttps://github.com/miss-islington
Feb 18, 2019 https://github.com/python/cpython/pull/9047#ref-commit-cf871d5
https://github.com/tjb900
https://github.com/miss-islington
bpo-34572: change _pickle unpickling to use import rather than retrie…https://github.com/miss-islington/cpython/commit/cf871d5a1f706d24b35201424c919cc858be2443
cf871d5https://github.com/miss-islington/cpython/commit/cf871d5a1f706d24b35201424c919cc858be2443
pythonGH-9047https://github.com/python/cpython/pull/9047
4371c0ahttps://github.com/miss-islington/cpython/commit/4371c0a9c0848f7a0947d43f26f234842b41efdf
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Feb 18, 2019https://github.com/python/cpython/pull/9047#issuecomment-464776077
GH-11921https://github.com/python/cpython/pull/11921
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Feb 18, 2019https://github.com/python/cpython/pull/9047#event-2146605056
pitrouhttps://github.com/pitrou
Feb 18, 2019 https://github.com/python/cpython/pull/9047#ref-commit-3129432
https://github.com/miss-islington
https://github.com/tjb900
https://github.com/pitrou
bpo-34572https://bugs.python.org/issue?@action=redirect&bpo=34572
: change _pickle unpickling to use import rather than retrie…https://github.com/python/cpython/commit/3129432845948fdcab1e05042e99a19e9e2c3c71
3129432https://github.com/python/cpython/commit/3129432845948fdcab1e05042e99a19e9e2c3c71
GH-9047https://github.com/python/cpython/pull/9047
GH-11921https://github.com/python/cpython/pull/11921
4371c0ahttps://github.com/python/cpython/commit/4371c0a9c0848f7a0947d43f26f234842b41efdf
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F9047
https://github.com/pganssle
pganssle https://github.com/pganssle
https://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395
https://github.com/pitrou
pitrou https://github.com/pitrou
https://github.com/python/cpython/pull/9047/files/a0425ef01015ebf7208f9e062330825ba3587f30
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/9047/files/a0425ef01015ebf7208f9e062330825ba3587f30
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/pierreglaser
pierreglaser https://github.com/pierreglaser
https://github.com/python/cpython/pull/9047/files/f72802acfd2049285a7d2c1ce446f4991cdb8395
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/9047
https://github.com/tjb900
https://github.com/the-knights-who-say-ni
https://github.com/pganssle
https://github.com/ncoghlan
https://github.com/bedevere-bot
https://github.com/pablogsal
https://github.com/pitrou
https://github.com/miss-islington
https://github.com/pierreglaser
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.