| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:50d9b631-53b0-77b1-31e1-828f9f67f128 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2B2:293912:303684:3F53E2:6B02344F |
| html-safe-nonce | b690f8b36dee2cecfb2e26116607071a0be7a3ec6d8bb4c1c4d50c5f790f427b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkIyOjI5MzkxMjozMDM2ODQ6M0Y1M0UyOjZCMDIzNDRGIiwidmlzaXRvcl9pZCI6IjkwNTk4Mjg3Njc4NzQyMzM0MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8b9baa33d380c5b399d6fd8dde24c6e6ca54dfdbb3f90f46c125fa8a38505b1c |
| hovercard-subject-tag | pull_request:211590375 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/8983/files |
| twitter:image | https://avatars.githubusercontent.com/u/1377457?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1377457?s=400&v=4 |
| og:image:alt | This is intended to be re-based against #8878 - that PR adds tests, this one adds the fix.
I am making this PR before that one is merged mainly because this is some crazy platform-specific behavior... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/8983/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/8983/files |
| Reload | https://github.com/python/cpython/pull/8983/files |
| Reload | https://github.com/python/cpython/pull/8983/files |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| pganssle | https://github.com/pganssle |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:fix_surrogate_strftime | https://github.com/pganssle/cpython/tree/fix_surrogate_strftime |
|
Conversation
3
| https://github.com/python/cpython/pull/8983 |
|
Commits
10
| https://github.com/python/cpython/pull/8983/commits |
|
Checks
0
| https://github.com/python/cpython/pull/8983/checks |
|
Files changed
| https://github.com/python/cpython/pull/8983/files |
| Please reload this page | https://github.com/python/cpython/pull/8983/files |
|
bpo-34481: Fix surrogate-handling in strftime
| https://github.com/python/cpython/pull/8983/files#top |
|
Show all changes
10 commits
| https://github.com/python/cpython/pull/8983/files |
|
97037bd
bpo-34482: Add tests for proper handling of non-UTF-8-encodable strin…
Aug 21, 2018
| https://github.com/python/cpython/pull/8983/commits/97037bd56053db69e1cf35845e3d8d04d53fe353 |
|
ee6227b
Fix error with surrogate characters in strftime
pganssle Aug 23, 2018
| https://github.com/python/cpython/pull/8983/commits/ee6227b93f36b008cfa275d000b22006ef6ba71f |
|
bc13193
Update strftime surrogate tests
pganssle Aug 23, 2018
| https://github.com/python/cpython/pull/8983/commits/bc13193c5552d2a3df50f70de19a9d619515b525 |
|
8029dd1
Fix surrogate handling in Z-replacement
pganssle Aug 27, 2018
| https://github.com/python/cpython/pull/8983/commits/8029dd192e462687b5538698ed1c0caec08ea7a5 |
|
6494aae
Specify caught error when wrapping
pganssle Aug 28, 2018
| https://github.com/python/cpython/pull/8983/commits/6494aae6df57ba33da0bdfd616e5effd0a087b2e |
|
3973be1
Encode to utf-8 rather than locale
pganssle Aug 28, 2018
| https://github.com/python/cpython/pull/8983/commits/3973be13ce75b0fd11ccda2715856bee30d53a13 |
|
667a9c6
Revert "Encode to utf-8 rather than locale"
pganssle Aug 29, 2018
| https://github.com/python/cpython/pull/8983/commits/667a9c66475781d5d69b5149a82228674db1627f |
|
c1381d5
Disable wcsftime
pganssle Aug 29, 2018
| https://github.com/python/cpython/pull/8983/commits/c1381d50d39a20a113e6d4aae546a397b71a6b0a |
|
b643da8
Fall back to unicode escape after locale encoding
pganssle Aug 29, 2018
| https://github.com/python/cpython/pull/8983/commits/b643da871a5a132e6fcd52ff2b62ac5e79e3b85b |
|
9d34c69
Revert "Disable wcsftime"
pganssle Aug 29, 2018
| https://github.com/python/cpython/pull/8983/commits/9d34c690d489fad581db679ea2c079bdd4d86872 |
|
Clear filters
| https://github.com/python/cpython/pull/8983/files |
| Please reload this page | https://github.com/python/cpython/pull/8983/files |
| Please reload this page | https://github.com/python/cpython/pull/8983/files |
|
datetimetester.py
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
2018-08-23-20-42-14.bpo-34482.BzQYUs.rst
| https://github.com/python/cpython/pull/8983/files#diff-0ff6cb9e5cf1a72908c6959f90f89e850177e2932a4e0191d0471aac16e2af5b |
|
_datetimemodule.c
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
timemodule.c
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
| Lib/test/datetimetester.py | https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
View file
| https://github.com/pganssle/cpython/blob/9d34c690d489fad581db679ea2c079bdd4d86872/Lib/test/datetimetester.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/8983/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
|
| https://github.com/python/cpython/pull/8983/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef |
| Misc/NEWS.d/next/Tests/2018-08-23-20-42-14.bpo-34482.BzQYUs.rst | https://github.com/python/cpython/pull/8983/files#diff-0ff6cb9e5cf1a72908c6959f90f89e850177e2932a4e0191d0471aac16e2af5b |
|
View file
| https://github.com/pganssle/cpython/blob/9d34c690d489fad581db679ea2c079bdd4d86872/Misc/NEWS.d/next/Tests/2018-08-23-20-42-14.bpo-34482.BzQYUs.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/8983/{{ revealButtonHref }} |
| Modules/_datetimemodule.c | https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
View file
| https://github.com/pganssle/cpython/blob/9d34c690d489fad581db679ea2c079bdd4d86872/Modules/_datetimemodule.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/8983/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
|
| https://github.com/python/cpython/pull/8983/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47 |
| Modules/timemodule.c | https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
View file
| https://github.com/pganssle/cpython/blob/9d34c690d489fad581db679ea2c079bdd4d86872/Modules/timemodule.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/8983/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com/python/cpython/pull/8983/files#diff-5b4563bfeddc3e20890eada5c8aa651b107a05a0ca8008ae839b86e67897e679 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |