René's URL Explorer Experiment


Title: bpo-34481: Fix surrogate-handling in strftime by pganssle · Pull Request #8983 · python/cpython · GitHub

Open Graph Title: bpo-34481: Fix surrogate-handling in strftime by pganssle · Pull Request #8983 · python/cpython

X Title: bpo-34481: Fix surrogate-handling in strftime by pganssle · Pull Request #8983 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is intended to be re-based against #8878 - that PR adds tests, this one adds the fix. I am making this PR before that one is merged mainly because this is some crazy platform-specific behavior...

X Description: This is intended to be re-based against #8878 - that PR adds tests, this one adds the fix. I am making this PR before that one is merged mainly because this is some crazy platform-specific behavior...

Opengraph URL: https://github.com/python/cpython/pull/8983

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d06299c5-ce64-004c-e8ca-e9a416a7b947
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1C0:3CBB3E:3168B76:3F12386:6B021475
html-safe-noncede87c6b9e6fe9f73bd23cd9fc496433660e351519f62161ceaa2736644e607c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUMwOjNDQkIzRTozMTY4Qjc2OjNGMTIzODY6NkIwMjE0NzUiLCJ2aXNpdG9yX2lkIjoiMTAzMzQzNjMwMjIwNjQ0MDU2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfae97efa25ded445ce400c7c7ba1f1e18235e39b0dc1f4e190850a2d49b14478
hovercard-subject-tagpull_request:211590375
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8983/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9ea990c47281ae354282d20d1e18b27bdc7c3d92635775e516aa04d42c513725/python/cpython/pull/8983
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9ea990c47281ae354282d20d1e18b27bdc7c3d92635775e516aa04d42c513725/python/cpython/pull/8983
og:image:altThis is intended to be re-based against #8878 - that PR adds tests, this one adds the fix. I am making this PR before that one is merged mainly because this is some crazy platform-specific behavior...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepganssle
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/8983#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8983
Reloadhttps://github.com/python/cpython/pull/8983
Reloadhttps://github.com/python/cpython/pull/8983
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
pgansslehttps://github.com/pganssle
python:masterhttps://github.com/python/cpython/tree/master
pganssle:fix_surrogate_strftimehttps://github.com/pganssle/cpython/tree/fix_surrogate_strftime
Conversationhttps://github.com/python/cpython/pull/8983
Commits10 (10)https://github.com/python/cpython/pull/8983/commits
Checkshttps://github.com/python/cpython/pull/8983/checks
Files changedhttps://github.com/python/cpython/pull/8983/files
bpo-34481: Fix surrogate-handling in strftimehttps://github.com/python/cpython/pull/8983#top
pgansslehttps://github.com/pganssle
python:masterhttps://github.com/python/cpython/tree/master
pganssle:fix_surrogate_strftimehttps://github.com/pganssle/cpython/tree/fix_surrogate_strftime
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 28, 2018https://github.com/python/cpython/pull/8983#issue-354944619
Please reload this pagehttps://github.com/python/cpython/pull/8983
#8878https://github.com/python/cpython/pull/8878
https://bugs.python.org/issue34481https://bugs.python.org/issue34481
https://bugs.python.org/issue34481https://bugs.python.org/issue34481
Please reload this pagehttps://github.com/python/cpython/pull/8983
August 23, 2018 20:46https://github.com/python/cpython/pull/8983#commits-pushed-97037bd
bpo-34482: Add tests for proper handling of non-UTF-8-encodable strin…https://github.com/python/cpython/pull/8983/commits/97037bd56053db69e1cf35845e3d8d04d53fe353
97037bdhttps://github.com/python/cpython/pull/8983/commits/97037bd56053db69e1cf35845e3d8d04d53fe353
https://github.com/pganssle
Fix error with surrogate characters in strftimehttps://github.com/python/cpython/pull/8983/commits/ee6227b93f36b008cfa275d000b22006ef6ba71f
ee6227bhttps://github.com/python/cpython/pull/8983/commits/ee6227b93f36b008cfa275d000b22006ef6ba71f
https://github.com/pganssle
Update strftime surrogate testshttps://github.com/python/cpython/pull/8983/commits/bc13193c5552d2a3df50f70de19a9d619515b525
bc13193https://github.com/python/cpython/pull/8983/commits/bc13193c5552d2a3df50f70de19a9d619515b525
https://github.com/pganssle
Fix surrogate handling in Z-replacementhttps://github.com/python/cpython/pull/8983/commits/8029dd192e462687b5538698ed1c0caec08ea7a5
8029dd1https://github.com/python/cpython/pull/8983/commits/8029dd192e462687b5538698ed1c0caec08ea7a5
https://github.com/pganssle
Specify caught error when wrappinghttps://github.com/python/cpython/pull/8983/commits/6494aae6df57ba33da0bdfd616e5effd0a087b2e
6494aaehttps://github.com/python/cpython/pull/8983/commits/6494aae6df57ba33da0bdfd616e5effd0a087b2e
https://github.com/pganssle
Encode to utf-8 rather than localehttps://github.com/python/cpython/pull/8983/commits/3973be13ce75b0fd11ccda2715856bee30d53a13
3973be1https://github.com/python/cpython/pull/8983/commits/3973be13ce75b0fd11ccda2715856bee30d53a13
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 28, 2018https://github.com/python/cpython/pull/8983#event-1814398425
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 28, 2018https://github.com/python/cpython/pull/8983#event-1814398430
pgansslehttps://github.com/pganssle
August 29, 2018 12:12https://github.com/python/cpython/pull/8983#commits-pushed-667a9c6
https://github.com/pganssle
Revert "Encode to utf-8 rather than locale"https://github.com/python/cpython/pull/8983/commits/667a9c66475781d5d69b5149a82228674db1627f
667a9c6https://github.com/python/cpython/pull/8983/commits/667a9c66475781d5d69b5149a82228674db1627f
3973be1https://github.com/pganssle/cpython/commit/3973be13ce75b0fd11ccda2715856bee30d53a13
https://github.com/pganssle
Disable wcsftimehttps://github.com/python/cpython/pull/8983/commits/c1381d50d39a20a113e6d4aae546a397b71a6b0a
c1381d5https://github.com/python/cpython/pull/8983/commits/c1381d50d39a20a113e6d4aae546a397b71a6b0a
https://github.com/pganssle
Fall back to unicode escape after locale encodinghttps://github.com/python/cpython/pull/8983/commits/b643da871a5a132e6fcd52ff2b62ac5e79e3b85b
b643da8https://github.com/python/cpython/pull/8983/commits/b643da871a5a132e6fcd52ff2b62ac5e79e3b85b
https://github.com/pganssle
Revert "Disable wcsftime"https://github.com/python/cpython/pull/8983/commits/9d34c690d489fad581db679ea2c079bdd4d86872
9d34c69https://github.com/python/cpython/pull/8983/commits/9d34c690d489fad581db679ea2c079bdd4d86872
c1381d5https://github.com/pganssle/cpython/commit/c1381d50d39a20a113e6d4aae546a397b71a6b0a
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 30, 2018https://github.com/python/cpython/pull/8983#issuecomment-417487113
Please reload this pagehttps://github.com/python/cpython/pull/8983
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Sep 4, 2018https://github.com/python/cpython/pull/8983#issuecomment-418531527
this functionhttps://github.com/python/cpython/blob/master/Python/fileutils.c#L642
Please reload this pagehttps://github.com/python/cpython/pull/8983
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Sep 5, 2018https://github.com/python/cpython/pull/8983#issuecomment-418710079
Please reload this pagehttps://github.com/python/cpython/pull/8983
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Sep 5, 2018https://github.com/python/cpython/pull/8983#event-1827679561
https://github.com/python/cpython/pull/8983
izbyshevhttps://github.com/python/cpython/pull/8983
Apr 10, 2022 https://github.com/python/cpython/pull/8983#ref-issue-1198996683
Different behavior of C and Python impls of datetime.strftime with non-UTF-8-encodable strings #78662 https://github.com/python/cpython/issues/78662
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983
Please reload this pagehttps://github.com/python/cpython/pull/8983
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/8983
https://github.com/pganssle
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.