| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d06299c5-ce64-004c-e8ca-e9a416a7b947 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A1C0:3CBB3E:3168B76:3F12386:6B021475 |
| html-safe-nonce | de87c6b9e6fe9f73bd23cd9fc496433660e351519f62161ceaa2736644e607c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUMwOjNDQkIzRTozMTY4Qjc2OjNGMTIzODY6NkIwMjE0NzUiLCJ2aXNpdG9yX2lkIjoiMTAzMzQzNjMwMjIwNjQ0MDU2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fae97efa25ded445ce400c7c7ba1f1e18235e39b0dc1f4e190850a2d49b14478 |
| hovercard-subject-tag | pull_request:211590375 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8983/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9ea990c47281ae354282d20d1e18b27bdc7c3d92635775e516aa04d42c513725/python/cpython/pull/8983 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ea990c47281ae354282d20d1e18b27bdc7c3d92635775e516aa04d42c513725/python/cpython/pull/8983 |
| og:image:alt | This is intended to be re-based against #8878 - that PR adds tests, this one adds the fix.
I am making this PR before that one is merged mainly because this is some crazy platform-specific behavior... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pganssle |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/8983#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/8983 |
| Reload | https://github.com/python/cpython/pull/8983 |
| Reload | https://github.com/python/cpython/pull/8983 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| pganssle | https://github.com/pganssle |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:fix_surrogate_strftime | https://github.com/pganssle/cpython/tree/fix_surrogate_strftime |
| Conversation | https://github.com/python/cpython/pull/8983 |
| Commits10 (10) | https://github.com/python/cpython/pull/8983/commits |
| Checks | https://github.com/python/cpython/pull/8983/checks |
| Files changed | https://github.com/python/cpython/pull/8983/files |
| bpo-34481: Fix surrogate-handling in strftime | https://github.com/python/cpython/pull/8983#top |
| pganssle | https://github.com/pganssle |
| python:master | https://github.com/python/cpython/tree/master |
| pganssle:fix_surrogate_strftime | https://github.com/pganssle/cpython/tree/fix_surrogate_strftime |
|
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Aug 28, 2018 | https://github.com/python/cpython/pull/8983#issue-354944619 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
| #8878 | https://github.com/python/cpython/pull/8878 |
| https://bugs.python.org/issue34481 | https://bugs.python.org/issue34481 |
| https://bugs.python.org/issue34481 | https://bugs.python.org/issue34481 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
| August 23, 2018 20:46 | https://github.com/python/cpython/pull/8983#commits-pushed-97037bd |
| bpo-34482: Add tests for proper handling of non-UTF-8-encodable strin… | https://github.com/python/cpython/pull/8983/commits/97037bd56053db69e1cf35845e3d8d04d53fe353 |
| 97037bd | https://github.com/python/cpython/pull/8983/commits/97037bd56053db69e1cf35845e3d8d04d53fe353 |
|
| https://github.com/pganssle |
| Fix error with surrogate characters in strftime | https://github.com/python/cpython/pull/8983/commits/ee6227b93f36b008cfa275d000b22006ef6ba71f |
| ee6227b | https://github.com/python/cpython/pull/8983/commits/ee6227b93f36b008cfa275d000b22006ef6ba71f |
|
| https://github.com/pganssle |
| Update strftime surrogate tests | https://github.com/python/cpython/pull/8983/commits/bc13193c5552d2a3df50f70de19a9d619515b525 |
| bc13193 | https://github.com/python/cpython/pull/8983/commits/bc13193c5552d2a3df50f70de19a9d619515b525 |
|
| https://github.com/pganssle |
| Fix surrogate handling in Z-replacement | https://github.com/python/cpython/pull/8983/commits/8029dd192e462687b5538698ed1c0caec08ea7a5 |
| 8029dd1 | https://github.com/python/cpython/pull/8983/commits/8029dd192e462687b5538698ed1c0caec08ea7a5 |
|
| https://github.com/pganssle |
| Specify caught error when wrapping | https://github.com/python/cpython/pull/8983/commits/6494aae6df57ba33da0bdfd616e5effd0a087b2e |
| 6494aae | https://github.com/python/cpython/pull/8983/commits/6494aae6df57ba33da0bdfd616e5effd0a087b2e |
|
| https://github.com/pganssle |
| Encode to utf-8 rather than locale | https://github.com/python/cpython/pull/8983/commits/3973be13ce75b0fd11ccda2715856bee30d53a13 |
| 3973be1 | https://github.com/python/cpython/pull/8983/commits/3973be13ce75b0fd11ccda2715856bee30d53a13 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Aug 28, 2018 | https://github.com/python/cpython/pull/8983#event-1814398425 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Aug 28, 2018 | https://github.com/python/cpython/pull/8983#event-1814398430 |
| pganssle | https://github.com/pganssle |
| August 29, 2018 12:12 | https://github.com/python/cpython/pull/8983#commits-pushed-667a9c6 |
|
| https://github.com/pganssle |
| Revert "Encode to utf-8 rather than locale" | https://github.com/python/cpython/pull/8983/commits/667a9c66475781d5d69b5149a82228674db1627f |
| 667a9c6 | https://github.com/python/cpython/pull/8983/commits/667a9c66475781d5d69b5149a82228674db1627f |
| 3973be1 | https://github.com/pganssle/cpython/commit/3973be13ce75b0fd11ccda2715856bee30d53a13 |
|
| https://github.com/pganssle |
| Disable wcsftime | https://github.com/python/cpython/pull/8983/commits/c1381d50d39a20a113e6d4aae546a397b71a6b0a |
| c1381d5 | https://github.com/python/cpython/pull/8983/commits/c1381d50d39a20a113e6d4aae546a397b71a6b0a |
|
| https://github.com/pganssle |
| Fall back to unicode escape after locale encoding | https://github.com/python/cpython/pull/8983/commits/b643da871a5a132e6fcd52ff2b62ac5e79e3b85b |
| b643da8 | https://github.com/python/cpython/pull/8983/commits/b643da871a5a132e6fcd52ff2b62ac5e79e3b85b |
|
| https://github.com/pganssle |
| Revert "Disable wcsftime" | https://github.com/python/cpython/pull/8983/commits/9d34c690d489fad581db679ea2c079bdd4d86872 |
| 9d34c69 | https://github.com/python/cpython/pull/8983/commits/9d34c690d489fad581db679ea2c079bdd4d86872 |
| c1381d5 | https://github.com/pganssle/cpython/commit/c1381d50d39a20a113e6d4aae546a397b71a6b0a |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Aug 30, 2018 | https://github.com/python/cpython/pull/8983#issuecomment-417487113 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Sep 4, 2018 | https://github.com/python/cpython/pull/8983#issuecomment-418531527 |
| this function | https://github.com/python/cpython/blob/master/Python/fileutils.c#L642 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Sep 5, 2018 | https://github.com/python/cpython/pull/8983#issuecomment-418710079 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
| https://github.com/pganssle |
| pganssle | https://github.com/pganssle |
| Sep 5, 2018 | https://github.com/python/cpython/pull/8983#event-1827679561 |
| https://github.com/python/cpython/pull/8983 |
| izbyshev | https://github.com/python/cpython/pull/8983 |
|
Apr 10, 2022
| https://github.com/python/cpython/pull/8983#ref-issue-1198996683 |
|
Different behavior of C and Python impls of datetime.strftime with non-UTF-8-encodable strings
#78662
| https://github.com/python/cpython/issues/78662 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8983 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Please reload this page | https://github.com/python/cpython/pull/8983 |
|
| https://github.com/pganssle |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |