René's URL Explorer Experiment


Title: bpo-34454: Clean up datetime.fromisoformat surrogate handling by pganssle · Pull Request #8959 · python/cpython · GitHub

Open Graph Title: bpo-34454: Clean up datetime.fromisoformat surrogate handling by pganssle · Pull Request #8959 · python/cpython

X Title: bpo-34454: Clean up datetime.fromisoformat surrogate handling by pganssle · Pull Request #8959 · python/cpython

Description: This is a fixup PR for #8862, per @serhiy-storchaka's comments. I have addressed two PEP-7 violations, switched to using _PyUnicode_Copy in _sanitize_fromisoformat_str, and fixed an issue where the sanitized string (rather than the original string) was displayed as part of the error message. Additionally, I noticed that the pure Python implementation uses the equivalent of %U instead of %R in its error printing, so I switched all the fromisoformat errors over to using %U for consistency. bpo-34454 https://bugs.python.org/issue34454

Open Graph Description: This is a fixup PR for #8862, per @serhiy-storchaka's comments. I have addressed two PEP-7 violations, switched to using _PyUnicode_Copy in _sanitize_fromisoformat_str, and fixed an issue where...

X Description: This is a fixup PR for #8862, per @serhiy-storchaka's comments. I have addressed two PEP-7 violations, switched to using _PyUnicode_Copy in _sanitize_fromisoformat_str, and fixed an issue w...

Opengraph URL: https://github.com/python/cpython/pull/8959

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7043f05f-f4bc-9ed5-1d9f-f809cb535248
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD22:2C4BED:40FA02A:52734EE:6B022047
html-safe-nonceedbbb029060202c9b5f5b1cdd7a023d42313e921fa2ad46924fdcc863a2c91ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDIyOjJDNEJFRDo0MEZBMDJBOjUyNzM0RUU6NkIwMjIwNDciLCJ2aXNpdG9yX2lkIjoiNTYwNzg5ODU5MDY5ODY3NjI5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4f95072bdadf94940c0a41662ec6abc968f3684bb2533f1c568a1b919179a8c4
hovercard-subject-tagpull_request:211235328
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8959/files
twitter:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
og:image:altThis is a fixup PR for #8862, per @serhiy-storchaka's comments. I have addressed two PEP-7 violations, switched to using _PyUnicode_Copy in _sanitize_fromisoformat_str, and fixed an issue where...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8959/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8959%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8959%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8959/files
Reloadhttps://github.com/python/cpython/pull/8959/files
Reloadhttps://github.com/python/cpython/pull/8959/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
pganssle:cleanup_fromisoformat_surrogatehttps://github.com/pganssle/cpython/tree/cleanup_fromisoformat_surrogate
Conversation 48 https://github.com/python/cpython/pull/8959
Commits 6 https://github.com/python/cpython/pull/8959/commits
Checks 0 https://github.com/python/cpython/pull/8959/checks
Files changed https://github.com/python/cpython/pull/8959/files
Please reload this pagehttps://github.com/python/cpython/pull/8959/files
bpo-34454: Clean up datetime.fromisoformat surrogate handling https://github.com/python/cpython/pull/8959/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/8959/files
76b274d Use _PyUnicode_Copy in sanitize_isoformat_str pganssle Aug 27, 2018 https://github.com/python/cpython/pull/8959/commits/76b274d1fdf3f9bf650123db3d6a257e70ed9f4d
6d6f3d0 Use repr in fromisoformat error message pganssle Aug 27, 2018 https://github.com/python/cpython/pull/8959/commits/6d6f3d0a55aa5a57a8cac5b39b4409fad8a5298e
eb8e176 Retain non-sanitized dtstr for error printing pganssle Aug 27, 2018 https://github.com/python/cpython/pull/8959/commits/eb8e17632353044c9c45ed4b16552b65e056960b
4e54bd9 Separate handling of Unicode and other errors pganssle Aug 28, 2018 https://github.com/python/cpython/pull/8959/commits/4e54bd90b1f587bdaccd3ed5ae3ce7915836949e
d809d71 PEP 7 fixes to from_isoformat pganssle Aug 27, 2018 https://github.com/python/cpython/pull/8959/commits/d809d712c3c79ccadc6061469f9751f7120edbf5
90a2e71 Drop needs_decref from _sanitize_isoformat_str pganssle Aug 28, 2018 https://github.com/python/cpython/pull/8959/commits/90a2e71e6131bb19efd09c6d5e241495a77ad3a3
Clear filters https://github.com/python/cpython/pull/8959/files
Please reload this pagehttps://github.com/python/cpython/pull/8959/files
Please reload this pagehttps://github.com/python/cpython/pull/8959/files
datetime.py https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
datetimetester.py https://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
_datetimemodule.c https://github.com/python/cpython/pull/8959/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Lib/datetime.pyhttps://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
View file https://github.com/pganssle/cpython/blob/90a2e71e6131bb19efd09c6d5e241495a77ad3a3/Lib/datetime.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8959/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
https://github.com/python/cpython/pull/8959/files#diff-2a8962dcecb109859cedd81ddc5729bea57d156e0947cb8413f99781a0860fd1
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/pganssle/cpython/blob/90a2e71e6131bb19efd09c6d5e241495a77ad3a3/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8959/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8959/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Please reload this pagehttps://github.com/python/cpython/pull/8959/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.