René's URL Explorer Experiment


Title: bpo-34515: lib2to3: support non-ASCII identifiers by holymonson · Pull Request #8950 · python/cpython · GitHub

Open Graph Title: bpo-34515: lib2to3: support non-ASCII identifiers by holymonson · Pull Request #8950 · python/cpython

X Title: bpo-34515: lib2to3: support non-ASCII identifiers by holymonson · Pull Request #8950 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: https://bugs.python.org/issue34515

X Description: https://bugs.python.org/issue34515

Opengraph URL: https://github.com/python/cpython/pull/8950

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ddb9196b-70ab-b257-1f78-176a446f8cac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB014:2080FA:12B3A41:19CD4B7:6A53C857
html-safe-nonced417536d611ee09dcf6b2be3d2a60d566e4692863f40ffdf5634d578a1d821fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDE0OjIwODBGQToxMkIzQTQxOjE5Q0Q0Qjc6NkE1M0M4NTciLCJ2aXNpdG9yX2lkIjoiMTA4MzAxNDI5MDgwODc1MjIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc7b5ca1d315d772ae5ab3267ed57940a7f636e99b93d87c54b6121dd39589f15
hovercard-subject-tagpull_request:211021216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8950/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/116f5ef43f8183c98866dcfa327cc3c0e8817084adf68c7fa2eefd841e0e8d77/python/cpython/pull/8950
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/116f5ef43f8183c98866dcfa327cc3c0e8817084adf68c7fa2eefd841e0e8d77/python/cpython/pull/8950
og:image:althttps://bugs.python.org/issue34515
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameholymonson
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8950#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8950
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8950
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8950
Reloadhttps://github.com/python/cpython/pull/8950
Reloadhttps://github.com/python/cpython/pull/8950
Please reload this pagehttps://github.com/python/cpython/pull/8950
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8950
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
benjaminphttps://github.com/benjaminp
python:masterhttps://github.com/python/cpython/tree/master
holymonson:non_ascii_identifiershttps://github.com/holymonson/cpython/tree/non_ascii_identifiers
Conversationhttps://github.com/python/cpython/pull/8950
Commits4 (4)https://github.com/python/cpython/pull/8950/commits
Checkshttps://github.com/python/cpython/pull/8950/checks
Files changedhttps://github.com/python/cpython/pull/8950/files
bpo-34515: lib2to3: support non-ASCII identifiershttps://github.com/python/cpython/pull/8950#top
benjaminphttps://github.com/benjaminp
python:masterhttps://github.com/python/cpython/tree/master
holymonson:non_ascii_identifiershttps://github.com/holymonson/cpython/tree/non_ascii_identifiers
https://github.com/holymonson
holymonsonhttps://github.com/holymonson
Aug 27, 2018https://github.com/python/cpython/pull/8950#issue-354201504
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://bugs.python.org/issue34515https://bugs.python.org/issue34515
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 27, 2018https://github.com/python/cpython/pull/8950#event-1809890577
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 27, 2018https://github.com/python/cpython/pull/8950#event-1809890580
https://github.com/holymonson
holymonsonhttps://github.com/holymonson
Aug 27, 2018 https://github.com/python/cpython/pull/8950#ref-issue-354022555
PEP 3131 -- Supporting Non-ASCII Identifiers google/yapf#607 https://github.com/google/yapf/issues/607
https://github.com/holymonson
holymonsonhttps://github.com/holymonson
Aug 27, 2018https://github.com/python/cpython/pull/8950#issuecomment-416137444
google/yapf#607https://github.com/google/yapf/issues/607
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/kamahen
kamahenhttps://github.com/kamahen
Aug 27, 2018 https://github.com/python/cpython/pull/8950#pullrequestreview-149677294
View reviewed changes https://github.com/python/cpython/pull/8950/files
Lib/lib2to3/tests/test_parser.pyhttps://github.com/python/cpython/pull/8950/files#diff-a4f0c0a76003dc753897719907a630aaf4bd951c8806cd5a613141e173d9aef1
kamahenhttps://github.com/kamahen
Aug 27, 2018https://github.com/python/cpython/pull/8950#discussion_r212947058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Lib/test/test_unicode_identifiers.pyhttps://github.com/python/cpython/blob/master/Lib/test/test_unicode_identifiers.py
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/holymonson
holymonsonhttps://github.com/holymonson
force-pushedhttps://github.com/python/cpython/compare/1b3072bda1aa6d3faa8b0e6d7be1f98586ff3c44..50f189efbafac23615d17e0551a9b49e3abf27bd
1b3072bhttps://github.com/python/cpython/commit/1b3072bda1aa6d3faa8b0e6d7be1f98586ff3c44
50f189ehttps://github.com/python/cpython/commit/50f189efbafac23615d17e0551a9b49e3abf27bd
Compare https://github.com/python/cpython/compare/1b3072bda1aa6d3faa8b0e6d7be1f98586ff3c44..50f189efbafac23615d17e0551a9b49e3abf27bd
August 27, 2018 12:51https://github.com/python/cpython/pull/8950#event-1810512875
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
Sep 10, 2018 https://github.com/python/cpython/pull/8950#pullrequestreview-153913617
View reviewed changes https://github.com/python/cpython/pull/8950/files
Lib/lib2to3/pgen2/tokenize.pyhttps://github.com/python/cpython/pull/8950/files#diff-ab926a388fdf81ef5e8a03972afaa995dd5e4341a176e8197e79d31b6dd3a1b8
benjaminphttps://github.com/benjaminp
Sep 10, 2018https://github.com/python/cpython/pull/8950#discussion_r216433795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8950
holymonsonhttps://github.com/holymonson
Sep 15, 2018https://github.com/python/cpython/pull/8950#discussion_r217876379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/8950
benjaminphttps://github.com/benjaminp
Sep 15, 2018https://github.com/python/cpython/pull/8950#discussion_r217890686
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8950
holymonsonhttps://github.com/holymonson
September 15, 2018 10:33https://github.com/python/cpython/pull/8950#commits-pushed-6cf1258
https://github.com/holymonson
lib2to3: support non-ASCII identifiershttps://github.com/python/cpython/pull/8950/commits/6cf12584ba8778f567417b382a177539d0cac7fc
6cf1258https://github.com/python/cpython/pull/8950/commits/6cf12584ba8778f567417b382a177539d0cac7fc
https://github.com/holymonson
add newshttps://github.com/python/cpython/pull/8950/commits/07747382d82149ac459b826f418485af2dc7f43e
0774738https://github.com/python/cpython/pull/8950/commits/07747382d82149ac459b826f418485af2dc7f43e
https://github.com/holymonson
add more testhttps://github.com/python/cpython/pull/8950/commits/fb3a039664a63d12a6732d012a65899e4aadc9dd
fb3a039https://github.com/python/cpython/pull/8950/commits/fb3a039664a63d12a6732d012a65899e4aadc9dd
https://github.com/holymonson
imitate tokenize.pyhttps://github.com/python/cpython/pull/8950/commits/37d8770d537f0b55e867c8383619e157a6daafe3
37d8770https://github.com/python/cpython/pull/8950/commits/37d8770d537f0b55e867c8383619e157a6daafe3
https://github.com/holymonson
holymonsonhttps://github.com/holymonson
force-pushedhttps://github.com/python/cpython/compare/50f189efbafac23615d17e0551a9b49e3abf27bd..37d8770d537f0b55e867c8383619e157a6daafe3
50f189ehttps://github.com/python/cpython/commit/50f189efbafac23615d17e0551a9b49e3abf27bd
37d8770https://github.com/python/cpython/commit/37d8770d537f0b55e867c8383619e157a6daafe3
Compare https://github.com/python/cpython/compare/50f189efbafac23615d17e0551a9b49e3abf27bd..37d8770d537f0b55e867c8383619e157a6daafe3
September 15, 2018 02:53https://github.com/python/cpython/pull/8950#event-1847304028
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Sep 15, 2018https://github.com/python/cpython/pull/8950#event-1847646450
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
10a428bhttps://github.com/python/cpython/commit/10a428b64b3f224e2ccd40ff2afb141b9b3425b1
Sep 15, 2018https://github.com/python/cpython/pull/8950#event-1847646645
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421604308
@holymonsonhttps://github.com/holymonson
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 15, 2018https://github.com/python/cpython/pull/8950#event-1847646666
miss-islingtonhttps://github.com/miss-islington
Sep 15, 2018 https://github.com/python/cpython/pull/8950#ref-commit-a9f58c2
https://github.com/holymonson
https://github.com/miss-islington
closes bpo-34515: Support non-ASCII identifiers in lib2to3. (https://github.com/miss-islington/cpython/commit/a9f58c25ac6abcad83152d95af794fc6215996b2
pythonGH…https://github.com/python/cpython/pull/8950
a9f58c2https://github.com/miss-islington/cpython/commit/a9f58c25ac6abcad83152d95af794fc6215996b2
…-8950https://github.com/python/cpython/pull/8950
10a428bhttps://github.com/miss-islington/cpython/commit/10a428b64b3f224e2ccd40ff2afb141b9b3425b1
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421604347
GH-9333https://github.com/python/cpython/pull/9333
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Sep 15, 2018https://github.com/python/cpython/pull/8950#event-1847646806
https://github.com/ambv
ambvhttps://github.com/ambv
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421604881
@benjaminphttps://github.com/benjaminp
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/ambv
ambvhttps://github.com/ambv
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421605000
BPO-33338https://bugs.python.org/issue?@action=redirect&bpo=33338
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/benjaminp
benjaminphttps://github.com/benjaminp
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421605491
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/ambv
ambvhttps://github.com/ambv
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421606083
GH-9333https://github.com/python/cpython/pull/9333
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/ambv
ambvhttps://github.com/ambv
Sep 15, 2018https://github.com/python/cpython/pull/8950#issuecomment-421606111
Please reload this pagehttps://github.com/python/cpython/pull/8950
miss-islingtonhttps://github.com/miss-islington
Sep 15, 2018 https://github.com/python/cpython/pull/8950#ref-commit-51dbae8
https://github.com/miss-islington
https://github.com/holymonson
closeshttps://github.com/python/cpython/commit/51dbae867e82014f9af89662977e4981463c51e8
bpo-34515https://bugs.python.org/issue?@action=redirect&bpo=34515
: Support non-ASCII identifiers in lib2to3. (https://github.com/python/cpython/commit/51dbae867e82014f9af89662977e4981463c51e8
GH-8950https://github.com/python/cpython/pull/8950
)https://github.com/python/cpython/commit/51dbae867e82014f9af89662977e4981463c51e8
51dbae8https://github.com/python/cpython/commit/51dbae867e82014f9af89662977e4981463c51e8
10a428bhttps://github.com/python/cpython/commit/10a428b64b3f224e2ccd40ff2afb141b9b3425b1
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8950
https://github.com/benjaminp
benjaminp https://github.com/benjaminp
https://github.com/python/cpython/pull/8950/files/37d8770d537f0b55e867c8383619e157a6daafe3
https://github.com/kamahen
kamahen https://github.com/kamahen
https://github.com/python/cpython/pull/8950/files/623ba8cb643540b86bab2032112fd2bafbc4ff6d
Please reload this pagehttps://github.com/python/cpython/pull/8950
https://github.com/holymonson
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/ambv
https://github.com/benjaminp
https://github.com/kamahen
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.