René's URL Explorer Experiment


Title: bpo-34454: Fix issue with non-UTF8 separator strings by pganssle · Pull Request #8862 · python/cpython · GitHub

Open Graph Title: bpo-34454: Fix issue with non-UTF8 separator strings by pganssle · Pull Request #8862 · python/cpython

X Title: bpo-34454: Fix issue with non-UTF8 separator strings by pganssle · Pull Request #8862 · python/cpython

Description: It is possible to pass a non-UTF-8 string as a separator in datetime.isoformat, but the current implementation starts by decoding to UTF-8, which will fail even for some valid strings. In the special case of non-UTF-8 separators, we replace the separator character with T before encoding as UTF-8, so that encoding errors only occur on invalid ISO 8601 strings, and are handled as a standard ValueError (as would occur in the pure Python version). bpo-34454: Implementation of the fix without significant performance problems. https://bugs.python.org/issue34454

Open Graph Description: It is possible to pass a non-UTF-8 string as a separator in datetime.isoformat, but the current implementation starts by decoding to UTF-8, which will fail even for some valid strings. In the speci...

X Description: It is possible to pass a non-UTF-8 string as a separator in datetime.isoformat, but the current implementation starts by decoding to UTF-8, which will fail even for some valid strings. In the speci...

Opengraph URL: https://github.com/python/cpython/pull/8862

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aef0734a-fbce-a34d-b9fb-b6d9ed3d9106
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD68:E0ADF:17C00E9:1DF1B93:6B02204D
html-safe-noncecb210fe9dc4f37c4c76ece187ce472b4f89124ab80c9e37a38bcaaecd7f6b7a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDY4OkUwQURGOjE3QzAwRTk6MURGMUI5Mzo2QjAyMjA0RCIsInZpc2l0b3JfaWQiOiI2OTI0NTExMTQ3MzE2MDkzMDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc2b7d5972742e6c64f9c51eaba68f4543572e8aa1d17689d7b6a4511672c86cf
hovercard-subject-tagpull_request:210193343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8862/files
twitter:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1377457?s=400&v=4
og:image:altIt is possible to pass a non-UTF-8 string as a separator in datetime.isoformat, but the current implementation starts by decoding to UTF-8, which will fail even for some valid strings. In the speci...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8862/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8862%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8862%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8862/files
Reloadhttps://github.com/python/cpython/pull/8862/files
Reloadhttps://github.com/python/cpython/pull/8862/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
taleinathttps://github.com/taleinat
python:masterhttps://github.com/python/cpython/tree/master
pganssle:fromisoformat_fix_nonutf8_crashhttps://github.com/pganssle/cpython/tree/fromisoformat_fix_nonutf8_crash
Conversation 36 https://github.com/python/cpython/pull/8862
Commits 7 https://github.com/python/cpython/pull/8862/commits
Checks 0 https://github.com/python/cpython/pull/8862/checks
Files changed https://github.com/python/cpython/pull/8862/files
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
bpo-34454: Fix issue with non-UTF8 separator strings https://github.com/python/cpython/pull/8862/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/8862/files
2f48e53 Fix issue with non-UTF8 separator strings pganssle Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/2f48e5381900cf37c2b98a9cab51f91d718e7256
85a99ca Fix non-UTF8 crash for (date|time)_fromisoformat pganssle Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/85a99ca97a90c8b91b4901a7deea7b444303aa94
dd82aa0 Refactor non-UTF-8 sanitization pganssle Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/dd82aa01bb2789595f178d6d8501557c5516502c
c24388e Add tests for surrogate code points taleinat Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/c24388e94666ef079a4978956016512a3e9ce3a4
a0246a0 Add news entry for bpo-34454 taleinat Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/a0246a0a351376fee0806d7f1e9c1716fe6b2c56
b89d4f5 Refactor sanitize_isoformat_str pganssle Aug 22, 2018 https://github.com/python/cpython/pull/8862/commits/b89d4f5627a423bf66b86ad90a436ebea6c4b8e9
160e779 added mention of patch author in NEWS taleinat Aug 23, 2018 https://github.com/python/cpython/pull/8862/commits/160e779654eda94a819b928ebd60901d588f2b6a
Clear filters https://github.com/python/cpython/pull/8862/files
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
datetimetester.py https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
2018-08-22-21-59-08.bpo-34454.z7uG4b.rst https://github.com/python/cpython/pull/8862/files#diff-2624aa6e6e2146f88f297e5d53eb471e0625c979a1391e0582041a3adb666dcc
_datetimemodule.c https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/pganssle/cpython/blob/160e779654eda94a819b928ebd60901d588f2b6a/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8862/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Misc/NEWS.d/next/Library/2018-08-22-21-59-08.bpo-34454.z7uG4b.rsthttps://github.com/python/cpython/pull/8862/files#diff-2624aa6e6e2146f88f297e5d53eb471e0625c979a1391e0582041a3adb666dcc
View file https://github.com/pganssle/cpython/blob/160e779654eda94a819b928ebd60901d588f2b6a/Misc/NEWS.d/next/Library/2018-08-22-21-59-08.bpo-34454.z7uG4b.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8862/{{ revealButtonHref }}
Modules/_datetimemodule.chttps://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
View file https://github.com/pganssle/cpython/blob/160e779654eda94a819b928ebd60901d588f2b6a/Modules/_datetimemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8862/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212619691
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212620506
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
pgansslehttps://github.com/pganssle
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212634670
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212620968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
pgansslehttps://github.com/pganssle
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212634430
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212623856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
pgansslehttps://github.com/pganssle
Aug 24, 2018https://github.com/python/cpython/pull/8862/files#r212635131
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8862/files
https://github.com/python/cpython/pull/8862/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.