René's URL Explorer Experiment


Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython · GitHub

Open Graph Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython

X Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython

Description: The current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows using a surrogate as the separator character when calling datetime.fromisoformat(). As mentioned in a comment on the bpo issue, there's actually no need to encode the input as UTF-8. This implementation uses PyUnicode_1BYTE_DATA() when possible. In other cases (which should be extremely rare!), it creates temporary intermediate Python objects. For date and time, a single temporary bytes object is created. For datetime, up to four temporary objects are created: two str objects (for sub-strings) and two bytes objects (for converting the sub-strings to ASCII). This increases the size and complexity of the code considerably, but I couldn't find a reasonable way to avoid creating these objects entirely. https://bugs.python.org/issue34454

Open Graph Description: The current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...

X Description: The current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...

Opengraph URL: https://github.com/python/cpython/pull/8859

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:12edb8b3-ebd7-c520-c124-87da678c571a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB75C:20BA8:1F6196:29AC2C:6B022DB2
html-safe-nonce5673a8c158bf37b65aa8fe68865b3ec31635e4b38b12e2910fecf5346632d043
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzVDOjIwQkE4OjFGNjE5NjoyOUFDMkM6NkIwMjJEQjIiLCJ2aXNpdG9yX2lkIjoiMjA1NjE5MTE4NjQ1NjE2MTcxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac54eda50e6b863863a22a54f79be00ec4bdf167bc9b84d55dfbacc6a4f39fd439
hovercard-subject-tagpull_request:210114217
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8859/files
twitter:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
og:image:altThe current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8859/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8859%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8859%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8859/files
Reloadhttps://github.com/python/cpython/pull/8859/files
Reloadhttps://github.com/python/cpython/pull/8859/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
taleinathttps://github.com/taleinat
python:masterhttps://github.com/python/cpython/tree/master
taleinat:bpo-34454/fromisoformat_avoid_utf8_encodinghttps://github.com/taleinat/cpython/tree/bpo-34454/fromisoformat_avoid_utf8_encoding
Conversation 25 https://github.com/python/cpython/pull/8859
Commits 2 https://github.com/python/cpython/pull/8859/commits
Checks 0 https://github.com/python/cpython/pull/8859/checks
Files changed https://github.com/python/cpython/pull/8859/files
Please reload this pagehttps://github.com/python/cpython/pull/8859/files
bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points https://github.com/python/cpython/pull/8859/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/8859/files
6df3ca9 bpo-34454: avoid internally encoding fromisoformat() input to UTF-8 taleinat Aug 22, 2018 https://github.com/python/cpython/pull/8859/commits/6df3ca984743cbc66e8020c883ecda1db56bc967
3a02c2b bpo-34454: optimize, add tests and NEWS taleinat Aug 22, 2018 https://github.com/python/cpython/pull/8859/commits/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1
Clear filters https://github.com/python/cpython/pull/8859/files
Please reload this pagehttps://github.com/python/cpython/pull/8859/files
Please reload this pagehttps://github.com/python/cpython/pull/8859/files
datetimetester.py https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
2018-08-22-21-59-08.bpo-34454.z7uG4b.rst https://github.com/python/cpython/pull/8859/files#diff-2624aa6e6e2146f88f297e5d53eb471e0625c979a1391e0582041a3adb666dcc
_datetimemodule.c https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
Lib/test/datetimetester.pyhttps://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
View file https://github.com/taleinat/cpython/blob/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1/Lib/test/datetimetester.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8859/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
https://github.com/python/cpython/pull/8859/files#diff-917d5d1d1423993f37a643afa9f2a2f9caa3c0f91e06c0d7ebea1b879d53b4ef
Misc/NEWS.d/next/Library/2018-08-22-21-59-08.bpo-34454.z7uG4b.rsthttps://github.com/python/cpython/pull/8859/files#diff-2624aa6e6e2146f88f297e5d53eb471e0625c979a1391e0582041a3adb666dcc
View file https://github.com/taleinat/cpython/blob/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1/Misc/NEWS.d/next/Library/2018-08-22-21-59-08.bpo-34454.z7uG4b.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8859/{{ revealButtonHref }}
Modules/_datetimemodule.chttps://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
View file https://github.com/taleinat/cpython/blob/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1/Modules/_datetimemodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8859/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com/python/cpython/pull/8859/files#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.