René's URL Explorer Experiment


Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython · GitHub

Open Graph Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython

X Title: bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code points by taleinat · Pull Request #8859 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...

X Description: The current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...

Opengraph URL: https://github.com/python/cpython/pull/8859

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:94bfe32c-4fef-643c-5418-088f4f18d0ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE74A:148EE1:A7AFCF:D336AF:6B022032
html-safe-nonced315e45d7c747ecf88bea9fcb59144166a7345cf611855f2cbd791bd97e7d67e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzRBOjE0OEVFMTpBN0FGQ0Y6RDMzNkFGOjZCMDIyMDMyIiwidmlzaXRvcl9pZCI6IjIyMzEyNzM0MzY2Mjg1MjUxMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf487a12eb8bf353a83a80af6a23f3e46fc42ca7ae0a75b68041109f2d32de707
hovercard-subject-tagpull_request:210114217
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8859/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7885f564bb369bcc9f5cbdb2dfe5a6efba4cc2f4effc37a0ae8617081b6f65ea/python/cpython/pull/8859
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7885f564bb369bcc9f5cbdb2dfe5a6efba4cc2f4effc37a0ae8617081b6f65ea/python/cpython/pull/8859
og:image:altThe current implementation crashes if the input includes a surrogate Unicode code point, which is not possible to encode in UTF-8. It is important to note that the pure-Python implementation allows...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametaleinat
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/8859#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8859
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8859
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8859
Reloadhttps://github.com/python/cpython/pull/8859
Reloadhttps://github.com/python/cpython/pull/8859
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
taleinathttps://github.com/taleinat
python:masterhttps://github.com/python/cpython/tree/master
taleinat:bpo-34454/fromisoformat_avoid_utf8_encodinghttps://github.com/taleinat/cpython/tree/bpo-34454/fromisoformat_avoid_utf8_encoding
Conversationhttps://github.com/python/cpython/pull/8859
Commits2 (2)https://github.com/python/cpython/pull/8859/commits
Checkshttps://github.com/python/cpython/pull/8859/checks
Files changedhttps://github.com/python/cpython/pull/8859/files
bpo-34454: fix crash in .fromisoformat() methods when given inputs with surrogate code pointshttps://github.com/python/cpython/pull/8859#top
taleinathttps://github.com/taleinat
python:masterhttps://github.com/python/cpython/tree/master
taleinat:bpo-34454/fromisoformat_avoid_utf8_encodinghttps://github.com/taleinat/cpython/tree/bpo-34454/fromisoformat_avoid_utf8_encoding
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issue-352927742
Please reload this pagehttps://github.com/python/cpython/pull/8859
a comment on the bpo issuehttps://bugs.python.org/issue34454#msg323846
https://bugs.python.org/issue34454https://bugs.python.org/issue34454
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1802490863
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1802490934
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1802490965
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415012178
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
bpo-34454: avoid internally encoding fromisoformat() input to UTF-8https://github.com/python/cpython/pull/8859/commits/6df3ca984743cbc66e8020c883ecda1db56bc967
6df3ca9https://github.com/python/cpython/pull/8859/commits/6df3ca984743cbc66e8020c883ecda1db56bc967
https://github.com/taleinat
taleinathttps://github.com/taleinat
force-pushedhttps://github.com/python/cpython/compare/978ccf3ca10b7ddf43ffc51b2a93dda29c080c98..6df3ca984743cbc66e8020c883ecda1db56bc967
978ccf3https://github.com/python/cpython/commit/978ccf3ca10b7ddf43ffc51b2a93dda29c080c98
6df3ca9https://github.com/python/cpython/commit/6df3ca984743cbc66e8020c883ecda1db56bc967
Compare https://github.com/python/cpython/compare/978ccf3ca10b7ddf43ffc51b2a93dda29c080c98..6df3ca984743cbc66e8020c883ecda1db56bc967
August 22, 2018 13:13https://github.com/python/cpython/pull/8859#event-1802612494
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415032364
@taleinathttps://github.com/taleinat
@izbyshevhttps://github.com/izbyshev
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018 https://github.com/python/cpython/pull/8859#pullrequestreview-148483624
View reviewed changes https://github.com/python/cpython/pull/8859/files/6df3ca984743cbc66e8020c883ecda1db56bc967
Modules/_datetimemodule.chttps://github.com/python/cpython/pull/8859/files/6df3ca984743cbc66e8020c883ecda1db56bc967#diff-3ee250e3806e884518fd872e9148baf532de6ec54c1cdb4e7679fbb2869d9c47
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#discussion_r211955927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8859
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#discussion_r211964433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8859
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#discussion_r211967081
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8859
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#discussion_r211981918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415034013
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415057287
Please reload this pagehttps://github.com/python/cpython/pull/8859
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/izbyshev
izbyshevhttps://github.com/izbyshev
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415062081
@taleinathttps://github.com/taleinat
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415068151
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415085245
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415096572
@taleinathttps://github.com/taleinat
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415102722
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415108834
@izbyshevhttps://github.com/izbyshev
#8850https://github.com/python/cpython/pull/8850
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415110506
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415110981
@pgansslehttps://github.com/pganssle
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415119997
Please reload this pagehttps://github.com/python/cpython/pull/8859
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415121629
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
bpo-34454: optimize, add tests and NEWShttps://github.com/python/cpython/pull/8859/commits/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1
3a02c2bhttps://github.com/python/cpython/pull/8859/commits/3a02c2b04e27f2deef6dac3a6820dc6d7b295eb1
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415146237
the PyUnicode_1BYTE_DATA() macrohttps://docs.python.org/3.8/c-api/unicode.html#c.PyUnicode_1BYTE_DATA
@izbyshevhttps://github.com/izbyshev
#8850https://github.com/python/cpython/pull/8850
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
serhiy-storchakahttps://github.com/serhiy-storchaka
August 22, 2018 19:11https://github.com/python/cpython/pull/8859#event-1803475776
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1803488872
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415149553
Please reload this pagehttps://github.com/python/cpython/pull/8859
#8862https://github.com/python/cpython/pull/8862
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1803498928
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 22, 2018https://github.com/python/cpython/pull/8859#event-1803499611
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415149823
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415153761
@pgansslehttps://github.com/pganssle
#8862https://github.com/python/cpython/pull/8862
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415156547
@taleinathttps://github.com/taleinat
#8862https://github.com/python/cpython/pull/8862
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018https://github.com/python/cpython/pull/8859#issuecomment-415174904
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/pganssle
pgansslehttps://github.com/pganssle
Aug 22, 2018 https://github.com/python/cpython/pull/8859#ref-pullrequest-353032214
bpo-34454: Fix issue with non-UTF8 separator strings #8862 https://github.com/python/cpython/pull/8862
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 23, 2018https://github.com/python/cpython/pull/8859#issuecomment-415458037
#8862https://github.com/python/cpython/pull/8862
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
taleinathttps://github.com/taleinat
Aug 23, 2018https://github.com/python/cpython/pull/8859#event-1805584467
https://github.com/taleinat
taleinathttps://github.com/taleinat
August 24, 2018 11:17https://github.com/python/cpython/pull/8859#event-1807427207
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8859
https://github.com/pganssle
pganssle https://github.com/pganssle
https://github.com/python/cpython/pull/8859/files/6df3ca984743cbc66e8020c883ecda1db56bc967
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/8859
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/8859
https://github.com/taleinat
https://github.com/pganssle
https://github.com/izbyshev
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.