René's URL Explorer Experiment


Title: bpo-34423: Fix check for overflow when casting from a double to integral types. by enedil · Pull Request #8802 · python/cpython · GitHub

Open Graph Title: bpo-34423: Fix check for overflow when casting from a double to integral types. by enedil · Pull Request #8802 · python/cpython

X Title: bpo-34423: Fix check for overflow when casting from a double to integral types. by enedil · Pull Request #8802 · python/cpython

Description: The added comment explains the issue. This fix disallows overflow: if a double d passes the test, it can mean that d == 2**63. When casted to int64_t, the variable overflows to -2**63. https://bug...

Open Graph Description: The added comment explains the issue. This fix disallows overflow: if a double d passes the test, it can mean that d == 2**63. When casted to int64_t, the variable overflows to -2**63. https://bug...

X Description: The added comment explains the issue. This fix disallows overflow: if a double d passes the test, it can mean that d == 2**63. When casted to int64_t, the variable overflows to -2**63. https://bug...

Opengraph URL: https://github.com/python/cpython/pull/8802

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:511ed4cc-5c1a-5203-8b21-a23a39515065
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2CE:1254A9:AD967B:F01A7C:696A857B
html-safe-nonce7d05fdf5dcc556b7da0f49d4458c220326bc3f55ac6e23f7ce767055b4c8fa7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkNFOjEyNTRBOTpBRDk2N0I6RjAxQTdDOjY5NkE4NTdCIiwidmlzaXRvcl9pZCI6Ijc4MzU4NjU3MDgxNDExMTg4NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceda03b67d5b5f86835411c9d971669a6ab9f415831cb7ff3eff22159fe04f140
hovercard-subject-tagpull_request:209280553
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8802/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1ced375728066215d30cc95fd3453d5ed318e2832a1e449936242405969e5bed/python/cpython/pull/8802
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1ced375728066215d30cc95fd3453d5ed318e2832a1e449936242405969e5bed/python/cpython/pull/8802
og:image:altThe added comment explains the issue. This fix disallows overflow: if a double d passes the test, it can mean that d == 2**63. When casted to int64_t, the variable overflows to -2**63. https://bug...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameenedil
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8802#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8802
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8802
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8802
Reloadhttps://github.com/python/cpython/pull/8802
Reloadhttps://github.com/python/cpython/pull/8802
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8802
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/8802
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/8802#issue-comment-box
enedilhttps://github.com/enedil
python:mainhttps://github.com/python/cpython/tree/main
enedil:fix-issue-323676-masterhttps://github.com/enedil/cpython/tree/fix-issue-323676-master
bpo-34423: Fix check for overflow when casting from a double to integral types. https://github.com/python/cpython/pull/8802#top
enedilhttps://github.com/enedil
python:mainhttps://github.com/python/cpython/tree/main
enedil:fix-issue-323676-masterhttps://github.com/enedil/cpython/tree/fix-issue-323676-master
Conversation 12 https://github.com/python/cpython/pull/8802
Commits 5 https://github.com/python/cpython/pull/8802/commits
Checks 0 https://github.com/python/cpython/pull/8802/checks
Files changed https://github.com/python/cpython/pull/8802/files
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/enedil
enedilhttps://github.com/enedil
Aug 17, 2018https://github.com/python/cpython/pull/8802#issue-351769118
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://bugs.python.org/issue34423https://bugs.python.org/issue34423
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/enedil
bpo-32367: Fix check for overflow when casting from a double to integ…https://github.com/python/cpython/pull/8802/commits/c05d58df30185aebfce82952aee4752069542be8
c05d58dhttps://github.com/python/cpython/pull/8802/commits/c05d58df30185aebfce82952aee4752069542be8
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 17, 2018https://github.com/python/cpython/pull/8802#event-1795739254
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 17, 2018https://github.com/python/cpython/pull/8802#event-1795739262
https://github.com/enedil
ACKS and blurb updatehttps://github.com/python/cpython/pull/8802/commits/58b69f0d9c38a9587b3dc2bb0581a216e1ecd1c4
58b69f0https://github.com/python/cpython/pull/8802/commits/58b69f0d9c38a9587b3dc2bb0581a216e1ecd1c4
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 19, 2018https://github.com/python/cpython/pull/8802#issuecomment-414154524
https://bugs.python.org/issue34423https://bugs.python.org/issue34423
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/enedil
enedilhttps://github.com/enedil
Aug 19, 2018https://github.com/python/cpython/pull/8802#issuecomment-414155724
@asottilehttps://github.com/asottile
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 19, 2018https://github.com/python/cpython/pull/8802#issuecomment-414156150
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/enedil
enedilhttps://github.com/enedil
Aug 19, 2018https://github.com/python/cpython/pull/8802#event-1796504401
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Aug 20, 2018https://github.com/python/cpython/pull/8802#event-1796804685
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 20, 2018 https://github.com/python/cpython/pull/8802#pullrequestreview-147840460
View reviewed changes https://github.com/python/cpython/pull/8802/files/58b69f0d9c38a9587b3dc2bb0581a216e1ecd1c4
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/8802#pullrequestreview-147840460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8802
enedilhttps://github.com/enedil
August 21, 2018 14:02https://github.com/python/cpython/pull/8802#commits-pushed-f5a7b94
https://github.com/enedil
Bound checks for time.sleephttps://github.com/python/cpython/pull/8802/commits/f5a7b9491cb6155503e308ca14ed32f4f63254a0
f5a7b94https://github.com/python/cpython/pull/8802/commits/f5a7b9491cb6155503e308ca14ed32f4f63254a0
https://github.com/enedil
Test updatehttps://github.com/python/cpython/pull/8802/commits/cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25
cc0bcdahttps://github.com/python/cpython/pull/8802/commits/cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 21, 2018 https://github.com/python/cpython/pull/8802#pullrequestreview-148128995
View reviewed changes https://github.com/python/cpython/pull/8802/files/cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25
Lib/test/test_time.pyhttps://github.com/python/cpython/pull/8802/files/cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25#diff-b0b95b7028b45727e52c7fd7c05f5ccd6f1b907496c416a5eacd771f45a20ae8
asottilehttps://github.com/asottile
Aug 21, 2018https://github.com/python/cpython/pull/8802#discussion_r211660044
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/enedil
Revert typohttps://github.com/python/cpython/pull/8802/commits/4e2c8b82abe6ed119382e972018a210aa64c0d4e
4e2c8b8https://github.com/python/cpython/pull/8802/commits/4e2c8b82abe6ed119382e972018a210aa64c0d4e
https://github.com/jdemeyer
jdemeyerhttps://github.com/jdemeyer
Feb 4, 2019 https://github.com/python/cpython/pull/8802#pullrequestreview-199528856
View reviewed changes https://github.com/python/cpython/pull/8802/files/4e2c8b82abe6ed119382e972018a210aa64c0d4e
jdemeyerhttps://github.com/jdemeyer
https://github.com/python/cpython/pull/8802#pullrequestreview-199528856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 4, 2019https://github.com/python/cpython/pull/8802#event-2115338930
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Feb 13, 2019https://github.com/python/cpython/pull/8802#issuecomment-463286941
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/jdemeyer
jdemeyerhttps://github.com/jdemeyer
Feb 13, 2019https://github.com/python/cpython/pull/8802#issuecomment-463359474
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/ezio-melotti
ezio-melottihttps://github.com/ezio-melotti
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 13, 2022https://github.com/python/cpython/pull/8802#event-6988864998
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Dec 7, 2022 https://github.com/python/cpython/pull/8802#pullrequestreview-1208964706
View reviewed changes https://github.com/python/cpython/pull/8802/files/4e2c8b82abe6ed119382e972018a210aa64c0d4e
iritkatrielhttps://github.com/iritkatriel
https://github.com/python/cpython/pull/8802#pullrequestreview-1208964706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Dec 7, 2022https://github.com/python/cpython/pull/8802#event-7981032209
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Dec 7, 2022https://github.com/python/cpython/pull/8802#issuecomment-1341438634
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Dec 7, 2022https://github.com/python/cpython/pull/8802#event-7981032295
https://github.com/enedil
enedilhttps://github.com/enedil
Dec 7, 2022https://github.com/python/cpython/pull/8802#issuecomment-1341726097
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Dec 8, 2022https://github.com/python/cpython/pull/8802#issuecomment-1342556406
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Dec 8, 2022https://github.com/python/cpython/pull/8802#event-7987931672
https://github.com/python/cpython/pull/8802
enedilhttps://github.com/python/cpython/pull/8802
Dec 8, 2022 https://github.com/python/cpython/pull/8802#ref-issue-1198996353
Overflow when casting from double to time_t, and_PyTime_t. #78604 https://github.com/python/cpython/issues/78604
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8802
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/8802/files/58b69f0d9c38a9587b3dc2bb0581a216e1ecd1c4
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/8802/files/4e2c8b82abe6ed119382e972018a210aa64c0d4e
https://github.com/jdemeyer
jdemeyer https://github.com/jdemeyer
https://github.com/python/cpython/pull/8802/files/4e2c8b82abe6ed119382e972018a210aa64c0d4e
https://github.com/asottile
asottile https://github.com/asottile
https://github.com/python/cpython/pull/8802/files/cc0bcdaf991506b07b050fb4e3eab1cfed0ccd25
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Please reload this pagehttps://github.com/python/cpython/pull/8802
https://github.com/enedil
https://github.com/asottile
https://github.com/vstinner
https://github.com/jdemeyer
https://github.com/bedevere-bot
https://github.com/iritkatriel
https://github.com/the-knights-who-say-ni
https://github.com/ezio-melotti
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.