René's URL Explorer Experiment


Title: [3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) by serhiy-storchaka · Pull Request #8581 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) by serhiy-storchaka · Pull Request #8581 · python/cpython

X Title: [3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) by serhiy-storchaka · Pull Request #8581 · python/cpython

Description: help(hashlib) didn't work because of incorrect module name in blake2b and blake2s classes. Constructors blake2*(), sha3_(), shake_() and keccak_*() incorrectly accepted keyword argument "string" for binary data, but documented as accepting the "data" keyword argument. Now this parameter is positional-only. Keyword-only parameters in blake2b() and blake2s() were not documented as keyword-only. Default value for some parameters of blake2b() and blake2s() was None, which is not acceptable value. The length argument for shake_*.digest() was wrapped out to 32 bits. The argument for shake_128.digest() and shake_128.hexdigest() was not positional-only as intended. TypeError messages for incorrect arguments in all constructors sha3_(), shake_() and keccak_*() incorrectly referred to sha3_224. Also made the following enhancements: More accurately specified input and result types for strings, bytes and bytes-like objects. Unified positional parameter names for update() and constructors. Improved formatting.. (cherry picked from commit f1d36d8) https://bugs.python.org/issue33729

Open Graph Description: help(hashlib) didn't work because of incorrect module name in blake2b and blake2s classes. Constructors blake2*(), sha3_(), shake_() and keccak_*() incorrectly accepted keyword argument "s...

X Description: help(hashlib) didn't work because of incorrect module name in blake2b and blake2s classes. Constructors blake2*(), sha3_(), shake_() and keccak_*() incorrectly accepted keyword argument &am...

Opengraph URL: https://github.com/python/cpython/pull/8581

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:819fcf3d-3b54-1374-c53e-644844dc5cf8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA0C:3D97C8:3664DAA:4853532:6B020874
html-safe-nonce3eaf420ec8033658049b6c69d4c4cd986091f4addc59019d662d9eff4e4129c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTBDOjNEOTdDODozNjY0REFBOjQ4NTM1MzI6NkIwMjA4NzQiLCJ2aXNpdG9yX2lkIjoiMjEwMzk2MzU3ODM4NjM3MTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac180af60468ae3d6275d65eabd59c0cad07be2efb210d8b4a4a9566788ba64862
hovercard-subject-tagpull_request:205013381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8581/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:althelp(hashlib) didn't work because of incorrect module name in blake2b and blake2s classes. Constructors blake2*(), sha3_(), shake_() and keccak_*() incorrectly accepted keyword argument "s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8581/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8581%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8581%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8581/files
Reloadhttps://github.com/python/cpython/pull/8581/files
Reloadhttps://github.com/python/cpython/pull/8581/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:3.7https://github.com/python/cpython/tree/3.7
serhiy-storchaka:backport-f1d36d8-3.7https://github.com/serhiy-storchaka/cpython/tree/backport-f1d36d8-3.7
Conversation 0 https://github.com/python/cpython/pull/8581
Commits 1 https://github.com/python/cpython/pull/8581/commits
Checks 0 https://github.com/python/cpython/pull/8581/checks
Files changed https://github.com/python/cpython/pull/8581/files
Please reload this pagehttps://github.com/python/cpython/pull/8581/files
[3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) https://github.com/python/cpython/pull/8581/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/8581/files
1306ef9 [3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) serhiy-storchaka Jul 31, 2018 https://github.com/python/cpython/pull/8581/commits/1306ef9b1ac1e71e9e9e120e49846f9031a67f82
Clear filters https://github.com/python/cpython/pull/8581/files
Please reload this pagehttps://github.com/python/cpython/pull/8581/files
Please reload this pagehttps://github.com/python/cpython/pull/8581/files
hashlib.rst https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
hashlib.py https://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
test_hashlib.py https://github.com/python/cpython/pull/8581/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
2018-07-20-09-11-05.bpo-33729.sO6iTb.rst https://github.com/python/cpython/pull/8581/files#diff-d001fc5641df381e550b9551ba3c9392a3e02b0cc64b0aaa16fa03fc06d1b3d5
blake2b_impl.c https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
blake2s_impl.c https://github.com/python/cpython/pull/8581/files#diff-10dcbcb43ffc841fa569ea3e5a6684ca2102a44313fc0517564f7c0a5f1dc591
blake2b_impl.c.h https://github.com/python/cpython/pull/8581/files#diff-0e934af01eed81db4b2e3e8827f93f24e7efe88712854f39290af0e56db818c4
blake2s_impl.c.h https://github.com/python/cpython/pull/8581/files#diff-88feb9ccf60179384035a399d6c7ddb7afd52d9cd45cd7389abdfc448146c0e7
_hashopenssl.c https://github.com/python/cpython/pull/8581/files#diff-b4fd2e5e447a6f18fb2508c350524c5cb1feed8ec92d70822eac54431ef71baf
sha3module.c.h https://github.com/python/cpython/pull/8581/files#diff-ae793195afe6139260189a41b50fda9ccc1373ff97b17b574690c7f2c8634d89
sha3module.c https://github.com/python/cpython/pull/8581/files#diff-5020106d8293d04a15f5387793a9dc7bbb35f0dba7c0896b0058b94ad6e28645
_hashopenssl.c.h https://github.com/python/cpython/pull/8581/files#diff-16316e5c8c87ddc7be1a96c2228bd1761083d1fd46760c29f4ac05e94b7712d7
Doc/library/hashlib.rsthttps://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
View file https://github.com/serhiy-storchaka/cpython/blob/1306ef9b1ac1e71e9e9e120e49846f9031a67f82/Doc/library/hashlib.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8581/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
https://github.com/python/cpython/pull/8581/files#diff-0d90b77d1e355b48c64da175b6d6e9bf9fd3a01a0daa695ce0405c41e207276a
Lib/hashlib.pyhttps://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
View file https://github.com/serhiy-storchaka/cpython/blob/1306ef9b1ac1e71e9e9e120e49846f9031a67f82/Lib/hashlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8581/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
https://github.com/python/cpython/pull/8581/files#diff-7b5c7281635ea9d475e73fab120a94e42f591eae502af924184140acab4cc189
Lib/test/test_hashlib.pyhttps://github.com/python/cpython/pull/8581/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
View file https://github.com/serhiy-storchaka/cpython/blob/1306ef9b1ac1e71e9e9e120e49846f9031a67f82/Lib/test/test_hashlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8581/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8581/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/pull/8581/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
Misc/NEWS.d/next/Library/2018-07-20-09-11-05.bpo-33729.sO6iTb.rsthttps://github.com/python/cpython/pull/8581/files#diff-d001fc5641df381e550b9551ba3c9392a3e02b0cc64b0aaa16fa03fc06d1b3d5
View file https://github.com/serhiy-storchaka/cpython/blob/1306ef9b1ac1e71e9e9e120e49846f9031a67f82/Misc/NEWS.d/next/Library/2018-07-20-09-11-05.bpo-33729.sO6iTb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8581/{{ revealButtonHref }}
Modules/_blake2/blake2b_impl.chttps://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
View file https://github.com/serhiy-storchaka/cpython/blob/1306ef9b1ac1e71e9e9e120e49846f9031a67f82/Modules/_blake2/blake2b_impl.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8581/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
https://github.com/python/cpython/pull/8581/files#diff-3d476016362797072ff7999bac0082764a94a992850bfd19a6b124e494e1d2c1
Please reload this pagehttps://github.com/python/cpython/pull/8581/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.