René's URL Explorer Experiment


Title: bpo-34217: Fix include "Windows.h" case for cross-compiling by erikjanss · Pull Request #8472 · python/cpython · GitHub

Open Graph Title: bpo-34217: Fix include "Windows.h" case for cross-compiling by erikjanss · Pull Request #8472 · python/cpython

X Title: bpo-34217: Fix include "Windows.h" case for cross-compiling by erikjanss · Pull Request #8472 · python/cpython

Description: one more uppercase windows header found in _iomodule.c, no other occurences of "Windows.h" found https://bugs.python.org/issue34217

Open Graph Description: one more uppercase windows header found in _iomodule.c, no other occurences of "Windows.h" found https://bugs.python.org/issue34217

X Description: one more uppercase windows header found in _iomodule.c, no other occurences of "Windows.h" found https://bugs.python.org/issue34217

Opengraph URL: https://github.com/python/cpython/pull/8472

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be996aef-0272-fd66-f6ae-12c12492510b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4C6:511EE:1918A5:221C4C:696965FB
html-safe-nonce5c2814175ee1653ed5f3146a6a7dab7527b25b6386567cb4f35a8d9a814ff519
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEM2OjUxMUVFOjE5MThBNToyMjFDNEM6Njk2OTY1RkIiLCJ2aXNpdG9yX2lkIjoiMzk0Njk0NDE2NTAzODM1MTg2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac100256744508849fb3ca525d6e921fc57d8212e9097ff3ab45740968beed3450
hovercard-subject-tagpull_request:203962901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8472/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2cd34c5dab438eca57c0ecf5089f238c795e25ab95e9e956a72058afb8144aa2/python/cpython/pull/8472
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2cd34c5dab438eca57c0ecf5089f238c795e25ab95e9e956a72058afb8144aa2/python/cpython/pull/8472
og:image:altone more uppercase windows header found in _iomodule.c, no other occurences of "Windows.h" found https://bugs.python.org/issue34217
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerikjanss
hostnamegithub.com
expected-hostnamegithub.com
None48487c1ad776a7975b7132d95f4240ff3ae37cd5b8e3cb597102a4edb76738f1
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release669463fcc54773a88c1f5a44eef6b99a5504b9c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8472#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8472
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8472
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8472
Reloadhttps://github.com/python/cpython/pull/8472
Reloadhttps://github.com/python/cpython/pull/8472
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8472
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/8472
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/8472#issue-comment-box
methanehttps://github.com/methane
python:masterhttps://github.com/python/cpython/tree/master
bpo-34217: Fix include "Windows.h" case for cross-compiling https://github.com/python/cpython/pull/8472#top
methanehttps://github.com/methane
python:masterhttps://github.com/python/cpython/tree/master
Conversation 3 https://github.com/python/cpython/pull/8472
Commits 3 https://github.com/python/cpython/pull/8472/commits
Checks 0 https://github.com/python/cpython/pull/8472/checks
Files changed https://github.com/python/cpython/pull/8472/files
Please reload this pagehttps://github.com/python/cpython/pull/8472
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erikjanss
erikjansshttps://github.com/erikjanss
Jul 25, 2018https://github.com/python/cpython/pull/8472#issue-344606558
Please reload this pagehttps://github.com/python/cpython/pull/8472
https://bugs.python.org/issue34217https://bugs.python.org/issue34217
Please reload this pagehttps://github.com/python/cpython/pull/8472
erikjansshttps://github.com/erikjanss
July 25, 2018 01:44https://github.com/python/cpython/pull/8472#commits-pushed-e593655
https://github.com/erikjanss
bpo-34217https://bugs.python.org/issue?@action=redirect&bpo=34217
: use lowercase header for windows includeshttps://github.com/python/cpython/pull/8472/commits/e5936552e1f3b3e2c10edbe9250e888bc6687584
e593655https://github.com/python/cpython/pull/8472/commits/e5936552e1f3b3e2c10edbe9250e888bc6687584
https://github.com/erikjanss
bpo-34217https://bugs.python.org/issue?@action=redirect&bpo=34217
: convert Windows.h include to windows.h in _iomodule.chttps://github.com/python/cpython/pull/8472/commits/c0bfe3a543165e04e0a4f847b52f51bd32cbd253
c0bfe3ahttps://github.com/python/cpython/pull/8472/commits/c0bfe3a543165e04e0a4f847b52f51bd32cbd253
https://github.com/erikjanss
erikjansshttps://github.com/erikjanss
code ownerhttps://github.com/python/cpython/blob/48ed88a93bb0bbeaae9a4cfaa533e4edf13bcb51/.github/CODEOWNERS#L44
July 25, 2018 21:04https://github.com/python/cpython/pull/8472#event-1753609188
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Jul 25, 2018https://github.com/python/cpython/pull/8472#issuecomment-407894957
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
Please reload this pagehttps://github.com/python/cpython/pull/8472
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Jul 25, 2018https://github.com/python/cpython/pull/8472#event-1753609298
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 25, 2018https://github.com/python/cpython/pull/8472#event-1753609319
https://github.com/methane
methanehttps://github.com/methane
Jul 27, 2018 https://github.com/python/cpython/pull/8472#pullrequestreview-141043873
View reviewed changes https://github.com/python/cpython/pull/8472/files/c0bfe3a543165e04e0a4f847b52f51bd32cbd253
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 27, 2018https://github.com/python/cpython/pull/8472#event-1756869156
https://github.com/zooba
zoobahttps://github.com/zooba
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
Jul 29, 2018https://github.com/python/cpython/pull/8472#event-1758814125
https://github.com/zooba
zoobahttps://github.com/zooba
Jul 29, 2018https://github.com/python/cpython/pull/8472#event-1758814313
https://github.com/Mariatta
Mariattahttps://github.com/Mariatta
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Jul 30, 2018https://github.com/python/cpython/pull/8472#event-1760779526
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 30, 2018https://github.com/python/cpython/pull/8472#event-1760779577
https://github.com/erikjanss
bpo-34217https://bugs.python.org/issue?@action=redirect&bpo=34217
: replace camelcase windows headers with lowercase in socket…https://github.com/python/cpython/pull/8472/commits/77a33231c7bc17a3ef82304b09302a87438dcac9
77a3323https://github.com/python/cpython/pull/8472/commits/77a33231c7bc17a3ef82304b09302a87438dcac9
https://github.com/methane
methanehttps://github.com/methane
e6a4755https://github.com/python/cpython/commit/e6a4755e6793942b950c1595e0c34bd66a0ee13e
Aug 16, 2018https://github.com/python/cpython/pull/8472#event-1791613665
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 16, 2018https://github.com/python/cpython/pull/8472#event-1791613715
https://github.com/methane
methanehttps://github.com/methane
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Aug 16, 2018https://github.com/python/cpython/pull/8472#event-1791613926
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 16, 2018https://github.com/python/cpython/pull/8472#issuecomment-413442123
@erikjansshttps://github.com/erikjanss
@methanehttps://github.com/methane
Please reload this pagehttps://github.com/python/cpython/pull/8472
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Aug 16, 2018https://github.com/python/cpython/pull/8472#event-1791614501
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 16, 2018https://github.com/python/cpython/pull/8472#issuecomment-413442203
GH-8782https://github.com/python/cpython/pull/8782
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/8472
miss-islingtonhttps://github.com/miss-islington
Aug 16, 2018 https://github.com/python/cpython/pull/8472#ref-commit-a132936
https://github.com/erikjanss
https://github.com/miss-islington
bpo-34217: Use lowercase for windows headers (https://github.com/miss-islington/cpython/commit/a132936ae0a5553c9ecf75b7336d14c0d019b41a
pythonGH-8472https://github.com/python/cpython/pull/8472
)https://github.com/miss-islington/cpython/commit/a132936ae0a5553c9ecf75b7336d14c0d019b41a
a132936https://github.com/miss-islington/cpython/commit/a132936ae0a5553c9ecf75b7336d14c0d019b41a
e6a4755https://github.com/miss-islington/cpython/commit/e6a4755e6793942b950c1595e0c34bd66a0ee13e
miss-islingtonhttps://github.com/miss-islington
Aug 16, 2018 https://github.com/python/cpython/pull/8472#ref-commit-bf8e9d1
https://github.com/miss-islington
https://github.com/erikjanss
bpo-34217https://bugs.python.org/issue?@action=redirect&bpo=34217
: Use lowercase for windows headers (https://github.com/python/cpython/commit/bf8e9d18dd75f58ce3b9761763ae10c0800b43d8
GH-8472https://github.com/python/cpython/pull/8472
)https://github.com/python/cpython/commit/bf8e9d18dd75f58ce3b9761763ae10c0800b43d8
bf8e9d1https://github.com/python/cpython/commit/bf8e9d18dd75f58ce3b9761763ae10c0800b43d8
e6a4755https://github.com/python/cpython/commit/e6a4755e6793942b950c1595e0c34bd66a0ee13e
carljmhttps://github.com/carljm
Aug 19, 2018 https://github.com/python/cpython/pull/8472#ref-commit-977ece0
https://github.com/carljm
Merge branch 'master' into cached-propertyhttps://github.com/carljm/cpython/commit/977ece0d44fe3b367967e74f15e86876b9420dec
977ece0https://github.com/carljm/cpython/commit/977ece0d44fe3b367967e74f15e86876b9420dec
pythonGH-8812https://github.com/python/cpython/pull/8812
pythonGH-8623https://github.com/python/cpython/pull/8623
pythonGH-8741https://github.com/python/cpython/pull/8741
pythonGH-8811https://github.com/python/cpython/pull/8811
pythonGH-8808https://github.com/python/cpython/pull/8808
pythonGH-8797https://github.com/python/cpython/pull/8797
pythonGH-8205https://github.com/python/cpython/pull/8205
python#6773https://github.com/python/cpython/pull/6773
pythonGH-8796https://github.com/python/cpython/pull/8796
pythonGH-8793https://github.com/python/cpython/pull/8793
pythonGH-8787https://github.com/python/cpython/pull/8787
pythonGH-8472https://github.com/python/cpython/pull/8472
pythonGH-8756https://github.com/python/cpython/pull/8756
pythonGH-8775https://github.com/python/cpython/pull/8775
pythonGH-8740https://github.com/python/cpython/pull/8740
pythonGH-4439https://github.com/python/cpython/pull/4439
python#8762https://github.com/python/cpython/pull/8762
pythonGH-8759https://github.com/python/cpython/pull/8759
pythonGH-8708https://github.com/python/cpython/pull/8708
pythonGH-8604https://github.com/python/cpython/pull/8604
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8472
https://github.com/methane
methane https://github.com/methane
https://github.com/python/cpython/pull/8472/files/c0bfe3a543165e04e0a4f847b52f51bd32cbd253
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/8472
https://github.com/erikjanss
https://github.com/the-knights-who-say-ni
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/methane
https://github.com/zooba
https://github.com/Mariatta
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.