René's URL Explorer Experiment


Title: bpo-34193: Fix pluralization in getargs.c and test cases by tirkarthi · Pull Request #8438 · python/cpython · GitHub

Open Graph Title: bpo-34193: Fix pluralization in getargs.c and test cases by tirkarthi · Pull Request #8438 · python/cpython

X Title: bpo-34193: Fix pluralization in getargs.c and test cases by tirkarthi · Pull Request #8438 · python/cpython

Description: Tests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better. You can wait a bit for other reviews before changing. I have changed the function names but I can change as per review comments But if we add all the remaining fixes needed in this file (see below), we could write. Fix pluralization in TypeError messages in getargs.c: '1 argument' instead of '1 arguments' and '1 element' instead of '1 elements'. Added a new blurb. Let me know if the old one needs edit and can be re-used or to have the current one. Scope: I think we should finish the job in the file. The next line in both else clauses, "unpacked tuple should have %s%zd elements," should get the same treatment. This may break existing tests. (These are the only two formatted 'elements'. Fixes for the following will break some test, which will then need fixing also. 542: "expected %d arguments, not %" PY_FORMAT_SIZE_T "d", 1720, "%.200s%s takes %s %d positional arguments" 1799, "%.200s%s takes %s %d positional arguments" 2106, " 0s%s takes %s %d positional arguments (%d given)", 2154: "%.200s%s takes %s %d positional arguments" I have fixed the above ones and there were some test case failures in test_capi and test_getargs which were fixed. Changes for 1799 line caused test case failures that were fixed. With respect to elements the code path is triggered only when fname is set as NULL and I couldn't find a function that passes fname as NULL. Almost all of them pass it as "" in case it's not present. I commented out the else block and tried running the test suite and had no failures. I think the code is not hit by any function. They were added as part of e4616e6 in 2001 and there are no test cases. I tried looking into argument clinic docs to see if I can come up with a format string and function to hit the respective code paths for the patch. But understanding the format string is little difficult for me since the ones I can come up with generate error with required argument and not positional argument. I think test coverage could be improved in these and I also don't know if we have tests that hit this code but don't check for the error message. I will try my hands at _testcapimodule.c to see if I can come up with tests. Any guidance on testing and argument clinic format string will be highly helpful. Thanks https://bugs.python.org/issue34193

Open Graph Description: Tests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better...

X Description: Tests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better...

Opengraph URL: https://github.com/python/cpython/pull/8438

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:caf5c209-28b7-abac-fcf2-387c31a1b4ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9604:2E3FEE:46CC26E:596E536:6B02384C
html-safe-nonce42b19521e75ac3312d7ac41e35b89d17f6e120b5846036e9068c9849bc03ab2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjA0OjJFM0ZFRTo0NkNDMjZFOjU5NkU1MzY6NkIwMjM4NEMiLCJ2aXNpdG9yX2lkIjoiMzIxMDYxMTQ3MTQ0MDU1ODE1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8101efe618bdfd3e360f2fe78b284b39f046a9ee330e586e3d3a3f7dfe2ef617
hovercard-subject-tagpull_request:203506810
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8438/files
twitter:imagehttps://avatars.githubusercontent.com/u/3972343?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3972343?s=400&v=4
og:image:altTests: In the 3 tests before this, the suffix 0, 2, or 3 is the number of arguments given. This would suggest 0a, 0b, 2a, and 3a for the suffixes here. I like 1min, 2min, 1max, and 2max even better...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8438/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8438%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8438%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8438/files
Reloadhttps://github.com/python/cpython/pull/8438/files
Reloadhttps://github.com/python/cpython/pull/8438/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo34193https://github.com/tirkarthi/cpython/tree/bpo34193
Conversation 1 https://github.com/python/cpython/pull/8438
Commits 4 https://github.com/python/cpython/pull/8438/commits
Checks 0 https://github.com/python/cpython/pull/8438/checks
Files changed https://github.com/python/cpython/pull/8438/files
Please reload this pagehttps://github.com/python/cpython/pull/8438/files
bpo-34193: Fix pluralization in getargs.c and test cases https://github.com/python/cpython/pull/8438/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/8438/files
b5c175a Fix pluralization in getargs.c and test cases tirkarthi Jul 24, 2018 https://github.com/python/cpython/pull/8438/commits/b5c175a28fae4cc4ee93314f577d0ab30ffb892c
4e1b6cc Add NEWS entry tirkarthi Jul 24, 2018 https://github.com/python/cpython/pull/8438/commits/4e1b6cc7a5f82a3a80c0d2552c048e6cd64b9cdf
57b75b4 Fix pluralization in typeobject.c and add test and NEWS entry tirkarthi Jul 25, 2018 https://github.com/python/cpython/pull/8438/commits/57b75b475d1823b0463cfcabd12063604b46e1cb
c36bdc3 Fix test_getargs2 as part of merge tirkarthi Dec 21, 2018 https://github.com/python/cpython/pull/8438/commits/c36bdc305227aae5f8a5fc830bc1b613369fae09
Clear filters https://github.com/python/cpython/pull/8438/files
Please reload this pagehttps://github.com/python/cpython/pull/8438/files
Please reload this pagehttps://github.com/python/cpython/pull/8438/files
test_call.py https://github.com/python/cpython/pull/8438/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
test_getargs2.py https://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
2018-07-24-11-57-35.bpo-34193.M6ch1Q.rst https://github.com/python/cpython/pull/8438/files#diff-5a0adb805fc55c4e5d0a7bead8a3be2a43cd7bcb2275d10d124a1d3f07269cf4
typeobject.c https://github.com/python/cpython/pull/8438/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
getargs.c https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
Lib/test/test_call.pyhttps://github.com/python/cpython/pull/8438/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
View file https://github.com/tirkarthi/cpython/blob/c36bdc305227aae5f8a5fc830bc1b613369fae09/Lib/test/test_call.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8438/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8438/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
https://github.com/python/cpython/pull/8438/files#diff-f27c08f13ff54ee9a69325f9291a3a2510a05b82ff8d813a8ab2e0072af632bb
Lib/test/test_getargs2.pyhttps://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
View file https://github.com/tirkarthi/cpython/blob/c36bdc305227aae5f8a5fc830bc1b613369fae09/Lib/test/test_getargs2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8438/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
https://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
https://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
https://github.com/python/cpython/pull/8438/files#diff-f44b47da714dd7689d4a6053a90872f022586917d1f579d22276c7165d812b02
Misc/NEWS.d/next/C API/2018-07-24-11-57-35.bpo-34193.M6ch1Q.rsthttps://github.com/python/cpython/pull/8438/files#diff-5a0adb805fc55c4e5d0a7bead8a3be2a43cd7bcb2275d10d124a1d3f07269cf4
View file https://github.com/tirkarthi/cpython/blob/c36bdc305227aae5f8a5fc830bc1b613369fae09/Misc/NEWS.d/next/C%20API/2018-07-24-11-57-35.bpo-34193.M6ch1Q.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8438/{{ revealButtonHref }}
Objects/typeobject.chttps://github.com/python/cpython/pull/8438/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/tirkarthi/cpython/blob/c36bdc305227aae5f8a5fc830bc1b613369fae09/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8438/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8438/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/8438/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Python/getargs.chttps://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
View file https://github.com/tirkarthi/cpython/blob/c36bdc305227aae5f8a5fc830bc1b613369fae09/Python/getargs.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8438/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com/python/cpython/pull/8438/files#diff-3a8078954be00d3c876e02dd0e5057aad07f2c5f82f6c3c76154dcf2866929cf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.