René's URL Explorer Experiment


Title: bpo-34060: Report system load when running test suite for Windows by ammaraskar · Pull Request #8357 · python/cpython · GitHub

Open Graph Title: bpo-34060: Report system load when running test suite for Windows by ammaraskar · Pull Request #8357 · python/cpython

X Title: bpo-34060: Report system load when running test suite for Windows by ammaraskar · Pull Request #8357 · python/cpython

Description: This is (mostly) a pure Python implementation of the other PR. It leverages the typeperf command which monitors performance counters and outputs them at a given interval. So every 5 seconds, typeperf can output the processor queue length into stdout. subprocess.stdout.readline is a blocking call. Using a thread seemed like an obvious solution, but we can't achieve this with multiprocessing or a thread, because like Victor speculated in the previous bug report on this, it conflicts with test_multiprocessing and test_threading. Hence, I opted to use the asynchronous/overlapped IO API which was designed for async. Most of the diff actually just pertains to using this rather low level API. This is almost a pure python implementation but there was one edge case where this would fail. Namely, when the python interpreter running the test suite crashes, this leaves an orphaned typeperf process running which refuses to die. This means that when the test suite is run with -j x and this situation happens: python -m test -j2 ├── python │ └── typeperf.exe └── python *CRASHED* └── typeperf.exe The big test coordinating python process will wait forever on the crashed python and consequently typeperf to terminate, which just doesn't happen by default in Windows. After reading up on the APIs, the right way to fix this is by using a Job Object to ask the OS to kill the child when the parent dies. Hence, there is a change in _winapi to make this happen. Unlike the last PR, this API is actually reusable and fit to be exposed to the public. It could even allow implementing things like bpo-5115 to be a lot easier. https://bugs.python.org/issue34060

Open Graph Description: This is (mostly) a pure Python implementation of the other PR. It leverages the typeperf command which monitors performance counters and outputs them at a given interval. So every 5 seconds, typepe...

X Description: This is (mostly) a pure Python implementation of the other PR. It leverages the typeperf command which monitors performance counters and outputs them at a given interval. So every 5 seconds, typepe...

Opengraph URL: https://github.com/python/cpython/pull/8357

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:169165d0-ce26-8e98-c703-0a62e2b21d87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE476:19B879:23BAEA8:31EF77B:6A54A1EF
html-safe-nonce592704497f9b5987fc9a1f7d43fcaba0d6b2361f89d168e343122eeb96db186c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDc2OjE5Qjg3OToyM0JBRUE4OjMxRUY3N0I6NkE1NEExRUYiLCJ2aXNpdG9yX2lkIjoiNDYyNjgwNDk5MTE2MzUxOTgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1001cdd37def843353661e0d620ca7c39837cfb691bf6f217e725b1230a73520
hovercard-subject-tagpull_request:202948321
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8357/files
twitter:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
og:image:altThis is (mostly) a pure Python implementation of the other PR. It leverages the typeperf command which monitors performance counters and outputs them at a given interval. So every 5 seconds, typepe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8cfff6384f62259baea531c7f58bc7040f8dd92
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8357/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8357%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8357%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8357/files
Reloadhttps://github.com/python/cpython/pull/8357/files
Reloadhttps://github.com/python/cpython/pull/8357/files
Please reload this pagehttps://github.com/python/cpython/pull/8357/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8357/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
csabellahttps://github.com/csabella
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:windows_load2https://github.com/ammaraskar/cpython/tree/windows_load2
Conversation 45 https://github.com/python/cpython/pull/8357
Commits 4 https://github.com/python/cpython/pull/8357/commits
Checks 0 https://github.com/python/cpython/pull/8357/checks
Files changed https://github.com/python/cpython/pull/8357/files
Please reload this pagehttps://github.com/python/cpython/pull/8357/files
bpo-34060: Report system load when running test suite for Windows https://github.com/python/cpython/pull/8357/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/8357/files
4ad86c2 bpo-34060: Report system load when running test suite for Windows ammaraskar Jul 21, 2018 https://github.com/python/cpython/pull/8357/commits/4ad86c2a5a9bdb75c7dfcb9be4d2c08101c26857
00a0895 Move windows specific code to its own file ammaraskar Jul 25, 2018 https://github.com/python/cpython/pull/8357/commits/00a0895aad79f8355b471f03d4c638a70a905bf2
5c0e275 Move imports to top of file ammaraskar Jul 25, 2018 https://github.com/python/cpython/pull/8357/commits/5c0e27553edca6252b35e8eda0e0655ab910e08e
a8df864 Add comment explaining check in libregrtest ammaraskar Feb 9, 2019 https://github.com/python/cpython/pull/8357/commits/a8df864ce11df46a8632da9cfa55e3d53db1d856
Clear filters https://github.com/python/cpython/pull/8357/files
Please reload this pagehttps://github.com/python/cpython/pull/8357/files
Please reload this pagehttps://github.com/python/cpython/pull/8357/files
main.py https://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
win_utils.py https://github.com/python/cpython/pull/8357/files#diff-5c8d19d7a91363867183446443b2b3237a4b30af6f43583467b49aed5485b462
2018-07-20-13-09-19.bpo-34060.v-z87j.rst https://github.com/python/cpython/pull/8357/files#diff-611846bbfd27d8d35ff0c99166ff4a00386cd48cd5177a878051a0c602b2e29f
Lib/test/libregrtest/main.pyhttps://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
View file https://github.com/ammaraskar/cpython/blob/a8df864ce11df46a8632da9cfa55e3d53db1d856/Lib/test/libregrtest/main.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8357/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
https://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
https://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
https://github.com/python/cpython/pull/8357/files#diff-90b1258926545f5c3c67e7de0cb5f50dc293b41c7a075a3eb316df99f3b875d5
Lib/test/libregrtest/win_utils.pyhttps://github.com/python/cpython/pull/8357/files#diff-5c8d19d7a91363867183446443b2b3237a4b30af6f43583467b49aed5485b462
View file https://github.com/ammaraskar/cpython/blob/a8df864ce11df46a8632da9cfa55e3d53db1d856/Lib/test/libregrtest/win_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8357/{{ revealButtonHref }}
Misc/NEWS.d/next/Windows/2018-07-20-13-09-19.bpo-34060.v-z87j.rsthttps://github.com/python/cpython/pull/8357/files#diff-611846bbfd27d8d35ff0c99166ff4a00386cd48cd5177a878051a0c602b2e29f
View file https://github.com/ammaraskar/cpython/blob/a8df864ce11df46a8632da9cfa55e3d53db1d856/Misc/NEWS.d/next/Windows/2018-07-20-13-09-19.bpo-34060.v-z87j.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8357/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.