René's URL Explorer Experiment


Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython · GitHub

Open Graph Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython

X Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython

Description: bpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not released (by err_input()) on E_ERROR error. Remove also "with Barry as BDFL, use '<>' instead of '!='" static string error message (previously set to err_ret->text) because in practice, err_ret->text is always set later. Add also an assertion to make sure that err_ret->text is only set once. Replace old PyObject_MALLOC() and PyObject_FREE() aliases with PyObject_Malloc() and PyObject_Free() function calls. Co-Authored-By: Serhiy Storchaka storchaka@gmail.com Co-Authored-By: Xiang Zhang angwerzx@126.com https://bugs.python.org/issue34080

Open Graph Description: bpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not released (by err_i...

X Description: bpo-34080, bpo-34084: err_free() now always releases &#39;text&#39; memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err-&gt;text was not releas...

Opengraph URL: https://github.com/python/cpython/pull/8242

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0686dfef-2967-0758-7923-0d1a6874cadc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FDE:30CB25:12F44E:1988DF:6A5512CA
html-safe-nonce2e0f5d5673ff3eb13798712dcbec361444aef63d7ce6520eb8a5b5ef05d7d4c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkRFOjMwQ0IyNToxMkY0NEU6MTk4OERGOjZBNTUxMkNBIiwidmlzaXRvcl9pZCI6IjUzMzc3MTI1ODMzMjY4OTY4NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0e239b71ffc0e82fcb02eceb3e2303ce3e7335f9cefd895827dfd41e8e50c7e9
hovercard-subject-tagpull_request:200637525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8242/files
twitter:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/194129?s=400&v=4
og:image:altbpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not released (by err_i...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0f2adbaa4b43ea302b02981f637a782ae92ed6dc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8242/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8242%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8242%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8242/files
Reloadhttps://github.com/python/cpython/pull/8242/files
Reloadhttps://github.com/python/cpython/pull/8242/files
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversation 17 https://github.com/python/cpython/pull/8242
Commits 2 https://github.com/python/cpython/pull/8242/commits
Checks 0 https://github.com/python/cpython/pull/8242/checks
Files changed https://github.com/python/cpython/pull/8242/files
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
bpo-34080: Fix memory leak on parsing error https://github.com/python/cpython/pull/8242/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/8242/files
6224531 bpo-34080: Fix memory leak on parsing error vstinner Jul 11, 2018 https://github.com/python/cpython/pull/8242/commits/622453192f7c385e79a1560fdb7fa6e2899cdd64
fdf73c9 Only clear err->text in err_free() vstinner Jul 11, 2018 https://github.com/python/cpython/pull/8242/commits/fdf73c9036aad00b0ca5a309734cd2a62329bab8
Clear filters https://github.com/python/cpython/pull/8242/files
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
2018-07-11-11-20-12.bpo-34080.8t7PtO.rst https://github.com/python/cpython/pull/8242/files#diff-aa5730cbc4644c643ded5db4464b3585db2526dd01c79c6230f96ff397ba19cc
parsetok.c https://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
pythonrun.c https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
Misc/NEWS.d/next/Core and Builtins/2018-07-11-11-20-12.bpo-34080.8t7PtO.rsthttps://github.com/python/cpython/pull/8242/files#diff-aa5730cbc4644c643ded5db4464b3585db2526dd01c79c6230f96ff397ba19cc
View file https://github.com/python/cpython/blob/fdf73c9036aad00b0ca5a309734cd2a62329bab8/Misc/NEWS.d/next/Core%20and%20Builtins/2018-07-11-11-20-12.bpo-34080.8t7PtO.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8242/{{ revealButtonHref }}
Parser/parsetok.chttps://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
View file https://github.com/python/cpython/blob/fdf73c9036aad00b0ca5a309734cd2a62329bab8/Parser/parsetok.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8242/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
https://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
https://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
https://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
Python/pythonrun.chttps://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
View file https://github.com/python/cpython/blob/fdf73c9036aad00b0ca5a309734cd2a62329bab8/Python/pythonrun.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8242/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242/files#r201706832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8222https://github.com/python/cpython/pull/8222
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242/files#r201730682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8242/files
https://github.com/python/cpython/pull/8242/files#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.