René's URL Explorer Experiment


Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython · GitHub

Open Graph Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython

X Title: bpo-34080: Fix memory leak on parsing error by vstinner · Pull Request #8242 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: bpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not released (by err_i...

X Description: bpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not releas...

Mail addresses
storchaka@gmail.com
angwerzx@126.com

Opengraph URL: https://github.com/python/cpython/pull/8242

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e8673aea-e616-ecfa-d113-d195b56fbb55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB4BE:24BC9A:3B2D618:514FD9F:6A54C0DA
html-safe-nonceff066cf6172214900ea696ede806981811cf8c517075539fed49444ce6ea9b60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEJFOjI0QkM5QTozQjJENjE4OjUxNEZEOUY6NkE1NEMwREEiLCJ2aXNpdG9yX2lkIjoiNTYzMTczMTEwNjUxNDc4MDM3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5aa160fffe073e0d2264f63b0bd6e9ec60fde16f0457655aa0210e023c9e35ea
hovercard-subject-tagpull_request:200637525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/8242/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c54f8cbdeb5004413517edd50428195445f72e120bad77f3d7e96e795ce0e2b/python/cpython/pull/8242
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c54f8cbdeb5004413517edd50428195445f72e120bad77f3d7e96e795ce0e2b/python/cpython/pull/8242
og:image:altbpo-34080, bpo-34084: err_free() now always releases 'text' memory allocated by PyObject_Malloc() to fix a memory leak on parsing error. Previously, err->text was not released (by err_i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release69f9664dd5e7a82ba8ab1b4cb7f5a2f09333ab38
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8242#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8242
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8242
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8242
Reloadhttps://github.com/python/cpython/pull/8242
Reloadhttps://github.com/python/cpython/pull/8242
Please reload this pagehttps://github.com/python/cpython/pull/8242
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8242
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/8242
Commits2 (2)https://github.com/python/cpython/pull/8242/commits
Checkshttps://github.com/python/cpython/pull/8242/checks
Files changedhttps://github.com/python/cpython/pull/8242/files
bpo-34080: Fix memory leak on parsing errorhttps://github.com/python/cpython/pull/8242#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issue-340161074
Please reload this pagehttps://github.com/python/cpython/pull/8242
bpo-34080https://bugs.python.org/issue?@action=redirect&bpo=34080
bpo-34084https://bugs.python.org/issue?@action=redirect&bpo=34084
https://bugs.python.org/issue34080https://bugs.python.org/issue34080
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Jul 11, 2018https://github.com/python/cpython/pull/8242#event-1727447170
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
serhiy-storchakahttps://github.com/serhiy-storchaka
zhangyangyuhttps://github.com/zhangyangyu
July 11, 2018 09:24https://github.com/python/cpython/pull/8242#event-1727447195
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 11, 2018https://github.com/python/cpython/pull/8242#event-1727447256
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 11, 2018https://github.com/python/cpython/pull/8242#event-1727447286
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018 https://github.com/python/cpython/pull/8242#ref-pullrequest-339740824
bpo-34080: Fix a memory leak in the compiler. #8222 https://github.com/python/cpython/pull/8222
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404108327
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404109743
bpo-34084https://bugs.python.org/issue?@action=redirect&bpo=34084
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018 https://github.com/python/cpython/pull/8242#pullrequestreview-136164065
View reviewed changes https://github.com/python/cpython/pull/8242/files
Parser/parsetok.chttps://github.com/python/cpython/pull/8242/files#diff-4f288ddeb5a08a904223ec054b3f2fa2380ecdb76951e11fe7192ea6536bae44
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#discussion_r201627574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8242
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#discussion_r201640633
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404115551
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/zhangyangyu
bpo-34080https://bugs.python.org/issue?@action=redirect&bpo=34080
: Fix memory leak on parsing errorhttps://github.com/python/cpython/pull/8242/commits/622453192f7c385e79a1560fdb7fa6e2899cdd64
6224531https://github.com/python/cpython/pull/8242/commits/622453192f7c385e79a1560fdb7fa6e2899cdd64
bpo-34080https://bugs.python.org/issue?@action=redirect&bpo=34080
bpo-34084https://bugs.python.org/issue?@action=redirect&bpo=34084
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404122318
bpo-34084https://bugs.python.org/issue?@action=redirect&bpo=34084
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#event-1727586461
https://github.com/zhangyangyu
zhangyangyuhttps://github.com/zhangyangyu
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404140922
Please reload this pagehttps://github.com/python/cpython/pull/8242
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404141583
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
Only clear err->text in err_free()https://github.com/python/cpython/pull/8242/commits/fdf73c9036aad00b0ca5a309734cd2a62329bab8
fdf73c9https://github.com/python/cpython/pull/8242/commits/fdf73c9036aad00b0ca5a309734cd2a62329bab8
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404149146
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/zhangyangyu
zhangyangyuhttps://github.com/zhangyangyu
Jul 11, 2018 https://github.com/python/cpython/pull/8242#pullrequestreview-136221907
View reviewed changes https://github.com/python/cpython/pull/8242/files/fdf73c9036aad00b0ca5a309734cd2a62329bab8
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404180260
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018 https://github.com/python/cpython/pull/8242#pullrequestreview-136260279
View reviewed changes https://github.com/python/cpython/pull/8242/files/fdf73c9036aad00b0ca5a309734cd2a62329bab8
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/8242#pullrequestreview-136260279
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8222https://github.com/python/cpython/pull/8222
Please reload this pagehttps://github.com/python/cpython/pull/8242
Python/pythonrun.chttps://github.com/python/cpython/pull/8242/files/fdf73c9036aad00b0ca5a309734cd2a62329bab8#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#discussion_r201706832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#8222https://github.com/python/cpython/pull/8222
Please reload this pagehttps://github.com/python/cpython/pull/8242
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#discussion_r201730682
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404209091
#8222https://github.com/python/cpython/pull/8222
https://bugs.python.org/issue34084https://bugs.python.org/issue34084
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404217105
#8222https://github.com/python/cpython/pull/8222
https://bugs.python.org/issue34084https://bugs.python.org/issue34084
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404312636
#8222https://github.com/python/cpython/pull/8222
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#event-1728956938
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
July 11, 2018 21:18https://github.com/python/cpython/pull/8242#event-1728957045
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2018https://github.com/python/cpython/pull/8242#issuecomment-404314272
https://bugs.python.org/issue34084https://bugs.python.org/issue34084
#8259https://github.com/python/cpython/pull/8259
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8242
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/8242/files/fdf73c9036aad00b0ca5a309734cd2a62329bab8
https://github.com/zhangyangyu
zhangyangyu https://github.com/zhangyangyu
https://github.com/python/cpython/pull/8242/files/fdf73c9036aad00b0ca5a309734cd2a62329bab8
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Please reload this pagehttps://github.com/python/cpython/pull/8242
https://github.com/vstinner
https://github.com/serhiy-storchaka
https://github.com/zhangyangyu
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.