René's URL Explorer Experiment


Title: [3.7] bpo-32568: make select.epoll() and its docs consistent (GH-7840) by miss-islington · Pull Request #8024 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-32568: make select.epoll() and its docs consistent (GH-7840) by miss-islington · Pull Request #8024 · python/cpython

X Title: [3.7] bpo-32568: make select.epoll() and its docs consistent (GH-7840) by miss-islington · Pull Request #8024 · python/cpython

Description: flags is indeed deprecated, but there is a validation on its value for backwards compatibility reasons. This adds mention of this in the docs. The docs say that sizehint is deprecated and ignored, but it is still used when epoll_create1() is unavailable. This adds mention of this in the docs. sizehint=-1 is acceptable again, and is replaced with FD_SETSIZE-1. This is needed to have a default value available at the Python level, since FD_SETSIZE is not exposed to Python. (see: bpo-31938) Reject sizehint=0 since it is invalid to pass on to epoll_create(). The relevant tests have also been updated. (cherry picked from commit 0cdf5f4) Co-authored-by: Tal Einat taleinat+github@gmail.com https://bugs.python.org/issue32568

Open Graph Description: flags is indeed deprecated, but there is a validation on its value for backwards compatibility reasons. This adds mention of this in the docs. The docs say that sizehint is deprecated and ignored,...

X Description: flags is indeed deprecated, but there is a validation on its value for backwards compatibility reasons. This adds mention of this in the docs. The docs say that sizehint is deprecated and ignored,...

Opengraph URL: https://github.com/python/cpython/pull/8024

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61800b7f-054e-c7ed-f2b2-a5e125d8691d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE222:1610AC:FCC46A:153171D:69699196
html-safe-nonce834e727ded394c5bdfe93f2afebc252be27c7aefb9c7372faa9c5dde87dd7f3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjIyOjE2MTBBQzpGQ0M0NkE6MTUzMTcxRDo2OTY5OTE5NiIsInZpc2l0b3JfaWQiOiI4NzQ5NDEyNzUxMDEzMTU1MjIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7b209801633cb40d55b400c6e1dad18b41ba633c0c9aff3ac0ee4112b5b582db
hovercard-subject-tagpull_request:198475218
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/8024/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altflags is indeed deprecated, but there is a validation on its value for backwards compatibility reasons. This adds mention of this in the docs. The docs say that sizehint is deprecated and ignored,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/8024/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8024%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F8024%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/8024/files
Reloadhttps://github.com/python/cpython/pull/8024/files
Reloadhttps://github.com/python/cpython/pull/8024/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/8024/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/8024/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
taleinathttps://github.com/taleinat
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-0cdf5f4-3.7https://github.com/miss-islington/cpython/tree/backport-0cdf5f4-3.7
Conversation 1 https://github.com/python/cpython/pull/8024
Commits 1 https://github.com/python/cpython/pull/8024/commits
Checks 0 https://github.com/python/cpython/pull/8024/checks
Files changed https://github.com/python/cpython/pull/8024/files
Please reload this pagehttps://github.com/python/cpython/pull/8024/files
[3.7] bpo-32568: make select.epoll() and its docs consistent (GH-7840) https://github.com/python/cpython/pull/8024/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/8024/files
c961444 bpo-32568: make select.epoll() and its docs consistent (GH-7840) taleinat Jun 30, 2018 https://github.com/python/cpython/pull/8024/commits/c9614448f1c69c7f0d494cd94ebae2b9f1e7cb74
Clear filters https://github.com/python/cpython/pull/8024/files
Please reload this pagehttps://github.com/python/cpython/pull/8024/files
Please reload this pagehttps://github.com/python/cpython/pull/8024/files
select.rst https://github.com/python/cpython/pull/8024/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
test_epoll.py https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
2018-06-21-09-33-02.bpo-32568.f_meGY.rst https://github.com/python/cpython/pull/8024/files#diff-d5135506dbdc491aea24a6ca24946721d98e18abe53f9304cb5c71934b40d0be
selectmodule.c https://github.com/python/cpython/pull/8024/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
Doc/library/select.rsthttps://github.com/python/cpython/pull/8024/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
View file https://github.com/miss-islington/cpython/blob/c9614448f1c69c7f0d494cd94ebae2b9f1e7cb74/Doc/library/select.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8024/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8024/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
https://github.com/python/cpython/pull/8024/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
Lib/test/test_epoll.pyhttps://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
View file https://github.com/miss-islington/cpython/blob/c9614448f1c69c7f0d494cd94ebae2b9f1e7cb74/Lib/test/test_epoll.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8024/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/8024/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
Misc/NEWS.d/next/Library/2018-06-21-09-33-02.bpo-32568.f_meGY.rsthttps://github.com/python/cpython/pull/8024/files#diff-d5135506dbdc491aea24a6ca24946721d98e18abe53f9304cb5c71934b40d0be
View file https://github.com/miss-islington/cpython/blob/c9614448f1c69c7f0d494cd94ebae2b9f1e7cb74/Misc/NEWS.d/next/Library/2018-06-21-09-33-02.bpo-32568.f_meGY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8024/{{ revealButtonHref }}
Modules/selectmodule.chttps://github.com/python/cpython/pull/8024/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
View file https://github.com/miss-islington/cpython/blob/c9614448f1c69c7f0d494cd94ebae2b9f1e7cb74/Modules/selectmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/8024/{{ revealButtonHref }}
https://github.com/python/cpython/pull/8024/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com/python/cpython/pull/8024/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com/python/cpython/pull/8024/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.