René's URL Explorer Experiment


Title: bpo-32568: make select.epoll() and its docs consistent by taleinat · Pull Request #7840 · python/cpython · GitHub

Open Graph Title: bpo-32568: make select.epoll() and its docs consistent by taleinat · Pull Request #7840 · python/cpython

X Title: bpo-32568: make select.epoll() and its docs consistent by taleinat · Pull Request #7840 · python/cpython

Description: The docs for select.epoll() are currently out of sync with the implementation with regard to the sizehint and flags parameters. flags is indeed deprecated, but there was a validation on its value, contrary to the docs saying it is "completely ignored". This removes that check. sizehint is still used when epoll_create1() is unavailable, so this adds mention of this in the docs. Make sizehint accept -1 again, which is replaced with FD_SETSIZE-1. This is needed to have a default value available at the Python level allowing to set this, since FD_SETSIZE is not exposed to Python. (see: bpo-31938) https://bugs.python.org/issue32568

Open Graph Description: The docs for select.epoll() are currently out of sync with the implementation with regard to the sizehint and flags parameters. flags is indeed deprecated, but there was a validation on its value,...

X Description: The docs for select.epoll() are currently out of sync with the implementation with regard to the sizehint and flags parameters. flags is indeed deprecated, but there was a validation on its value,...

Opengraph URL: https://github.com/python/cpython/pull/7840

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:57e62653-b4c2-2e31-aa03-0ae0875613eb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEF2:3244AB:405C64:565D86:69697E74
html-safe-nonce7867fb7f83ecf81409e8d2667f095ce7fbbdcee7167da25ae71a7251a3f9901d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUYyOjMyNDRBQjo0MDVDNjQ6NTY1RDg2OjY5Njk3RTc0IiwidmlzaXRvcl9pZCI6IjY2OTM4NDI4ODQ5MTEyNjc0NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3daff8fd4f4a77823e86e2990622dd0e949f585a1fb1ed4f7704974074b209db
hovercard-subject-tagpull_request:196350471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/7840/files
twitter:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/532281?s=400&v=4
og:image:altThe docs for select.epoll() are currently out of sync with the implementation with regard to the sizehint and flags parameters. flags is indeed deprecated, but there was a validation on its value,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/7840/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7840%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7840%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/7840/files
Reloadhttps://github.com/python/cpython/pull/7840/files
Reloadhttps://github.com/python/cpython/pull/7840/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/7840/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/7840/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
taleinathttps://github.com/taleinat
python:masterhttps://github.com/python/cpython/tree/master
taleinat:bpo-32568https://github.com/taleinat/cpython/tree/bpo-32568
Conversation 14 https://github.com/python/cpython/pull/7840
Commits 5 https://github.com/python/cpython/pull/7840/commits
Checks 0 https://github.com/python/cpython/pull/7840/checks
Files changed https://github.com/python/cpython/pull/7840/files
Please reload this pagehttps://github.com/python/cpython/pull/7840/files
bpo-32568: make select.epoll() and its docs consistent https://github.com/python/cpython/pull/7840/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/7840/files
4694516 bpo-32568: make select.epoll() and its docs consistent taleinat Jun 21, 2018 https://github.com/python/cpython/pull/7840/commits/46945161d70e8862b175c57be9c045fec1bae199
513da96 bpo-32568: revise NEWS entry as per CR taleinat Jun 22, 2018 https://github.com/python/cpython/pull/7840/commits/513da96f80d111308e8a6bc4f3e5d075170518ee
6aa1d21 bpo-32568: update epoll test about not checking the value of flags taleinat Jun 25, 2018 https://github.com/python/cpython/pull/7840/commits/6aa1d219d4877efeeabc6311180c21a2d793402b
a06cb2e bpo-32568: reject sizehint=0 and revert removal of flags value check taleinat Jun 25, 2018 https://github.com/python/cpython/pull/7840/commits/a06cb2e3719496f161e980714d9c99ae53c84f11
e6a830e bpo-32568: minor indentation fix taleinat Jun 28, 2018 https://github.com/python/cpython/pull/7840/commits/e6a830e1277617ea2ba3aea40dd91ccbf3de09e7
Clear filters https://github.com/python/cpython/pull/7840/files
Please reload this pagehttps://github.com/python/cpython/pull/7840/files
Please reload this pagehttps://github.com/python/cpython/pull/7840/files
select.rst https://github.com/python/cpython/pull/7840/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
test_epoll.py https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
2018-06-21-09-33-02.bpo-32568.f_meGY.rst https://github.com/python/cpython/pull/7840/files#diff-d5135506dbdc491aea24a6ca24946721d98e18abe53f9304cb5c71934b40d0be
selectmodule.c https://github.com/python/cpython/pull/7840/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
Doc/library/select.rsthttps://github.com/python/cpython/pull/7840/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
View file https://github.com/taleinat/cpython/blob/e6a830e1277617ea2ba3aea40dd91ccbf3de09e7/Doc/library/select.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7840/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7840/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
https://github.com/python/cpython/pull/7840/files#diff-b5ba6dd6e3d3d1c84eb39a00ae7e31d0b92ce53f2f5921ccb82d449aeef7ae8e
Lib/test/test_epoll.pyhttps://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
View file https://github.com/taleinat/cpython/blob/e6a830e1277617ea2ba3aea40dd91ccbf3de09e7/Lib/test/test_epoll.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7840/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
https://github.com/python/cpython/pull/7840/files#diff-ad08633ed799f52a6be1f3cf02157936cd4cfdce7451d2fe4d4f80a78eaf9fd0
Misc/NEWS.d/next/Library/2018-06-21-09-33-02.bpo-32568.f_meGY.rsthttps://github.com/python/cpython/pull/7840/files#diff-d5135506dbdc491aea24a6ca24946721d98e18abe53f9304cb5c71934b40d0be
View file https://github.com/taleinat/cpython/blob/e6a830e1277617ea2ba3aea40dd91ccbf3de09e7/Misc/NEWS.d/next/Library/2018-06-21-09-33-02.bpo-32568.f_meGY.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7840/{{ revealButtonHref }}
Modules/selectmodule.chttps://github.com/python/cpython/pull/7840/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
View file https://github.com/taleinat/cpython/blob/e6a830e1277617ea2ba3aea40dd91ccbf3de09e7/Modules/selectmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7840/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7840/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com/python/cpython/pull/7840/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com/python/cpython/pull/7840/files#diff-1b355c9727316ead32069160a2974d6a4cf4d4b01e29901e60983fe45733ba35
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.