Title: bpo-36885: Clean up and reduce visual clutter in the makeunicode.py script. by scoder · Pull Request #7558 · python/cpython · GitHub
Open Graph Title: bpo-36885: Clean up and reduce visual clutter in the makeunicode.py script. by scoder · Pull Request #7558 · python/cpython
X Title: bpo-36885: Clean up and reduce visual clutter in the makeunicode.py script. by scoder · Pull Request #7558 · python/cpython
Description: I had the impression that the code generation in the script is more difficult to read than necessary, due to the visual clutter of having the file=fp parameter all over the place. Mentally separating the generated code from the generating code and its (formatting) arguments is difficult enough. So I cleaned it up with a wrapper function that passes the file argument automatically. I also added line spaces where PEP-8 wants them, and removed a couple of unused variables etc. that my IDE pointed me to. Please tell me if you think there should be a tracker ticket for this. I didn't create one for now, since I consider the change a "trivial" cleanup. I'm also pretty sure that this does not merit a News entry... https://bugs.python.org/issue36885
Open Graph Description: I had the impression that the code generation in the script is more difficult to read than necessary, due to the visual clutter of having the file=fp parameter all over the place. Mentally separati...
X Description: I had the impression that the code generation in the script is more difficult to read than necessary, due to the visual clutter of having the file=fp parameter all over the place. Mentally separati...
Opengraph URL: https://github.com/python/cpython/pull/7558
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a1ccef34-6c7e-3049-5a37-791f8da532ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF6E:2C6DF7:92B156:C9465C:6A4DDADB |
| html-safe-nonce | 7f71dc0f0d38c95cea3123886553e06ca2085b9cfbfee8000b4dbb20a6749c83 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjZFOjJDNkRGNzo5MkIxNTY6Qzk0NjVDOjZBNEREQURCIiwidmlzaXRvcl9pZCI6Ijg4OTQ0ODEwNDgxODE1MjkzMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | df8274ff16ff9db314d95f8b6e641b96570ec62639ba4ed0e122ad32a431673a |
| hovercard-subject-tag | pull_request:193766333 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/7558/files |
| twitter:image | https://avatars.githubusercontent.com/u/491659?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/491659?s=400&v=4 |
| og:image:alt | I had the impression that the code generation in the script is more difficult to read than necessary, due to the visual clutter of having the file=fp parameter all over the place. Mentally separati... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width