René's URL Explorer Experiment


Title: [3.7] bpo-33694: Fix race condition in asyncio proactor (GH-7498) by miss-islington · Pull Request #7499 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-33694: Fix race condition in asyncio proactor (GH-7498) by miss-islington · Pull Request #7499 · python/cpython

X Title: [3.7] bpo-33694: Fix race condition in asyncio proactor (GH-7498) by miss-islington · Pull Request #7499 · python/cpython

Description: The cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _ProactorReadPipeTransport to work around the race condition. Remove the optimized recv_into() implementation to get simple implementation of pause_reading() using the single _pending_data attribute. Move _feed_data_to_bufferred_proto() to protocols.py. Remove set_protocol() method which became useless. (cherry picked from commit 79790bc) Co-authored-by: Victor Stinner vstinner@redhat.com https://bugs.python.org/issue33694

Open Graph Description: The cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...

X Description: The cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...

Opengraph URL: https://github.com/python/cpython/pull/7499

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fbd44a84-cb7c-0527-df23-712e6f8a68a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id987C:42161:EA4BF:152466:6A58A674
html-safe-nonced15be0db621d4718b7431599ab7153ccabcf6d17056238f1897a31ed168170fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdDOjQyMTYxOkVBNEJGOjE1MjQ2Njo2QTU4QTY3NCIsInZpc2l0b3JfaWQiOiIyMzA5Mjg3MTU4MTU3NDUyOTE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2d818404f610dc6d3549690ba5daa72e865038cc1cf0c58b48eb642d0a774fca
hovercard-subject-tagpull_request:193464316
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/7499/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThe cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/7499/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7499%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7499%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/7499/files
Reloadhttps://github.com/python/cpython/pull/7499/files
Reloadhttps://github.com/python/cpython/pull/7499/files
Please reload this pagehttps://github.com/python/cpython/pull/7499/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/7499/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-79790bc-3.7https://github.com/miss-islington/cpython/tree/backport-79790bc-3.7
Conversation 3 https://github.com/python/cpython/pull/7499
Commits 1 https://github.com/python/cpython/pull/7499/commits
Checks 0 https://github.com/python/cpython/pull/7499/checks
Files changed https://github.com/python/cpython/pull/7499/files
Please reload this pagehttps://github.com/python/cpython/pull/7499/files
[3.7] bpo-33694: Fix race condition in asyncio proactor (GH-7498) https://github.com/python/cpython/pull/7499/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/7499/files
161fa84 bpo-33694: Fix race condition in asyncio proactor (GH-7498) vstinner Jun 7, 2018 https://github.com/python/cpython/pull/7499/commits/161fa840b7a27bb023ce75fc980c06484c0081a7
Clear filters https://github.com/python/cpython/pull/7499/files
Please reload this pagehttps://github.com/python/cpython/pull/7499/files
Please reload this pagehttps://github.com/python/cpython/pull/7499/files
proactor_events.py https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
protocols.py https://github.com/python/cpython/pull/7499/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
sslproto.py https://github.com/python/cpython/pull/7499/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
test_proactor_events.py https://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
test_sslproto.py https://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
2018-06-07-23-51-00.bpo-33694.F1zIR1.rst https://github.com/python/cpython/pull/7499/files#diff-c9ffdd80aaf30912bd5f1f83b90ef2b1751879d7cb698de04a1151ff6f0ab349
https://github.com/python/cpython/blob/3.7/.github/CODEOWNERS#L8
Lib/asyncio/proactor_events.pyhttps://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Lib/asyncio/proactor_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7499/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/blob/3.7/.github/CODEOWNERS#L8
Lib/asyncio/protocols.pyhttps://github.com/python/cpython/pull/7499/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Lib/asyncio/protocols.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7499/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
Lib/asyncio/sslproto.pyhttps://github.com/python/cpython/pull/7499/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Lib/asyncio/sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7499/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/7499/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/7499/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/blob/3.7/.github/CODEOWNERS#L8
Lib/test/test_asyncio/test_proactor_events.pyhttps://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Lib/test/test_asyncio/test_proactor_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
https://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
https://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
https://github.com/python/cpython/pull/7499/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
Lib/test/test_asyncio/test_sslproto.pyhttps://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Lib/test/test_asyncio/test_sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/7499/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
Misc/NEWS.d/next/Library/2018-06-07-23-51-00.bpo-33694.F1zIR1.rsthttps://github.com/python/cpython/pull/7499/files#diff-c9ffdd80aaf30912bd5f1f83b90ef2b1751879d7cb698de04a1151ff6f0ab349
View file https://github.com/miss-islington/cpython/blob/161fa840b7a27bb023ce75fc980c06484c0081a7/Misc/NEWS.d/next/Library/2018-06-07-23-51-00.bpo-33694.F1zIR1.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7499/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.