René's URL Explorer Experiment


Title: bpo-33694: Fix race condition on proactor recv() by vstinner · Pull Request #7498 · python/cpython · GitHub

Open Graph Title: bpo-33694: Fix race condition on proactor recv() by vstinner · Pull Request #7498 · python/cpython

X Title: bpo-33694: Fix race condition on proactor recv() by vstinner · Pull Request #7498 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: The cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...

X Description: The cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...

Opengraph URL: https://github.com/python/cpython/pull/7498

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:16f6205c-4b72-4f2c-0086-e56f0a782ed4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA862:3E5B83:CAFC64:123D64F:6A589365
html-safe-nonce99de46064d7cea1a20b45f09ff7bd2792a7b32c628a880f4cb9077198c9ec7a7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODYyOjNFNUI4MzpDQUZDNjQ6MTIzRDY0Rjo2QTU4OTM2NSIsInZpc2l0b3JfaWQiOiI0MDEyMDMwMjE5NzE2Njk0ODg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac57e55c006c87fdee939bdb15409956bb234e4cd3f488ccf7e67e88b9bd4735cf
hovercard-subject-tagpull_request:193457407
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/7498/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cd2b3c56b0e383ca31e847385558f1403f5cef02c5ac0f762a781305ae3c5ecd/python/cpython/pull/7498
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cd2b3c56b0e383ca31e847385558f1403f5cef02c5ac0f762a781305ae3c5ecd/python/cpython/pull/7498
og:image:altThe cancellation of an overlapped WSARecv() has a race condition which causes data loss because of the current implementation of proactor in asyncio. No longer cancel overlapped WSARecv() in _Proac...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/7498#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7498
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7498
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/7498
Reloadhttps://github.com/python/cpython/pull/7498
Reloadhttps://github.com/python/cpython/pull/7498
Please reload this pagehttps://github.com/python/cpython/pull/7498
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/7498
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/7498
Commits4 (4)https://github.com/python/cpython/pull/7498/commits
Checkshttps://github.com/python/cpython/pull/7498/checks
Files changedhttps://github.com/python/cpython/pull/7498/files
bpo-33694: Fix race condition on proactor recv()https://github.com/python/cpython/pull/7498#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 7, 2018https://github.com/python/cpython/pull/7498#issue-330448764
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://bugs.python.org/issue33694https://bugs.python.org/issue33694
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/vstinner
bpo-33694https://bugs.python.org/issue?@action=redirect&bpo=33694
: Fix race condition on proactor recv()https://github.com/python/cpython/pull/7498/commits/337c1a8d8e0ce2cbaac69a4cfe5beffbf52e7acb
337c1a8https://github.com/python/cpython/pull/7498/commits/337c1a8d8e0ce2cbaac69a4cfe5beffbf52e7acb
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/d3ed67d14ed401dfe2b5d07b6941adc3ecacb268/.github/CODEOWNERS#L8
June 7, 2018 21:51https://github.com/python/cpython/pull/7498#event-1669652059
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669652125
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669652142
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 7, 2018https://github.com/python/cpython/pull/7498#issuecomment-395577785
https://bugs.python.org/issue33694https://bugs.python.org/issue33694
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/1st1
1st1https://github.com/1st1
Jun 7, 2018 https://github.com/python/cpython/pull/7498#pullrequestreview-126972631
View reviewed changes https://github.com/python/cpython/pull/7498/files/337c1a8d8e0ce2cbaac69a4cfe5beffbf52e7acb
Lib/asyncio/proactor_events.pyhttps://github.com/python/cpython/pull/7498/files/337c1a8d8e0ce2cbaac69a4cfe5beffbf52e7acb#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
1st1https://github.com/1st1
Jun 7, 2018https://github.com/python/cpython/pull/7498#discussion_r193901736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
vstinnerhttps://github.com/vstinner
Jun 7, 2018https://github.com/python/cpython/pull/7498#discussion_r193903547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
vstinnerhttps://github.com/vstinner
June 8, 2018 00:01https://github.com/python/cpython/pull/7498#commits-pushed-c74aafd
https://github.com/vstinner
Cleanuphttps://github.com/python/cpython/pull/7498/commits/c74aafde3bb5628db75f4a816617e2fed80e77d4
c74aafdhttps://github.com/python/cpython/pull/7498/commits/c74aafde3bb5628db75f4a816617e2fed80e77d4
https://github.com/vstinner
Use sslproto._feed_data_to_bufferred_proto()https://github.com/python/cpython/pull/7498/commits/bf7fe3522c4321c6b4bdb8ba66d1249bcdf2976c
bf7fe35https://github.com/python/cpython/pull/7498/commits/bf7fe3522c4321c6b4bdb8ba66d1249bcdf2976c
https://github.com/1st1
1st1https://github.com/1st1
Jun 7, 2018 https://github.com/python/cpython/pull/7498#pullrequestreview-126975358
View reviewed changes https://github.com/python/cpython/pull/7498/files/bf7fe3522c4321c6b4bdb8ba66d1249bcdf2976c
Lib/asyncio/proactor_events.pyhttps://github.com/python/cpython/pull/7498/files/bf7fe3522c4321c6b4bdb8ba66d1249bcdf2976c#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
1st1https://github.com/1st1
Jun 7, 2018https://github.com/python/cpython/pull/7498#discussion_r193903927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
vstinnerhttps://github.com/vstinner
Jun 7, 2018https://github.com/python/cpython/pull/7498#discussion_r193904607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/1st1
1st1https://github.com/1st1
Jun 7, 2018 https://github.com/python/cpython/pull/7498#pullrequestreview-126975486
View reviewed changes https://github.com/python/cpython/pull/7498/files/bf7fe3522c4321c6b4bdb8ba66d1249bcdf2976c
https://github.com/vstinner
Move _feed_data_to_bufferred_proto() to protocolshttps://github.com/python/cpython/pull/7498/commits/c81003b4ecdc7120a34576d30d46611901da282f
c81003bhttps://github.com/python/cpython/pull/7498/commits/c81003b4ecdc7120a34576d30d46611901da282f
https://github.com/1st1
1st1https://github.com/1st1
Jun 7, 2018 https://github.com/python/cpython/pull/7498#pullrequestreview-126976541
View reviewed changes https://github.com/python/cpython/pull/7498/files/c81003b4ecdc7120a34576d30d46611901da282f
Lib/test/test_asyncio/test_proactor_events.pyhttps://github.com/python/cpython/pull/7498/files/c81003b4ecdc7120a34576d30d46611901da282f#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
1st1https://github.com/1st1
Jun 7, 2018https://github.com/python/cpython/pull/7498#discussion_r193904975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 7, 2018https://github.com/python/cpython/pull/7498#issuecomment-395583485
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/1st1
1st1https://github.com/1st1
Jun 7, 2018https://github.com/python/cpython/pull/7498#issuecomment-395584139
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Jun 7, 2018 https://github.com/python/cpython/pull/7498#pullrequestreview-126978028
View reviewed changes https://github.com/python/cpython/pull/7498/files/c81003b4ecdc7120a34576d30d46611901da282f
asvetlovhttps://github.com/asvetlov
https://github.com/python/cpython/pull/7498#pullrequestreview-126978028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
79790bchttps://github.com/python/cpython/commit/79790bc35fe722a49977b52647f9b5fe1deda2b7
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669702284
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669702328
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
June 7, 2018 22:25https://github.com/python/cpython/pull/7498#event-1669702393
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669702752
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Jun 7, 2018https://github.com/python/cpython/pull/7498#issuecomment-395585250
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/7498
miss-islingtonhttps://github.com/miss-islington
Jun 7, 2018 https://github.com/python/cpython/pull/7498#ref-commit-161fa84
https://github.com/vstinner
https://github.com/miss-islington
bpo-33694: Fix race condition in asyncio proactor (https://github.com/miss-islington/cpython/commit/161fa840b7a27bb023ce75fc980c06484c0081a7
pythonGH-7498https://github.com/python/cpython/pull/7498
)https://github.com/miss-islington/cpython/commit/161fa840b7a27bb023ce75fc980c06484c0081a7
161fa84https://github.com/miss-islington/cpython/commit/161fa840b7a27bb023ce75fc980c06484c0081a7
79790bchttps://github.com/miss-islington/cpython/commit/79790bc35fe722a49977b52647f9b5fe1deda2b7
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 7, 2018https://github.com/python/cpython/pull/7498#issuecomment-395585515
GH-7499https://github.com/python/cpython/pull/7499
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Jun 7, 2018https://github.com/python/cpython/pull/7498#event-1669704180
vstinnerhttps://github.com/vstinner
Jun 7, 2018 https://github.com/python/cpython/pull/7498#ref-commit-8fa398d
https://github.com/miss-islington
https://github.com/vstinner
bpo-33694https://bugs.python.org/issue?@action=redirect&bpo=33694
: Fix race condition in asyncio proactor (https://github.com/python/cpython/commit/8fa398d5cecec80990c5642b081f52cbbc6a05eb
GH-7498https://github.com/python/cpython/pull/7498
) (https://github.com/python/cpython/commit/8fa398d5cecec80990c5642b081f52cbbc6a05eb
GH-7499https://github.com/python/cpython/pull/7499
)https://github.com/python/cpython/commit/8fa398d5cecec80990c5642b081f52cbbc6a05eb
8fa398dhttps://github.com/python/cpython/commit/8fa398d5cecec80990c5642b081f52cbbc6a05eb
79790bchttps://github.com/python/cpython/commit/79790bc35fe722a49977b52647f9b5fe1deda2b7
https://github.com/njsmith
njsmithhttps://github.com/njsmith
Jun 8, 2018https://github.com/python/cpython/pull/7498#issuecomment-395603917
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jun 8, 2018 https://github.com/python/cpython/pull/7498#ref-pullrequest-330291319
WIP: bpo-33694, asyncio: fix proactor transport pause/resume #7479 https://github.com/python/cpython/pull/7479
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7498
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/7498/files/c81003b4ecdc7120a34576d30d46611901da282f
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/python/cpython/pull/7498/files/c81003b4ecdc7120a34576d30d46611901da282f
Please reload this pagehttps://github.com/python/cpython/pull/7498
https://github.com/vstinner
https://github.com/1st1
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/njsmith
https://github.com/asvetlov
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.