René's URL Explorer Experiment


Title: bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol() by 1st1 · Pull Request #7486 · python/cpython · GitHub

Open Graph Title: bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol() by 1st1 · Pull Request #7486 · python/cpython

X Title: bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol() by 1st1 · Pull Request #7486 · python/cpython

Description: Refactor Proactor's data receiving code path. The idea is to always use recv_into() and to emulate the old Protocol.data_received() path. This way there is no read cancellation race or data loss in set_protocol() and there's no performance degradation for both Protocol and BufferedProtocol. This PR removes some outdated and now irrelevant proactor mock tests (most of the removed mocked tests have an alternative working test for BufferedProtocol). https://bugs.python.org/issue33694

Open Graph Description: Refactor Proactor's data receiving code path. The idea is to always use recv_into() and to emulate the old Protocol.data_received() path. This way there is no read cancellation race or data lo...

X Description: Refactor Proactor's data receiving code path. The idea is to always use recv_into() and to emulate the old Protocol.data_received() path. This way there is no read cancellation race or dat...

Opengraph URL: https://github.com/python/cpython/pull/7486

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fe0faf6f-81c7-692e-b266-05b1c3fb5455
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7B8:6464A:2C98CEC:3FB2846:6A5909CF
html-safe-nonceeab44e1465ed7ce83db0309ed02c020e130790d2cc97c290f18b462713165560
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0I4OjY0NjRBOjJDOThDRUM6M0ZCMjg0Njo2QTU5MDlDRiIsInZpc2l0b3JfaWQiOiI4OTkzNTk1OTkxMjkyMTg1MDM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfc2181db93806a12e2025ed4d95c013631081959cdcdaf0b3cf6659737fd9c5d
hovercard-subject-tagpull_request:193379741
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/7486/files
twitter:imagehttps://avatars.githubusercontent.com/u/239003?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/239003?s=400&v=4
og:image:altRefactor Proactor's data receiving code path. The idea is to always use recv_into() and to emulate the old Protocol.data_received() path. This way there is no read cancellation race or data lo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb8ea312922ccce63e833964f9606d971cffb2d5b6c10a62c4a7dcc48d826e2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release886a6c6fbce3d3caad5b3b995ef09ff6ca23f10e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/7486/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7486%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7486%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/7486/files
Reloadhttps://github.com/python/cpython/pull/7486/files
Reloadhttps://github.com/python/cpython/pull/7486/files
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
1st1:fix_proactorhttps://github.com/1st1/cpython/tree/fix_proactor
Conversation 1 https://github.com/python/cpython/pull/7486
Commits 1 https://github.com/python/cpython/pull/7486/commits
Checks 0 https://github.com/python/cpython/pull/7486/checks
Files changed https://github.com/python/cpython/pull/7486/files
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol() https://github.com/python/cpython/pull/7486/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/7486/files
8e40d2f bpo-33694: asyncio: Fix race in Proactor's Transport.set_protocol() Jun 7, 2018 https://github.com/python/cpython/pull/7486/commits/8e40d2f2717e8d2b115c7306415ddc2cf7201f5a
Clear filters https://github.com/python/cpython/pull/7486/files
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
proactor_events.py https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
protocols.py https://github.com/python/cpython/pull/7486/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
sslproto.py https://github.com/python/cpython/pull/7486/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
test_events.py https://github.com/python/cpython/pull/7486/files#diff-b125df0ba39acde9a49ff4ce6a554310cab3daf258a2e77c219fce5a8b17c146
test_proactor_events.py https://github.com/python/cpython/pull/7486/files#diff-64f40794e7d328f5f5c7cf78bcc305c6f17ff02e5b9ebd1c78b6cbc5dc865187
test_sslproto.py https://github.com/python/cpython/pull/7486/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
2018-06-07-12-24-11.bpo-33694.NjSAqI.rst https://github.com/python/cpython/pull/7486/files#diff-513b22f8c708b912baff155d536dca562b7e33e05d7df710218be044b3326b3d
Lib/asyncio/proactor_events.pyhttps://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
View file https://github.com/1st1/cpython/blob/8e40d2f2717e8d2b115c7306415ddc2cf7201f5a/Lib/asyncio/proactor_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7486/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
https://github.com/python/cpython/pull/7486/files#diff-15176d64608861034db7168743f4f116f4cb33422cf685a2b911481c55826aa2
Lib/asyncio/protocols.pyhttps://github.com/python/cpython/pull/7486/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
View file https://github.com/1st1/cpython/blob/8e40d2f2717e8d2b115c7306415ddc2cf7201f5a/Lib/asyncio/protocols.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7486/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7486/files#diff-f5a3b7894911b1b0fd7157155afcf6addd8196e207bc5fd7bbdd0793a237c697
Lib/asyncio/sslproto.pyhttps://github.com/python/cpython/pull/7486/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
View file https://github.com/1st1/cpython/blob/8e40d2f2717e8d2b115c7306415ddc2cf7201f5a/Lib/asyncio/sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7486/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7486/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/7486/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
https://github.com/python/cpython/pull/7486/files#diff-0ae38bdc337cc724282d20111dc780b8a9c07385c80476cf304d5b3c9ec306ec
Lib/test/test_asyncio/test_events.pyhttps://github.com/python/cpython/pull/7486/files#diff-b125df0ba39acde9a49ff4ce6a554310cab3daf258a2e77c219fce5a8b17c146
View file https://github.com/1st1/cpython/blob/8e40d2f2717e8d2b115c7306415ddc2cf7201f5a/Lib/test/test_asyncio/test_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7486/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7486/files#diff-b125df0ba39acde9a49ff4ce6a554310cab3daf258a2e77c219fce5a8b17c146
https://github.com/python/cpython/pull/7486/files#diff-b125df0ba39acde9a49ff4ce6a554310cab3daf258a2e77c219fce5a8b17c146
Please reload this pagehttps://github.com/python/cpython/pull/7486/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.