Title: WIP: bpo-33694, asyncio: fix proactor transport pause/resume by vstinner · Pull Request #7479 · python/cpython · GitHub
Open Graph Title: WIP: bpo-33694, asyncio: fix proactor transport pause/resume by vstinner · Pull Request #7479 · python/cpython
X Title: WIP: bpo-33694, asyncio: fix proactor transport pause/resume by vstinner · Pull Request #7479 · python/cpython
Description: Fix pause_reading()/resume_reading() of proactor transpors: don't cancel overlapped WSARecv() anymore. Sometimes, cancelling an overlapped WSARecv() looses data since the I/O already completed, but Overlapped.cancel() silently ignores the ERROR_NOT_FOUND error of CancelIoEx(). If the transport is paused, store the result in the transport if it's paused, and only call data_received()/buffer_updated() on resuming reading. The complex part is when the read starts with data_received() but completes during reading is paused and a new protocol using buffer_updated() is set. Or the opposite: transition from buffer_updated() to data_received(). FIXME: get_buffer(-1) error is not handled yet and a fix unit tests on proactor which rely on implementation details are failing, but functional tests pass. https://bugs.python.org/issue33694
Open Graph Description: Fix pause_reading()/resume_reading() of proactor transpors: don't cancel overlapped WSARecv() anymore. Sometimes, cancelling an overlapped WSARecv() looses data since the I/O already completed,...
X Description: Fix pause_reading()/resume_reading() of proactor transpors: don't cancel overlapped WSARecv() anymore. Sometimes, cancelling an overlapped WSARecv() looses data since the I/O already comple...
Opengraph URL: https://github.com/python/cpython/pull/7479
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3dfdc6b9-e1f3-a455-7313-8ff4b19e1cc1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8B86:2CA0F0:1ADBC9E:26AF179:6A58CAEA |
| html-safe-nonce | e24812696c2432360c2f8537eae7674d57c68397a76383d2e2b4f66653066905 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Qjg2OjJDQTBGMDoxQURCQzlFOjI2QUYxNzk6NkE1OENBRUEiLCJ2aXNpdG9yX2lkIjoiNDA1Mzg2NjQxMzgxNTI4NjUwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3fce2331097963e19e1b9b81c36b8192d7c8b179639614be5112019667b49278 |
| hovercard-subject-tag | pull_request:193336196 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/7479/files |
| twitter:image | https://avatars.githubusercontent.com/u/194129?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/194129?s=400&v=4 |
| og:image:alt | Fix pause_reading()/resume_reading() of proactor transpors: don't cancel overlapped WSARecv() anymore. Sometimes, cancelling an overlapped WSARecv() looses data since the I/O already completed,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width