René's URL Explorer Experiment


Title: bpo-33615: avoid extra decref by ericsnowcurrently · Pull Request #7251 · python/cpython · GitHub

Open Graph Title: bpo-33615: avoid extra decref by ericsnowcurrently · Pull Request #7251 · python/cpython

X Title: bpo-33615: avoid extra decref by ericsnowcurrently · Pull Request #7251 · python/cpython

Description: For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to fail. This patch ensures that refcounts in channels are handled properly. WIP: I'll be iterating against the failing buildbots (particularly "x86 Gentoo Refleaks 3.x") until this is resolved. The problem may have already existed before #6914 (and only surfaced with the new tests). However, I'm going to start from #6914 and then dive deeper. My first stab at the problem involves preventing a race (albeit an unlikely one) in _PyObject_GetCrossInterpreterData(). https://bugs.python.org/issue33615

Open Graph Description: For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to fail. This patch ensures that refcounts in channels are handled properly. WIP: I'll be ite...

X Description: For bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to fail. This patch ensures that refcounts in channels are handled properly. WIP: I'll be...

Opengraph URL: https://github.com/python/cpython/pull/7251

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba916abc-8065-2e06-569e-4587bcdfee99
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDEE:28AE23:483B9:64DF1:696A6BD7
html-safe-noncece8d1c954a04504cef0180f5d737fad5913e2f4a8b500909da0a73bfe9aa4311
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREVFOjI4QUUyMzo0ODNCOTo2NERGMTo2OTZBNkJENyIsInZpc2l0b3JfaWQiOiIyNDg0NjA5MTMxOTEzODMzNDMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb679cb55f182b10b6789c5e9d0477dd283443739ae93f0b8b21bbceb7f9e29c8
hovercard-subject-tagpull_request:191513075
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/7251/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altFor bpo-32604 I added extra subinterpreter-related tests (see #6914), which caused a few buildbots to fail. This patch ensures that refcounts in channels are handled properly. WIP: I'll be ite...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/7251/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7251%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F7251%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/7251/files
Reloadhttps://github.com/python/cpython/pull/7251/files
Reloadhttps://github.com/python/cpython/pull/7251/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/7251/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/7251/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:fix-channel-test-fatal-errorhttps://github.com/ericsnowcurrently/cpython/tree/fix-channel-test-fatal-error
Conversation 6 https://github.com/python/cpython/pull/7251
Commits 3 https://github.com/python/cpython/pull/7251/commits
Checks 0 https://github.com/python/cpython/pull/7251/checks
Files changed https://github.com/python/cpython/pull/7251/files
Please reload this pagehttps://github.com/python/cpython/pull/7251/files
bpo-33615: avoid extra decref https://github.com/python/cpython/pull/7251/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/7251/files
28c15d9 Re-enable the crashing test. ericsnowcurrently Jun 1, 2018 https://github.com/python/cpython/pull/7251/commits/28c15d913edf05cddcbe2cbf8c4fa6b5b9933c29
435ce8b Move incref responsibility to getdata funcs. ericsnowcurrently May 30, 2018 https://github.com/python/cpython/pull/7251/commits/435ce8bdeb6be3082a522e6a725e2e4a2c2aaebb
ea22ea3 Factor out _call_in_interpreter(). ericsnowcurrently May 30, 2018 https://github.com/python/cpython/pull/7251/commits/ea22ea33b995034889a867159d5ee1784e091714
Clear filters https://github.com/python/cpython/pull/7251/files
Please reload this pagehttps://github.com/python/cpython/pull/7251/files
Please reload this pagehttps://github.com/python/cpython/pull/7251/files
pystate.h https://github.com/python/cpython/pull/7251/files#diff-bccfc01bd96b58c022dde77486b8a896cbb31d7581bd4a4156b32c3654afe468
test__xxsubinterpreters.py https://github.com/python/cpython/pull/7251/files#diff-aafe61b536c6466b2aa53aae4b007795bb249f8b7975058c822c99fab8994b47
_xxsubinterpretersmodule.c https://github.com/python/cpython/pull/7251/files#diff-f29800af0b7052514f5cc3d1a5858d704a8f0dee4c88788b741c00a0ff39f8d0
pystate.c https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/internal/pystate.hhttps://github.com/python/cpython/pull/7251/files#diff-bccfc01bd96b58c022dde77486b8a896cbb31d7581bd4a4156b32c3654afe468
View file https://github.com/ericsnowcurrently/cpython/blob/ea22ea33b995034889a867159d5ee1784e091714/Include/internal/pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7251/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7251/files#diff-bccfc01bd96b58c022dde77486b8a896cbb31d7581bd4a4156b32c3654afe468
https://github.com/python/cpython/pull/7251/files#diff-bccfc01bd96b58c022dde77486b8a896cbb31d7581bd4a4156b32c3654afe468
https://github.com/python/cpython/pull/7251/files#diff-bccfc01bd96b58c022dde77486b8a896cbb31d7581bd4a4156b32c3654afe468
Lib/test/test__xxsubinterpreters.pyhttps://github.com/python/cpython/pull/7251/files#diff-aafe61b536c6466b2aa53aae4b007795bb249f8b7975058c822c99fab8994b47
View file https://github.com/ericsnowcurrently/cpython/blob/ea22ea33b995034889a867159d5ee1784e091714/Lib/test/test__xxsubinterpreters.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7251/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7251/files#diff-aafe61b536c6466b2aa53aae4b007795bb249f8b7975058c822c99fab8994b47
https://github.com/python/cpython/pull/7251/files#diff-aafe61b536c6466b2aa53aae4b007795bb249f8b7975058c822c99fab8994b47
Modules/_xxsubinterpretersmodule.chttps://github.com/python/cpython/pull/7251/files#diff-f29800af0b7052514f5cc3d1a5858d704a8f0dee4c88788b741c00a0ff39f8d0
View file https://github.com/ericsnowcurrently/cpython/blob/ea22ea33b995034889a867159d5ee1784e091714/Modules/_xxsubinterpretersmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7251/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7251/files#diff-f29800af0b7052514f5cc3d1a5858d704a8f0dee4c88788b741c00a0ff39f8d0
https://github.com/python/cpython/pull/7251/files#diff-f29800af0b7052514f5cc3d1a5858d704a8f0dee4c88788b741c00a0ff39f8d0
Python/pystate.chttps://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/ericsnowcurrently/cpython/blob/ea22ea33b995034889a867159d5ee1784e091714/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/7251/{{ revealButtonHref }}
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/7251/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.