René's URL Explorer Experiment


Title: bpo-32270: Don't close stdin/out/err in pass_fds by gpshead · Pull Request #6242 · python/cpython · GitHub

Open Graph Title: bpo-32270: Don't close stdin/out/err in pass_fds by gpshead · Pull Request #6242 · python/cpython

X Title: bpo-32270: Don't close stdin/out/err in pass_fds by gpshead · Pull Request #6242 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close their original fds after dup2'ing them to 0/1/2. I still need to create a proper...

X Description: When subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close their original fds after dup2'ing them to 0/1/2. I still need to create ...

Opengraph URL: https://github.com/python/cpython/pull/6242

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cb7793f6-d1df-4365-9753-c27fc993953a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9BE:3092B8:C12B88:C55F4B:6A4DB994
html-safe-noncea979f4a9d5c9895b26e01af290a6a45b1ebd1aabc5b1b2136cd5e69c6984b37c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUJFOjMwOTJCODpDMTJCODg6QzU1RjRCOjZBNERCOTk0IiwidmlzaXRvcl9pZCI6IjY5MzU5MDUyNTc0NTM4OTQwMzYiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmac3140e74629b0c91f64b47e7ac3167f4f75725ba34583c2dc49b7636e467b3288
hovercard-subject-tagpull_request:177306869
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/6242/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/133819e0dafe4cfebcee820ceb62ca1ee0bfda3de203dbc2b0cfb2f2edc5c524/python/cpython/pull/6242
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/133819e0dafe4cfebcee820ceb62ca1ee0bfda3de203dbc2b0cfb2f2edc5c524/python/cpython/pull/6242
og:image:altWhen subprocess.Popen() stdin= stdout= or stderr= handles are specified and appear in pass_fds=, don't close their original fds after dup2'ing them to 0/1/2. I still need to create a proper...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32f7b614aca06e6bbd89842b1370df1328264f68
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/6242#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F6242
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F6242
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/6242
Reloadhttps://github.com/python/cpython/pull/6242
Reloadhttps://github.com/python/cpython/pull/6242
Please reload this pagehttps://github.com/python/cpython/pull/6242
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/6242
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:subprocess-32270https://github.com/gpshead/cpython/tree/subprocess-32270
Conversationhttps://github.com/python/cpython/pull/6242
Commits4 (4)https://github.com/python/cpython/pull/6242/commits
Checkshttps://github.com/python/cpython/pull/6242/checks
Files changedhttps://github.com/python/cpython/pull/6242/files
bpo-32270: Don't close stdin/out/err in pass_fdshttps://github.com/python/cpython/pull/6242#top
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:subprocess-32270https://github.com/gpshead/cpython/tree/subprocess-32270
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 25, 2018https://github.com/python/cpython/pull/6242#issue-308378310
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://bugs.python.org/issue32270https://bugs.python.org/issue32270
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Mar 25, 2018https://github.com/python/cpython/pull/6242#event-1539734419
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 25, 2018https://github.com/python/cpython/pull/6242#event-1539734422
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 25, 2018https://github.com/python/cpython/pull/6242#event-1539734450
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 25, 2018https://github.com/python/cpython/pull/6242#event-1539767743
https://github.com/izbyshev
izbyshevhttps://github.com/izbyshev
Mar 26, 2018 https://github.com/python/cpython/pull/6242#pullrequestreview-107066620
View reviewed changes https://github.com/python/cpython/pull/6242/files
Modules/_posixsubprocess.chttps://github.com/python/cpython/pull/6242/files#diff-e182817ec4633ebe50bbfa9a6d0b7c00be01307f5457abfc85f9689055be908b
izbyshevhttps://github.com/izbyshev
Mar 26, 2018https://github.com/python/cpython/pull/6242#discussion_r177228949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/6242
gpsheadhttps://github.com/gpshead
Sep 10, 2018https://github.com/python/cpython/pull/6242#discussion_r216466578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/ned-deily
ned-deilyhttps://github.com/ned-deily
Jun 7, 2018https://github.com/python/cpython/pull/6242#issuecomment-395300343
@gpsheadhttps://github.com/gpshead
@izbyshevhttps://github.com/izbyshev
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/gpshead
bpo-32270: Don't close stdin/out/err in pass_fdshttps://github.com/python/cpython/pull/6242/commits/657fd10e03623a693da9272d05a1cdaf393d8469
657fd10https://github.com/python/cpython/pull/6242/commits/657fd10e03623a693da9272d05a1cdaf393d8469
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
force-pushedhttps://github.com/python/cpython/compare/b8830884874fda03389b86e5ad15d8605a96c6b7..657fd10e03623a693da9272d05a1cdaf393d8469
b883088https://github.com/python/cpython/commit/b8830884874fda03389b86e5ad15d8605a96c6b7
657fd10https://github.com/python/cpython/commit/657fd10e03623a693da9272d05a1cdaf393d8469
Compare https://github.com/python/cpython/compare/b8830884874fda03389b86e5ad15d8605a96c6b7..657fd10e03623a693da9272d05a1cdaf393d8469
September 10, 2018 20:03https://github.com/python/cpython/pull/6242#event-1836931109
gpsheadhttps://github.com/gpshead
September 10, 2018 13:27https://github.com/python/cpython/pull/6242#commits-pushed-6b7077e
https://github.com/gpshead
Adds a unittest fromhttps://github.com/python/cpython/pull/6242/commits/6b7077eac5b090f10972388cabcdd8c837da2401
@izbyshevhttps://github.com/izbyshev
.https://github.com/python/cpython/pull/6242/commits/6b7077eac5b090f10972388cabcdd8c837da2401
6b7077ehttps://github.com/python/cpython/pull/6242/commits/6b7077eac5b090f10972388cabcdd8c837da2401
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
https://github.com/gpshead
Set c2pwrite & errwrite non-inheritable when dupedhttps://github.com/python/cpython/pull/6242/commits/3561c67d54b94ac151b7433c142005918da30ae5
3561c67https://github.com/python/cpython/pull/6242/commits/3561c67d54b94ac151b7433c142005918da30ae5
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Sep 10, 2018https://github.com/python/cpython/pull/6242#issuecomment-420062189
@izbyshevhttps://github.com/izbyshev
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/gpshead
NEWS!https://github.com/python/cpython/pull/6242/commits/4941a125502842d296e1c58140b13da3aa240bc0
4941a12https://github.com/python/cpython/pull/6242/commits/4941a125502842d296e1c58140b13da3aa240bc0
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
ce34410https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
Sep 11, 2018https://github.com/python/cpython/pull/6242#event-1837361023
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018https://github.com/python/cpython/pull/6242#issuecomment-420107871
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 11, 2018https://github.com/python/cpython/pull/6242#event-1837361055
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018 https://github.com/python/cpython/pull/6242#ref-commit-0be3bb2
https://github.com/gpshead
https://github.com/miss-islington
bpo-32270: Don't close stdin/out/err in pass_fds (https://github.com/miss-islington/cpython/commit/0be3bb22234ede46f374e312581b83a425c35fa9
pythonGH-6242https://github.com/python/cpython/pull/6242
)https://github.com/miss-islington/cpython/commit/0be3bb22234ede46f374e312581b83a425c35fa9
0be3bb2https://github.com/miss-islington/cpython/commit/0be3bb22234ede46f374e312581b83a425c35fa9
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/miss-islington/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Sep 11, 2018https://github.com/python/cpython/pull/6242#event-1837361222
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 11, 2018https://github.com/python/cpython/pull/6242#issuecomment-420107897
GH-9148https://github.com/python/cpython/pull/9148
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Sep 11, 2018https://github.com/python/cpython/pull/6242#event-1837361380
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 11, 2018https://github.com/python/cpython/pull/6242#issuecomment-420107924
GH-9149https://github.com/python/cpython/pull/9149
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/6242
miss-islingtonhttps://github.com/miss-islington
Sep 11, 2018 https://github.com/python/cpython/pull/6242#ref-commit-3774cd5
https://github.com/gpshead
https://github.com/miss-islington
bpo-32270: Don't close stdin/out/err in pass_fds (https://github.com/miss-islington/cpython/commit/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
pythonGH-6242https://github.com/python/cpython/pull/6242
)https://github.com/miss-islington/cpython/commit/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
3774cd5https://github.com/miss-islington/cpython/commit/3774cd5c7a0ce1190c679692a66fcd574d4bc4f3
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/miss-islington/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
September 11, 2018 00:50https://github.com/python/cpython/pull/6242#event-1837365011
gpsheadhttps://github.com/gpshead
Sep 11, 2018 https://github.com/python/cpython/pull/6242#ref-commit-9c4a63f
https://github.com/miss-islington
https://github.com/gpshead
bpo-32270https://bugs.python.org/issue?@action=redirect&bpo=32270
: Don't close stdin/out/err in pass_fds (https://github.com/python/cpython/commit/9c4a63fc17efea31ad41f90d28825be37469e0e2
GH-6242https://github.com/python/cpython/pull/6242
) (https://github.com/python/cpython/commit/9c4a63fc17efea31ad41f90d28825be37469e0e2
GH-9148https://github.com/python/cpython/pull/9148
)https://github.com/python/cpython/commit/9c4a63fc17efea31ad41f90d28825be37469e0e2
9c4a63fhttps://github.com/python/cpython/commit/9c4a63fc17efea31ad41f90d28825be37469e0e2
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
gpsheadhttps://github.com/gpshead
Sep 11, 2018 https://github.com/python/cpython/pull/6242#ref-commit-2173bb8
https://github.com/miss-islington
https://github.com/gpshead
bpo-32270https://bugs.python.org/issue?@action=redirect&bpo=32270
: Don't close stdin/out/err in pass_fds (https://github.com/python/cpython/commit/2173bb818c6c726d831b106ed0d3fad7825905dc
GH-6242https://github.com/python/cpython/pull/6242
) (https://github.com/python/cpython/commit/2173bb818c6c726d831b106ed0d3fad7825905dc
GH-9149https://github.com/python/cpython/pull/9149
)https://github.com/python/cpython/commit/2173bb818c6c726d831b106ed0d3fad7825905dc
2173bb8https://github.com/python/cpython/commit/2173bb818c6c726d831b106ed0d3fad7825905dc
@izbyshevhttps://github.com/izbyshev
izbyshev@b89b52fhttps://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c
ce34410https://github.com/python/cpython/commit/ce34410b8b67f49d8275c05d51b3ead50cf97f48
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F6242
https://github.com/izbyshev
izbyshev https://github.com/izbyshev
https://github.com/python/cpython/pull/6242/files/b8830884874fda03389b86e5ad15d8605a96c6b7
https://github.com/gpshead
gpshead https://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/6242
https://github.com/gpshead
https://github.com/ned-deily
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/izbyshev
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.