René's URL Explorer Experiment


Title: [2.7] bpo-32981: Fix catastrophic backtracking vulns (GH-5955) by benjaminp · Pull Request #5970 · python/cpython · GitHub

Open Graph Title: [2.7] bpo-32981: Fix catastrophic backtracking vulns (GH-5955) by benjaminp · Pull Request #5970 · python/cpython

X Title: [2.7] bpo-32981: Fix catastrophic backtracking vulns (GH-5955) by benjaminp · Pull Request #5970 · python/cpython

Description: Prevent low-grade poplib REDOS (CVE-2018-1060) The regex to test a mail server's timestamp is susceptible to catastrophic backtracking on long evil responses from the server. Happily, the maximum length of malicious inputs is 2K thanks to a limit introduced in the fix for CVE-2013-1752. A 2KB evil response from the mail server would result in small slowdowns (milliseconds vs. microseconds) accumulated over many apop calls. This is a potential DOS vector via accumulated slowdowns. Replace it with a similar non-vulnerable regex. The new regex is RFC compliant. The old regex was non-compliant in edge cases. Prevent difflib REDOS (CVE-2018-1061) The default regex for IS_LINE_JUNK is susceptible to catastrophic backtracking. This is a potential DOS vector. Replace it with an equivalent non-vulnerable regex. Also introduce unit and REDOS tests for difflib. Co-authored-by: Tim Peters tim.peters@gmail.com Co-authored-by: Christian Heimes christian@python.org. (cherry picked from commit 0e6c8ee) https://bugs.python.org/issue32981

Open Graph Description: Prevent low-grade poplib REDOS (CVE-2018-1060) The regex to test a mail server's timestamp is susceptible to catastrophic backtracking on long evil responses from the server. Happily, the maxi...

X Description: Prevent low-grade poplib REDOS (CVE-2018-1060) The regex to test a mail server's timestamp is susceptible to catastrophic backtracking on long evil responses from the server. Happily, the ...

Opengraph URL: https://github.com/python/cpython/pull/5970

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c41dd5e0-50a8-44dd-0534-69237d9a130f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96A2:13C54:595FE3F:7E46D38:6A500F98
html-safe-noncee67bf4909971e70bb2ee491c9621249643b41166b3c5c3b0e282eb1d2921749b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkEyOjEzQzU0OjU5NUZFM0Y6N0U0NkQzODo2QTUwMEY5OCIsInZpc2l0b3JfaWQiOiIzOTY1MzA4NTI2MDg4MTYzMjI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5f6a137733ae30c95d39b60f8648abc6f770eb04ae948f0d96b2ea6836806c72
hovercard-subject-tagpull_request:172703949
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/5970/files
twitter:imagehttps://avatars.githubusercontent.com/u/219470?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/219470?s=400&v=4
og:image:altPrevent low-grade poplib REDOS (CVE-2018-1060) The regex to test a mail server's timestamp is susceptible to catastrophic backtracking on long evil responses from the server. Happily, the maxi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefe4f38b24922a1ce81c1708c3793b47c185599b9144ab94f6ca846b00698058d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42b6390c91978a16f9196c38c7a00e9bf21f37e7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/5970/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5970%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F5970%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/5970/files
Reloadhttps://github.com/python/cpython/pull/5970/files
Reloadhttps://github.com/python/cpython/pull/5970/files
Please reload this pagehttps://github.com/python/cpython/pull/5970/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/5970/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
benjaminphttps://github.com/benjaminp
2.7https://github.com/python/cpython/tree/2.7
backport-0e6c8ee-2.7https://github.com/python/cpython/tree/backport-0e6c8ee-2.7
Conversation 0 https://github.com/python/cpython/pull/5970
Commits 1 https://github.com/python/cpython/pull/5970/commits
Checks 0 https://github.com/python/cpython/pull/5970/checks
Files changed https://github.com/python/cpython/pull/5970/files
Please reload this pagehttps://github.com/python/cpython/pull/5970/files
[2.7] bpo-32981: Fix catastrophic backtracking vulns (GH-5955) https://github.com/python/cpython/pull/5970/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/5970/files
24db3ee [2.7] bpo-32981: Fix catastrophic backtracking vulns (GH-5955) davisjam Mar 4, 2018 https://github.com/python/cpython/pull/5970/commits/24db3eea6be3bac9f6947947a183d83a368d87d1
Clear filters https://github.com/python/cpython/pull/5970/files
Please reload this pagehttps://github.com/python/cpython/pull/5970/files
Please reload this pagehttps://github.com/python/cpython/pull/5970/files
difflib.py https://github.com/python/cpython/pull/5970/files#diff-4517a87c0d1215c3a18d0a4dffffc879ff09b86c522a5396a28c60090a397436
poplib.py https://github.com/python/cpython/pull/5970/files#diff-5828c3a1ed831a879e433ad3b9154676dc6b33a9e21bee89bf9603634640ac6d
test_difflib.py https://github.com/python/cpython/pull/5970/files#diff-84f71b448766eaa44557d993669687080dd4c4bdb5c02de3104d415eaca202fd
test_poplib.py https://github.com/python/cpython/pull/5970/files#diff-dfc395bb81472697996450e929ded612410a115bbc8274208d022c25c174693b
ACKS https://github.com/python/cpython/pull/5970/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2018-03-02-10-24-52.bpo-32981.O_qDyj.rst https://github.com/python/cpython/pull/5970/files#diff-5e8d82d0e5f7e2ae42a0896a7a9bd1658f2f96c0c9b459bb8d20215ad88a68f3
Lib/difflib.pyhttps://github.com/python/cpython/pull/5970/files#diff-4517a87c0d1215c3a18d0a4dffffc879ff09b86c522a5396a28c60090a397436
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Lib/difflib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5970/files#diff-4517a87c0d1215c3a18d0a4dffffc879ff09b86c522a5396a28c60090a397436
https://github.com/python/cpython/pull/5970/files#diff-4517a87c0d1215c3a18d0a4dffffc879ff09b86c522a5396a28c60090a397436
Lib/poplib.pyhttps://github.com/python/cpython/pull/5970/files#diff-5828c3a1ed831a879e433ad3b9154676dc6b33a9e21bee89bf9603634640ac6d
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Lib/poplib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5970/files#diff-5828c3a1ed831a879e433ad3b9154676dc6b33a9e21bee89bf9603634640ac6d
https://github.com/python/cpython/pull/5970/files#diff-5828c3a1ed831a879e433ad3b9154676dc6b33a9e21bee89bf9603634640ac6d
Lib/test/test_difflib.pyhttps://github.com/python/cpython/pull/5970/files#diff-84f71b448766eaa44557d993669687080dd4c4bdb5c02de3104d415eaca202fd
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Lib/test/test_difflib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5970/files#diff-84f71b448766eaa44557d993669687080dd4c4bdb5c02de3104d415eaca202fd
Lib/test/test_poplib.pyhttps://github.com/python/cpython/pull/5970/files#diff-dfc395bb81472697996450e929ded612410a115bbc8274208d022c25c174693b
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Lib/test/test_poplib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5970/files#diff-dfc395bb81472697996450e929ded612410a115bbc8274208d022c25c174693b
https://github.com/python/cpython/pull/5970/files#diff-dfc395bb81472697996450e929ded612410a115bbc8274208d022c25c174693b
Misc/ACKShttps://github.com/python/cpython/pull/5970/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com/python/cpython/pull/5970/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/5970/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Security/2018-03-02-10-24-52.bpo-32981.O_qDyj.rsthttps://github.com/python/cpython/pull/5970/files#diff-5e8d82d0e5f7e2ae42a0896a7a9bd1658f2f96c0c9b459bb8d20215ad88a68f3
View file https://github.com/python/cpython/blob/24db3eea6be3bac9f6947947a183d83a368d87d1/Misc/NEWS.d/next/Security/2018-03-02-10-24-52.bpo-32981.O_qDyj.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/5970/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.